Add an intital HIR and lowering step #28138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
☔ The latest upstream changes (presumably #28136) made this pull request unmergeable. Please resolve the merge conflicts. |
|
is it possible to separate out the ast => hir renamings and other "hyper-rote" fallback into a distinct commit? |
|
ok so this seems fine, r+ modulo the various nits. Per IRC discussion, I think the duplication is ok as long as have a plan to remove it. |
|
Looked through the majority of this as well, the duplicated logic would be worrisome in the long term, but it sounds like you will relatively quickly refactor and remove it. I also like the approach of landing this chunk before it gets too big. 👍 |
|
@bors: r=nikomatsakis p=1 |
|
📌 Commit facdf2e has been approved by |
|
⌛ Testing commit facdf2e with merge cd138dc... |
bors
added a commit
that referenced
this pull request
Sep 2, 2015
r? @nikomatsakis Trying to land this first stab, which basically just duplicates the AST. Will file issues for the various things I've got in mind to improve.
This was referenced Sep 3, 2015
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @nikomatsakis
Trying to land this first stab, which basically just duplicates the AST. Will file issues for the various things I've got in mind to improve.