Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd an intital HIR and lowering step #28138
Conversation
rust-highfive
assigned
nikomatsakis
Sep 1, 2015
nrc
referenced this pull request
Sep 1, 2015
Closed
HIR: tracking issue for HIR-related things. #28139
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
is it possible to separate out the ast => hir renamings and other "hyper-rote" fallback into a distinct commit? |
This comment has been minimized.
This comment has been minimized.
|
ok so this seems fine, r+ modulo the various nits. Per IRC discussion, I think the duplication is ok as long as have a plan to remove it. |
This comment has been minimized.
This comment has been minimized.
|
Looked through the majority of this as well, the duplicated logic would be worrisome in the long term, but it sounds like you will relatively quickly refactor and remove it. I also like the approach of landing this chunk before it gets too big. |
nrc
force-pushed the
nrc:hir
branch
from
50813d3
to
facdf2e
Sep 2, 2015
This comment has been minimized.
This comment has been minimized.
|
@bors: r=nikomatsakis p=1 |
This comment has been minimized.
This comment has been minimized.
|
|
nrc commentedSep 1, 2015
r? @nikomatsakis
Trying to land this first stab, which basically just duplicates the AST. Will file issues for the various things I've got in mind to improve.