Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign uprustfmt librustc_trans/save #28161
Conversation
rust-highfive
assigned
Aatch
Sep 2, 2015
This comment has been minimized.
This comment has been minimized.
|
r? @Aatch (rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
|
Addressed bounds issue |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
r? @brson |
rust-highfive
assigned
brson
and unassigned
Aatch
Sep 4, 2015
This comment has been minimized.
This comment has been minimized.
|
Damn good formatting, right here! r=me |
This comment has been minimized.
This comment has been minimized.
|
Super excited about being able to run |
nrc
added some commits
Sep 2, 2015
nrc
force-pushed the
nrc:fmt
branch
from
a95b231
to
6a127e9
Sep 4, 2015
This comment has been minimized.
This comment has been minimized.
|
@bors: r=brson |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Sep 4, 2015
This comment has been minimized.
This comment has been minimized.
|
@bors: retry force |
bors
added a commit
that referenced
this pull request
Sep 4, 2015
This comment has been minimized.
This comment has been minimized.
cburgdorf
reviewed
Sep 4, 2015
| @@ -653,8 +647,8 @@ impl <'l, 'tcx> DumpCsvVisitor<'l, 'tcx> { | |||
| } | |||
| } | |||
|
|
|||
| fn process_mod(&mut self, | |||
| item: &ast::Item) { // The module in question, represented as an item. | |||
| // `item` is the module in question, represented as an item. | |||
This comment has been minimized.
This comment has been minimized.
cburgdorf
Sep 4, 2015
Contributor
@nrc did you notice that it moved the comment from inside to outside of the function? Is this intentional?
This comment has been minimized.
This comment has been minimized.
nrc
Sep 5, 2015
Author
Member
This was actually a manual fixup, so intentional. The comment is on the arg, so it doesn't matter if it is inside or outside the function.
(This is actually due to an interesting bug in rustfmt - we check to see if everything will fit on one line, then deal with 'inner' comments, in this case by appending them, which causes the line to overflow. It's tricky because the only indicator that the comment will start on the same line is the absence of a newline which isn't in anything's span. So I had to patch around the bug for now...).
nrc commentedSep 2, 2015
No description provided.