GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No description provided.
(rust_highfive has picked a reviewer for you, use r? to override)
Addressed bounds issue
☔️ The latest upstream changes (presumably #28174) made this pull request unmergeable. Please resolve the merge conflicts.
Damn good formatting, right here!
Super excited about being able to run rustfmt on the compiler! 👍 👍
📌 Commit 6a127e9 has been approved by brson
⌛️ Testing commit 6a127e9 with merge b508991...
Auto merge of #28161 - nrc:fmt, r=brson
@bors: retry force
⌛️ Testing commit 6a127e9 with merge 779b2a9...
@nrc did you notice that it moved the comment from inside to outside of the function? Is this intentional?
This was actually a manual fixup, so intentional. The comment is on the arg, so it doesn't matter if it is inside or outside the function.
(This is actually due to an interesting bug in rustfmt - we check to see if everything will fit on one line, then deal with 'inner' comments, in this case by appending them, which causes the line to overflow. It's tricky because the only indicator that the comment will start on the same line is the absence of a newline which isn't in anything's span. So I had to patch around the bug for now...).
☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt