Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openbsd: probe CFG_GCC egcc #28331

Merged
merged 2 commits into from Sep 11, 2015

Conversation

Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@semarie @alexcrichton @bors
@semarie
Copy link
Contributor

semarie commented Sep 10, 2015

under OpenBSD, it could be have present multiples versions of gcc compiler:

  • gcc-4.2 (with patchs) : c/c++ compiler present in /usr/bin. It is unusable to build recent LLVM (so rustc too).
  • gcc/g++ -4.9 : c/c++ compiler, installed as third-party with "ports" mechanism. The compiler is installed in /usr/local as egcc (and eg++).

this PR adds probing for egcc for CFG_GCC, if the first probed gcc is too old. It will set CC and CXX too, in order to pass the variables to LLVM configure if builded.

please note this PR is a first step in order to build rustc under OpenBSD with unpatched tree.

r? @alexcrichton

cc @brson @dhuseby

@rust-highfive rust-highfive assigned alexcrichton Sep 10, 2015

@semarie
openbsd: probe CFG_GCC egcc 
if default CFG_GCC is too old, probe also egcc (which is gcc from
ports).

set CC/CXX too, in order to pass them to LLVM
Loading status checks…
90043cb

@semarie semarie force-pushed the semarie:openbsd-configure-egcc branch from 6cfc67f to 90043cb Sep 10, 2015

@semarie
disable jemalloc on OpenBSD 
depending of the compiler used, jemalloc configure don't detect
correctly some parameters.
Loading status checks…
9ac36f4

@semarie semarie force-pushed the semarie:openbsd-configure-egcc branch from 2402eb0 to 9ac36f4 Sep 10, 2015

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Sep 10, 2015

@bors: r+ 9ac36f4

Thanks!
@semarie

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

semarie commented Sep 10, 2015

I add disabling jemalloc for openbsd: with gcc-4.9 TLS don't seems to be detected correctly, whereas using gcc from base, it is ok. I will investigate it later.

@alexcrichton I would like this PR be tested by buildbot before commit. I don't expect it to work at first time, but as it shouldn't fail for others architectures, @bors may commit it.

@dhuseby what is the OpenBSD version in use on the buildbot ? the latest stable (5.7) ? There were changes on linker recently that may changes some configuration need.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Sep 10, 2015

Unfortunately we don't have a great way to run tests on non-gated builders before it actually lands, but the OpenBSD bot should run the tests regardless when this is merged I believe.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Sep 10, 2015

(it's also fine to file a follow-up PR if tweaks are needed!)

bors added a commit that referenced this pull request Sep 10, 2015

@bors
Auto merge of #28331 - semarie:openbsd-configure-egcc, r=alexcrichton 
under OpenBSD, it could be have present multiples versions of gcc compiler:
  - gcc-4.2 (with patchs) : c/c++ compiler present in `/usr/bin`. It is unusable to build recent LLVM (so rustc too).
  - gcc/g++ -4.9 : c/c++ compiler, installed as third-party with "ports" mechanism. The compiler is installed in `/usr/local` as `egcc` (and `eg++`).

this PR adds probing for `egcc` for `CFG_GCC`, if the first probed `gcc` is too old. It will set `CC` and `CXX` too, in order to pass the variables to LLVM configure if builded.

please note this PR is a first step in order to build rustc under OpenBSD with unpatched tree.

r? @alexcrichton

cc @brson @dhuseby
Loading status checks…
5c56887
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Sep 10, 2015

⌛️ Testing commit 9ac36f4 with merge 5c56887...
@bors

@bors bors merged commit 9ac36f4 into rust-lang:master Sep 11, 2015
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@semarie

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

semarie commented Sep 11, 2015

@dhuseby does g++-4.9 is installed on buildbot ?

LLVM building is failing with checking tool compatibility... configure: error: g++|clang++|icc required but not found.

@semarie semarie deleted the semarie:openbsd-configure-egcc branch Sep 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.