std: Stabilize/deprecate features for 1.4 #28339

alexcrichton · Sep 10, 2015

The FCP is coming to a close and 1.4 is coming out soon, so this brings in the
libs team decision for all library features this cycle.

Stabilized APIs:

<Box<str>>::into_string
Arc::downgrade
Arc::get_mut
Arc::make_mut
Arc::try_unwrap
Box::from_raw
Box::into_raw
CStr::to_str
CStr::to_string_lossy
CString::from_raw
CString::into_raw
IntoRawFd::into_raw_fd
IntoRawFd
IntoRawHandle::into_raw_handle
IntoRawHandle
IntoRawSocket::into_raw_socket
IntoRawSocket
Rc::downgrade
Rc::get_mut
Rc::make_mut
Rc::try_unwrap
Result::expect
String::into_boxed_slice
TcpSocket::read_timeout
TcpSocket::set_read_timeout
TcpSocket::set_write_timeout
TcpSocket::write_timeout
UdpSocket::read_timeout
UdpSocket::set_read_timeout
UdpSocket::set_write_timeout
UdpSocket::write_timeout
Vec::append
Vec::split_off
VecDeque::append
VecDeque::retain
VecDeque::split_off
rc::Weak::upgrade
rc::Weak
slice::Iter::as_slice
slice::IterMut::into_slice
str::CharIndices::as_str
str::Chars::as_str
str::split_at_mut
str::split_at
sync::Weak::upgrade
sync::Weak
thread::park_timeout
thread::sleep

Deprecated APIs

BTreeMap::with_b
BTreeSet::with_b
Option::as_mut_slice
Option::as_slice
Result::as_mut_slice
Result::as_slice
f32::from_str_radix
f64::from_str_radix

Closes #27277
Closes #27718
Closes #27736
Closes #27764
Closes #27765
Closes #27766
Closes #27767
Closes #27768
Closes #27769
Closes #27771
Closes #27773
Closes #27775
Closes #27776
Closes #27785
Closes #27792
Closes #27795
Closes #27797

rust-highfive · Sep 10, 2015

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

alexcrichton · Sep 10, 2015

cc @rust-lang/libs

r? @aturon

eefriedman · Sep 10, 2015

eefriedman reviewed Sep 10, 2015

View changes

eefriedman · Sep 10, 2015

src/liballoc/rc.rs

@@ -263,7 +261,8 @@ impl<T> Rc<T> {
    }

    /// Checks if `Rc::try_unwrap` would return `Ok`.
-    #[unstable(feature = "rc_would_unwrap", reason = "just added for niche usecase",
+    #[unstable(feature = "rc_would_unwrap",
+               reason = "just added for niche usecase",
               issue = "27718")]


This needs a new issue number: this PR closes 27718.

eefriedman · Sep 10, 2015

eefriedman reviewed Sep 10, 2015

View changes

eefriedman · Sep 10, 2015

src/libcollections/string.rs

@@ -733,7 +731,7 @@ impl String {
    /// Converts the string into `Box<str>`.
    ///
    /// Note that this will drop any excess capacity.
-    #[unstable(feature = "box_str",
+    #[unstable(feature = "box_str2",
               reason = "recently added, matches RFC",
               issue = "27785")]


Also needs a new issue number.

This is deprecated, so a new issue isn't necessary in this case.

eefriedman · Sep 10, 2015

eefriedman reviewed Sep 10, 2015

View changes

eefriedman · Sep 10, 2015

src/libstd/ffi/c_str.rs

@@ -205,7 +205,7 @@ impl CString {
    /// The only appropriate argument is a pointer obtained by calling
    /// `into_ptr`. The length of the string will be recalculated
    /// using the pointer.
-    #[unstable(feature = "cstr_memory", reason = "recently added",
+    #[unstable(feature = "cstr_memory2", reason = "recently added",
               issue = "27769")]


Also needs a new issue number

eefriedman · Sep 10, 2015

eefriedman reviewed Sep 10, 2015

View changes

eefriedman · Sep 10, 2015

src/libstd/net/tcp.rs

@@ -154,8 +164,7 @@ impl TcpStream {
    /// # Note
    ///
    /// Some platforms do not provide access to the current timeout.
-    #[unstable(feature = "socket_timeout", reason = "RFC 1047 - recently added",
-               issue = "27773")]
+    #[stable(feature = "socket_timeout", since = "1.4.0")]


The fact that this never works on Windows suggests that maybe we shouldn't be stabilizing it...

This works on Windows as far as I can tell: https://github.com/rust-lang/rust/blob/master/src/libstd/net/tcp.rs#L909

Huh... https://msdn.microsoft.com/en-us/library/windows/desktop/ms738544%28v=vs.85%29.aspx says it doesn't work. But if the test works, then it must work, I guess. Weird.

It's also explicitly stated in the documentation:

Some platforms do not provide access to the current timeout

Gankro · Sep 10, 2015

I thought people didn't like append as a name?

eefriedman · Sep 10, 2015

eefriedman reviewed Sep 10, 2015

View changes

eefriedman · Sep 10, 2015

src/libstd/net/tcp.rs

+    /// Platforms may return a different error code whenever a read times out as
+    /// a result of setting this option. For example Unix typically returns an
+    /// error of the kind `WouldBlock`, but Windows may return `TimedOut`.
+    #[stable(feature = "socket_timeout", since = "1.4.0")]


Are we really sure this is ready to be stabilized? I'm not sure the questions brought up in #27773 have been sufficiently addressed.

If you're sure this is ready to be stabilized, for the comment, I would suggest something more like "The exact meaning of the timeout is platform-specific; reads may block for longer than the given duration. There is no portable way to detect if a read has timed out due to this timeout; the connection should be closed if a read fails with WouldBlock or TimedOut."

Yes, the purpose of this function is to bind the SO_RCVTIMEO option, and it's what it's doing on all platforms. Whether or not this is exactly what you want for your application will depend on use cases, but this provides the appropriate Rust interface to getting/setting these options.

To elaborate on this a bit: we discussed #27773 extensively in the libs team meeting, and I've written up the results of that discussion in a new comment there.

alexcrichton · Sep 11, 2015

@Gankro

I thought people didn't like append as a name?

We discussed this in the libs team meaning, but the ship has long sailed on this. These functions have gone through RFCs multiple times almost, and the functionality is already stable on LinkedList.

aturon · Sep 11, 2015

@Gankro

I thought people didn't like append as a name?

We discussed this in the libs team meaning, but the ship has long sailed on this. These functions have gone through RFCs multiple times almost, and the functionality is already stable on LinkedList.

In particular, if we want to rename, we have to deal with the existing stable functionality. In general, we signed off on completing the collection reform RFC implementation by stabilizing consistent APIs across the collections where they're appropriate.

aturon · Sep 11, 2015

OK, I've checked this over, and r=me -- but I want to give others a bit more time to comment before we send to bors.

Gankro · Sep 11, 2015

shrug works for me

Gankro · Sep 11, 2015

Wait

Or we could deprecate LinkedList

HMMM???

alexcrichton · Sep 13, 2015

@bors: r=aturon

bors · Sep 13, 2015

📌 Commit f0b1326 has been approved by aturon

bors · Sep 13, 2015

⌛️ Testing commit f0b1326 with merge cedbd99...

bors · Sep 13, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

rust-highfive assigned pcwalton Sep 10, 2015

alexcrichton force-pushed the alexcrichton:stabilize-1.4 branch from b384ce1 to b7a319d Sep 10, 2015

rust-highfive assigned aturon and unassigned pcwalton Sep 10, 2015

alexcrichton force-pushed the alexcrichton:stabilize-1.4 branch 3 times, most recently from 1db2831 to 68e1b65 Sep 10, 2015

alexcrichton force-pushed the alexcrichton:stabilize-1.4 branch from 68e1b65 to b20b26f Sep 11, 2015

alexcrichton force-pushed the alexcrichton:stabilize-1.4 branch from b20b26f to f0b1326 Sep 13, 2015

bors merged commit f0b1326 into rust-lang:master Sep 13, 2015
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

bors referenced this pull request Sep 13, 2015
Merged
Correctly walk import lists in AST visitors #28364

nasa42 referenced this pull request Sep 14, 2015
Merged
TWiR Release 96 (14 September 2015). #119

bluss added the relnotes label Sep 15, 2015

alexcrichton deleted the alexcrichton:stabilize-1.4 branch Sep 17, 2015

rust-lang/rust

Join GitHub today

std: Stabilize/deprecate features for 1.4 #28339

Conversation

alexcrichton commented Sep 10, 2015

rust-highfive assigned pcwalton Sep 10, 2015

This comment has been minimized.

rust-highfive commented Sep 10, 2015

alexcrichton force-pushed the alexcrichton:stabilize-1.4 branch from b384ce1 to b7a319d Sep 10, 2015

This comment has been minimized.

alexcrichton commented Sep 10, 2015

rust-highfive assigned aturon and unassigned pcwalton Sep 10, 2015

alexcrichton force-pushed the alexcrichton:stabilize-1.4 branch 3 times, most recently from 1db2831 to 68e1b65 Sep 10, 2015

eefriedman reviewed Sep 10, 2015 View changes

This comment has been minimized.

eefriedman reviewed Sep 10, 2015 View changes

This comment has been minimized.

This comment has been minimized.

eefriedman reviewed Sep 10, 2015 View changes

This comment has been minimized.

eefriedman reviewed Sep 10, 2015 View changes

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Gankro commented Sep 10, 2015

eefriedman reviewed Sep 10, 2015 View changes

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

alexcrichton commented Sep 11, 2015

alexcrichton force-pushed the alexcrichton:stabilize-1.4 branch from 68e1b65 to b20b26f Sep 11, 2015

This comment has been minimized.

aturon commented Sep 11, 2015

This comment has been minimized.

aturon commented Sep 11, 2015

This comment has been minimized.

Gankro commented Sep 11, 2015

This comment has been minimized.

Gankro commented Sep 11, 2015

alexcrichton force-pushed the alexcrichton:stabilize-1.4 branch from b20b26f to f0b1326 Sep 13, 2015

This comment has been minimized.

alexcrichton commented Sep 13, 2015

This comment has been minimized.

bors commented Sep 13, 2015

This comment has been minimized.

bors commented Sep 13, 2015

bors added a commit that referenced this pull request Sep 13, 2015

This comment has been minimized.

bors commented Sep 13, 2015

Hide details View details bors merged commit f0b1326 into rust-lang:master Sep 13, 2015 2 checks passed

2 checks passed

bors referenced this pull request Sep 13, 2015

nasa42 referenced this pull request Sep 14, 2015

bluss added the relnotes label Sep 15, 2015

alexcrichton deleted the alexcrichton:stabilize-1.4 branch Sep 17, 2015

alexcrichton force-pushed the alexcrichton:stabilize-1.4 branch from `b384ce1` to `b7a319d` Sep 10, 2015

alexcrichton force-pushed the alexcrichton:stabilize-1.4 branch 3 times, most recently from `1db2831` to `68e1b65` Sep 10, 2015

eefriedman reviewed Sep 10, 2015

View changes

eefriedman reviewed Sep 10, 2015

View changes

eefriedman reviewed Sep 10, 2015

View changes

eefriedman reviewed Sep 10, 2015

View changes

eefriedman reviewed Sep 10, 2015

View changes

alexcrichton force-pushed the alexcrichton:stabilize-1.4 branch from `68e1b65` to `b20b26f` Sep 11, 2015

alexcrichton force-pushed the alexcrichton:stabilize-1.4 branch from `b20b26f` to `f0b1326` Sep 13, 2015

bors merged commit `f0b1326` into rust-lang:master Sep 13, 2015
2 checks passed