Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3 relnotes #28408

Merged
merged 2 commits into from Sep 15, 2015

Conversation

Projects
None yet
@brson
Copy link
Contributor

brson commented Sep 15, 2015

I'd love to have any tips about highlights and lang stuff I missed. Sadly, this needs to be merged tomorrow.

Rendered

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Sep 15, 2015

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

is overridden and optimized by the implementations for scalars.
* The [`Hasher`] trait now has a number of specialized `write_*`
methods for primitive types, for efficiency.
* The I/O-specific error type, [`std::io::Error`][ie], gained a set of

This comment has been minimized.

@sfackler

sfackler Sep 15, 2015

Member

io::Error::cause also now forwards to the inner Error's.

RELEASES.md Outdated
in many common configurations, using the [`is`], [`downcast`],
[`downcast_ref`] and [`downcast_mut`] methods, similarly to the
[`Any`] trait.
* The [`contains`] method for searching strings now [employes the

This comment has been minimized.

@Munksgaard

Munksgaard Sep 15, 2015

Contributor

employes should probably be employs.

This comment has been minimized.

@Munksgaard

Munksgaard Sep 15, 2015

Contributor

And the contains link doesn't seem to work for me for some reason.

Edit: Perhaps because the link down below says [contains] instead of [contains].

This comment has been minimized.

@bluss

bluss Sep 15, 2015

Contributor

It's not just contains, it's all substring search (&str in &str search) that uses the two way algorithm, that affects methods including contains, find, rfind, split, matches, trim_matches etc.

starts_with / ends_with were also improved in that PR.

RELEASES.md Outdated
methods for accessing the 'inner error', if any: [`get_ref`][iegr],
[`get_mut`][iegm], [`into_inner`][ieii].
* [`process::Child`][pc] gained the [`id`] method, which returns a
`u32` representing the platform-specific process handle.

This comment has been minimized.

@retep998

retep998 Sep 15, 2015

Member

Not a handle! Just a process identifier. There is also an associated handle for each process which is exposed using AsRawHandle.

RELEASES.md Outdated
Breaking Changes
----------------

* The `#[prelude_import]`, an internal implementation detail, was

This comment has been minimized.

@bluss

bluss Sep 15, 2015

Contributor

I think there's a missing word, "The #[prelude_import] attribute",

@arielb1

This comment has been minimized.

Copy link
Contributor

arielb1 commented Sep 15, 2015

@arielb1

This comment has been minimized.

@arielb1

This comment has been minimized.

Copy link
Contributor

arielb1 commented Sep 15, 2015

@arielb1

This comment has been minimized.

Copy link
Contributor

arielb1 commented Sep 15, 2015

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Sep 15, 2015

Woohoo! Thanks for the review folks. This helps a lot.

@bluss

This comment has been minimized.

Copy link
Contributor

bluss commented Sep 15, 2015

I think #26241 is in 1.3 as well? It allows a slew of mutable functionality to String and &mut str. In the end, the library functionality it enables is rather limited, but you can now produce &mut str easily through slicing.

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Sep 15, 2015

@bluss I you are right. I didn't include it because I thought it wasn't stable, but it's 'insta-stable'.

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Sep 15, 2015

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Sep 15, 2015

r? @aturon

Last call. I will back port these in an hour.

@rust-highfive rust-highfive assigned aturon and unassigned nikomatsakis Sep 15, 2015

@aturon

This comment has been minimized.

Copy link
Member

aturon commented Sep 15, 2015

@brson: LGTM

@brson brson force-pushed the brson:relnotes branch from 37b1799 to f57bb9d Sep 15, 2015

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Sep 15, 2015

@bors r=aturon

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Sep 15, 2015

📌 Commit f57bb9d has been approved by aturon

@brson brson added the beta-accepted label Sep 15, 2015

@brson brson referenced this pull request Sep 15, 2015

Merged

1.3 release notes (beta) #28425

@brson brson removed the beta-nominated label Sep 15, 2015

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Sep 15, 2015

⌛️ Testing commit f57bb9d with merge 5e44115...

bors added a commit that referenced this pull request Sep 15, 2015

Auto merge of #28408 - brson:relnotes, r=aturon
I'd love to have any tips about highlights and lang stuff I missed. Sadly, this needs to be merged *tomorrow*.

[Rendered](https://github.com/brson/rust/blob/relnotes/RELEASES.md)

@bors bors merged commit f57bb9d into rust-lang:master Sep 15, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
[win2]: https://github.com/rust-lang/rust/pull/26741
[win3]: https://github.com/rust-lang/rust/pull/26741
[win4]: https://github.com/rust-lang/rust/pull/27210
[xp]: https://github.com/rust-lang/rust/pull/26569

This comment has been minimized.

@SimonSapin

SimonSapin Sep 16, 2015

Contributor

Was this meant to be #26601 instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.