Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upWarn on `pub extern crate`. #28486
Conversation
nrc
added
the
beta-nominated
label
Sep 18, 2015
rust-highfive
assigned
brson
Sep 18, 2015
This comment has been minimized.
This comment has been minimized.
alexcrichton
added
the
relnotes
label
Sep 18, 2015
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Sep 19, 2015
This comment has been minimized.
This comment has been minimized.
bors
merged commit 269c59d
into
rust-lang:master
Sep 19, 2015
alexcrichton
added
the
T-lang
label
Sep 23, 2015
This comment has been minimized.
This comment has been minimized.
|
@rust-lang/lang I have no opinion about backporting this to beta; I certainly don't object, but I also don't think its the end of the world if we end up waiting a release cycle for this warning. |
This comment has been minimized.
This comment has been minimized.
|
Same. It's a very small patch, so relatively harmless. |
nikomatsakis
added
the
beta-accepted
label
Oct 16, 2015
This comment has been minimized.
This comment has been minimized.
|
Given that @nrc nominated it, i'm going to assume he's in favor. |
alexcrichton
removed
the
beta-nominated
label
Oct 16, 2015
This comment has been minimized.
This comment has been minimized.
|
I nominated this at the start of the cycle, I'd not be in favour at this point, but it looks like I'm too late - no harm though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
nrc commentedSep 18, 2015
Temporary 'fix' for #26775
r? @brson