Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: Swap link order of native libs/rust deps #28605

Merged
merged 1 commit into from Oct 1, 2015

Conversation

@alexcrichton
Copy link
Member

alexcrichton commented Sep 23, 2015

This commit swaps the order of linking local native libraries and upstream
native libraries on the linker command line. Detail of bugs this can cause can
be found in #28595, and this change also invalidates the test case that was
added for #12446 which is now considered a bug because the downstream dependency
would need to declare that it depends on the native library somehow.

Closes #28595
[breaking-change]

@rust-highfive
Copy link
Collaborator

rust-highfive commented Sep 23, 2015

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

alexcrichton commented Sep 23, 2015

r? @brson

To be clear, this is going to be a breaking change (as evidenced by the test case that needed to be removed), but I also believe this is a bug fix to correct the test case that was added (e.g. that should definitely work). If we decide to move forward then this should certainly be mentioned in the release notes, and I can write up a longer explanation about what errors might show up and how to fix them.

@rust-highfive rust-highfive assigned brson and unassigned pcwalton Sep 23, 2015
@brson brson added the relnotes label Sep 28, 2015
@brson
Copy link
Contributor

brson commented Sep 28, 2015

Should we crater this? Sounds frightening.

@brson
Copy link
Contributor

brson commented Sep 28, 2015

@brson Yes. Ok, I'll do it.

@brson
Copy link
Contributor

brson commented Sep 29, 2015

Still running.

@brson
Copy link
Contributor

brson commented Sep 30, 2015

@brson
Copy link
Contributor

brson commented Sep 30, 2015

@bors r+

@bors
Copy link
Contributor

bors commented Sep 30, 2015

📌 Commit 0acd11e has been approved by brson

bors added a commit that referenced this pull request Sep 30, 2015
This commit swaps the order of linking local native libraries and upstream
native libraries on the linker command line. Detail of bugs this can cause can
be found in #28595, and this change also invalidates the test case that was
added for #12446 which is now considered a bug because the downstream dependency
would need to declare that it depends on the native library somehow.

Closes #28595
[breaking-change]
@bors
Copy link
Contributor

bors commented Sep 30, 2015

Testing commit 0acd11e with merge baf8021...

@bors
Copy link
Contributor

bors commented Sep 30, 2015

💔 Test failed - auto-linux-64-x-android-t

@alexcrichton alexcrichton force-pushed the alexcrichton:link-native-first branch from 0acd11e to 27f0c78 Oct 1, 2015
@alexcrichton
Copy link
Member Author

alexcrichton commented Oct 1, 2015

@bors: r=brson 27f0c78

@bors
Copy link
Contributor

bors commented Oct 1, 2015

Testing commit 27f0c78 with merge 26a1df3...

bors added a commit that referenced this pull request Oct 1, 2015
This commit swaps the order of linking local native libraries and upstream
native libraries on the linker command line. Detail of bugs this can cause can
be found in #28595, and this change also invalidates the test case that was
added for #12446 which is now considered a bug because the downstream dependency
would need to declare that it depends on the native library somehow.

Closes #28595
[breaking-change]
@bors
Copy link
Contributor

bors commented Oct 1, 2015

💔 Test failed - auto-linux-64-x-android-t

This commit swaps the order of linking local native libraries and upstream
native libraries on the linker command line. Detail of bugs this can cause can
be found in #28595, and this change also invalidates the test case that was
added for #12446 which is now considered a bug because the downstream dependency
would need to declare that it depends on the native library somehow.

Closes #28595
@alexcrichton alexcrichton force-pushed the alexcrichton:link-native-first branch from 27f0c78 to 9502df5 Oct 1, 2015
@alexcrichton
Copy link
Member Author

alexcrichton commented Oct 1, 2015

@bors: r=brson 9502df5

@bors
Copy link
Contributor

bors commented Oct 1, 2015

Testing commit 9502df5 with merge 587be42...

bors added a commit that referenced this pull request Oct 1, 2015
This commit swaps the order of linking local native libraries and upstream
native libraries on the linker command line. Detail of bugs this can cause can
be found in #28595, and this change also invalidates the test case that was
added for #12446 which is now considered a bug because the downstream dependency
would need to declare that it depends on the native library somehow.

Closes #28595
[breaking-change]
@bors bors merged commit 9502df5 into rust-lang:master Oct 1, 2015
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
homu Test successful
Details
@Ms2ger
Copy link
Contributor

Ms2ger commented Oct 1, 2015

@alexcrichton
Copy link
Member Author

alexcrichton commented Oct 1, 2015

Indeed thanks @Ms2ger! I'll also cc @metajack, and I've created a post on internals about this change to help get ahead of any surprising breakage.

@alexcrichton alexcrichton deleted the alexcrichton:link-native-first branch Oct 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.