Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upCheck attribute usage #28650
Conversation
rust-highfive
assigned
arielb1
Sep 25, 2015
This comment has been minimized.
This comment has been minimized.
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
sanxiyn
force-pushed the
sanxiyn:attr-usage
branch
2 times, most recently
from
ab80e64
to
fb22683
Sep 25, 2015
This comment has been minimized.
This comment has been minimized.
|
r? @nrc |
rust-highfive
assigned
nrc
and unassigned
arielb1
Sep 25, 2015
alexcrichton
added
the
relnotes
label
Sep 25, 2015
This comment has been minimized.
This comment has been minimized.
|
Starting a crater build to evaluate the impact |
This comment has been minimized.
This comment has been minimized.
|
Looks like there's only one regression, so should be easy to send a PR for! |
This comment has been minimized.
This comment has been minimized.
|
I’d replace error message wording from “should” to “may only” or “may”. Otherwise always |
nrc
reviewed
Sep 27, 2015
src/librustc/front/check_attr.rs
Outdated
| if words.is_none() { | ||
| return; | ||
| } | ||
| let words = words.unwrap(); |
This comment has been minimized.
This comment has been minimized.
nrc
Sep 27, 2015
Member
nit:
let words = match attr.meta_item_list() {
Some(words) => words,
None => {
return;
}
};
This comment has been minimized.
This comment has been minimized.
|
r=me with the style nit fixed |
sanxiyn
force-pushed the
sanxiyn:attr-usage
branch
2 times, most recently
from
c04e6d9
to
c5a7d17
Sep 28, 2015
This comment has been minimized.
This comment has been minimized.
|
Done. |
This comment has been minimized.
This comment has been minimized.
|
@bors: r+ |
This comment has been minimized.
This comment has been minimized.
|
|
bors
added a commit
that referenced
this pull request
Sep 28, 2015
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
sanxiyn
added some commits
Sep 25, 2015
sanxiyn
force-pushed the
sanxiyn:attr-usage
branch
from
c5a7d17
to
61f5b2b
Oct 2, 2015
This comment has been minimized.
This comment has been minimized.
|
@bors r=nrc |
This comment has been minimized.
This comment has been minimized.
|
|
bors
added a commit
that referenced
this pull request
Oct 2, 2015
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bors
merged commit 61f5b2b
into
rust-lang:master
Oct 2, 2015
sanxiyn
deleted the
sanxiyn:attr-usage
branch
Oct 5, 2015
This comment has been minimized.
This comment has been minimized.
|
IMO we should have made this a warning for one release cycle, but I guess this is fine too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
sanxiyn commentedSep 25, 2015
This is technically a [breaking-change].
Fix #2809.
Fix #22746.