Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign uprequire a method callee's type to outlive the call #29006
Conversation
rust-highfive
assigned
pnkfelix
Oct 12, 2015
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors r+ |
This comment has been minimized.
This comment has been minimized.
|
@bors r=pnkfelix |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
lgtm, I was actually just writing this same PR |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Oct 14, 2015
bors
added a commit
that referenced
this pull request
Oct 14, 2015
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Oct 14, 2015
bors
added a commit
that referenced
this pull request
Oct 14, 2015
bors
added a commit
that referenced
this pull request
Oct 14, 2015
bors
merged commit ed2a11d
into
rust-lang:master
Oct 14, 2015
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This was referenced Oct 14, 2015
arielb1
referenced this pull request
Oct 15, 2015
Closed
Nightly regression around HRTBs, likely connected to wf changes #28934
DanielKeep
referenced this pull request
Oct 19, 2015
Closed
Regression: rvalue temporary "does not live long enough" #29166
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
arielb1 commentedOct 12, 2015
This rather crucial requirement was not checked. In most cases, that
didn't cause any trouble because the argument types are required to
outlive the call and are subtypes of a subformula of the callee type.
However, binary ops are taken by ref only indirectly, without it being
marked in the argument types, which led to the argument types not being
constrained anywhere causing spurious errors (as these are basically
unconstrainable, I don't think this change can break code). Of course,
the old way was also incorrent with contravariance, but that is still
unsound for other reasons.
This also improves rustc::front to get RUST_LOG to somewhat work.
Fixes #28999. That issue is one of the several regression introduced by #28669.
r? @pnkfelix