Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject "+" and "-" when parsing floats. #29050

Merged
merged 1 commit into from Oct 15, 2015

Conversation

Reviewers
No reviews
Assignees

@aturon aturon

Labels
T-libs beta-accepted
Projects
None yet
Milestone
No milestone
5 participants
@rkruppe @rust-highfive @alexcrichton @bors @aturon
@rkruppe
Copy link
Member

rkruppe commented Oct 14, 2015

Fixes #29042
@rkruppe
Reject "+" and "-" when parsing floats. 
Fixes #29042
Loading status checks…
71dcd7f

@rust-highfive rust-highfive assigned aturon Oct 14, 2015

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Oct 14, 2015

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Oct 14, 2015

@bors: r+ 71dcd7f

Thanks!

Also nominating for a backport to beta
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Oct 14, 2015

triage: beta-nomianted

@rust-highfive rust-highfive added the beta-nomianted label Oct 14, 2015

@alexcrichton alexcrichton added beta-nominated T-libs and removed beta-nomianted labels Oct 14, 2015

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Oct 15, 2015

This libs team decided today to accept this for a backport.

@alexcrichton alexcrichton added the beta-accepted label Oct 15, 2015

bors added a commit that referenced this pull request Oct 15, 2015

@bors
Auto merge of #29050 - rkruppe:dec2flt-lonely-sign, r=alexcrichton 
Fixes #29042
Loading status checks…
be3d390
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Oct 15, 2015

⌛️ Testing commit 71dcd7f with merge be3d390...
@bors

@bors bors merged commit 71dcd7f into rust-lang:master Oct 15, 2015
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@brson brson referenced this pull request Oct 16, 2015

Merged

Beta next #29112

@alexcrichton alexcrichton removed the beta-nominated label Oct 16, 2015

@rkruppe rkruppe referenced this pull request Jan 3, 2016

Merged

Make ".".parse::<f32>() and ".".parse::<f64>() return Err #30681

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.