Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upStyle hierarchy #30045
Conversation
GuillaumeGomez
added some commits
Oct 28, 2015
rust-highfive
assigned
brson
Nov 25, 2015
apasel422
reviewed
Nov 25, 2015
| @@ -93,3 +93,4 @@ tmp.*.rs | |||
| version.md | |||
| version.ml | |||
| version.texi | |||
| src/librustdoc/html/styles.rs | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
From our conversation on IRC I thought this was going to be a refactoring of the CSS to make it easy to customize, without explicit support for customization. |
This comment has been minimized.
This comment has been minimized.
|
Previous PR: #29703 |
This comment has been minimized.
This comment has been minimized.
|
@brson: The CSS part to customize the doc interface (its colors to be even more precise) has been splitted out from the big file. So it doesn't change anything for people who don't care about adding new theme and give easier access to the functionality for others. |
GuillaumeGomez
force-pushed the
GuillaumeGomez:style_hierarchy
branch
from
3462807
to
8afe380
Nov 25, 2015
This comment has been minimized.
This comment has been minimized.
|
I still don't feel confident about this, and am going to wait to talk to the tools team again. |
brson
added
I-nominated
T-tools
labels
Nov 25, 2015
This comment has been minimized.
This comment has been minimized.
|
@brson: No problem, we're not in a hurry. |
This comment has been minimized.
This comment has been minimized.
|
@GuillaumeGomez can you remind me the difference between this PR and the previous? |
This comment has been minimized.
This comment has been minimized.
|
This one just adds the possibility to add custom theme. The JS and the CSS are ready, but nothing change for the actual render (since there is only the "main" theme). |
This comment has been minimized.
This comment has been minimized.
|
@GuillaumeGomez thanks again for your patience on this issue. Even though I personally like dark themes, and want to be able to It's a difficult decision, and I'll admit up front that the rationale for First, this opens the door to proliferation of visual design across Second, as with other attempts to overhaul the visual design of On the technical side, while not a large patch, this adds code Complexity accumulates one feature at a time; this is a feature we do I suggest that those that want to customize the rustdoc theme for now |
GuillaumeGomez commentedNov 25, 2015
r? @brson