Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style hierarchy #30045

Closed

Conversation

Projects
None yet
3 participants
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Nov 25, 2015

r? @brson

@@ -93,3 +93,4 @@ tmp.*.rs
version.md
version.ml
version.texi
src/librustdoc/html/styles.rs

This comment has been minimized.

@apasel422

apasel422 Nov 25, 2015

Member

Could you add the newline back to the end of this file?

This comment has been minimized.

@GuillaumeGomez

GuillaumeGomez Nov 25, 2015

Author Member

Done.

@brson

This comment has been minimized.

Copy link
Contributor

brson commented Nov 25, 2015

From our conversation on IRC I thought this was going to be a refactoring of the CSS to make it easy to customize, without explicit support for customization.

@brson

This comment has been minimized.

Copy link
Contributor

brson commented Nov 25, 2015

Previous PR: #29703

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Nov 25, 2015

@brson: The CSS part to customize the doc interface (its colors to be even more precise) has been splitted out from the big file. So it doesn't change anything for people who don't care about adding new theme and give easier access to the functionality for others.

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:style_hierarchy branch from 3462807 to 8afe380 Nov 25, 2015

@brson

This comment has been minimized.

Copy link
Contributor

brson commented Nov 25, 2015

I still don't feel confident about this, and am going to wait to talk to the tools team again.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Nov 25, 2015

@brson: No problem, we're not in a hurry.

@brson

This comment has been minimized.

Copy link
Contributor

brson commented Dec 2, 2015

@GuillaumeGomez can you remind me the difference between this PR and the previous?

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Dec 2, 2015

This one just adds the possibility to add custom theme. The JS and the CSS are ready, but nothing change for the actual render (since there is only the "main" theme).

@brson

This comment has been minimized.

Copy link
Contributor

brson commented Dec 3, 2015

@GuillaumeGomez thanks again for your patience on this issue.

Even though I personally like dark themes, and want to be able to
accomodate your use cases, I am still uneasy about this direction, and
after talking it over with several other team members, I am going to
close this PR.

It's a difficult decision, and I'll admit up front that the rationale for
not accepting it is soft, but it is as follows.

First, this opens the door to proliferation of visual design across
the ecosystem.

Second, as with other attempts to overhaul the visual design of
specific aspects of rust's web presense, we are reluctant to add
features or make major changes, even with limited scope, largely
because we don't have any firm direction when it comes to the overall
visual design of our web properties - we don't have a 'vision' in this
area. We recognize this is a problem for the project and want to fix
it, but are not prepared to do so now.

On the technical side, while not a large patch, this adds code
generation to the rustdoc build system, a complicated solution for a
minor feature that upstream won't even use.

Complexity accumulates one feature at a time; this is a feature we do
not want right now, and accepting it even though its optional
increases the overall complexity of the (already messy) rustdoc
architecture. Reluctantly accepting patches we don't want to maintain
is not something we can do in general, and not something we will do in
this case. Doing so has bit us many times in the past, resulting in
poor design that had to be painfully reversed later. Sometimes we have
to draw the line and say 'no'.

I suggest that those that want to customize the rustdoc theme for now
should use browser-based css customization. We will happily consider
changes to CSS to accomodate such client-side customization.

@brson brson closed this Dec 3, 2015

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:style_hierarchy branch Feb 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.