Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RFC 1214 warnings into errors #30389

Merged
merged 1 commit into from Dec 18, 2015

Conversation

Reviewers
No reviews
Assignees

@arielb1 arielb1

Labels
relnotes
Projects
None yet
Milestone
No milestone
6 participants
@nikomatsakis @jroesch @arielb1 @bors @Manishearth @bluss
@nikomatsakis
Copy link
Contributor

nikomatsakis commented Dec 15, 2015

Make RFC 1214 warnings into errors, and rip out the "warn or err"
associated machinery. Future such attempts should go through lints
anyhow.

There is a fair amount of fallout in the compile-fail tests, as WF
checking now occurs earlier in the process.

r? @arielb1

@rust-highfive rust-highfive assigned arielb1 Dec 15, 2015

@jroesch

This comment has been minimized.

Sign in to view
Copy link
Member

jroesch commented Dec 15, 2015

LGTM, seems to me like a nice clean up pass.
@arielb1

This comment has been minimized.

Sign in to view
Copy link
Contributor

arielb1 commented Dec 15, 2015

At last!

@bors r+
@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

nikomatsakis commented Dec 16, 2015

@bors r=arielb1
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 16, 2015

📌 Commit b5d024d has been approved by arielb1

This was referenced Dec 16, 2015

Closed
Merged

bors added a commit that referenced this pull request Dec 16, 2015

@bors
Auto merge of #30410 - Manishearth:rollup, r=Manishearth 
- Successful merges: #30320, #30368, #30372, #30376, #30388, #30392
- Failed merges: #30354, #30389
785a8a6
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 16, 2015

☔️ The latest upstream changes (presumably #30410) made this pull request unmergeable. Please resolve the merge conflicts.
@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

nikomatsakis commented Dec 18, 2015

@Manishearth to be clear, this did NOT land as part of some rollup, right?
@Manishearth

This comment has been minimized.

Sign in to view
Copy link
Member

Manishearth commented Dec 18, 2015

Yeah, this didn't get rolled up. I tried to, but there were merge conflicts (which is why it got mentioned by the rollups)

(Probably should have prioritized this one and fixed the smaller merge conflicts instead of breaking this PR, but I didn't notice that this PR touched so much. Sorry.)

@nikomatsakis nikomatsakis force-pushed the nikomatsakis:rfc1214-error branch from b5d024d to cd8e914 Dec 18, 2015

@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

nikomatsakis commented Dec 18, 2015

@bors r=arielb1 p=1
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 18, 2015

📌 Commit cd8e914 has been approved by arielb1
@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

nikomatsakis commented Dec 18, 2015

Giving p=1 because this is conflict prone and better to land sooner rather than later so people have more time to adapt.
@nikomatsakis
Make RFC 1214 warnings into errors, and rip out the "warn or err" 
associated machinery. Future such attempts should go through lints
anyhow.

There is a fair amount of fallout in the compile-fail tests, as WF
checking now occurs earlier in the process.
Loading status checks…
dbf994b

@nikomatsakis nikomatsakis force-pushed the nikomatsakis:rfc1214-error branch from cd8e914 to dbf994b Dec 18, 2015

@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

nikomatsakis commented Dec 18, 2015

@bors r=arielb1 p=1
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 18, 2015

📌 Commit dbf994b has been approved by arielb1

bors added a commit that referenced this pull request Dec 18, 2015

@bors
Auto merge of #30389 - nikomatsakis:rfc1214-error, r=arielb1 
Make RFC 1214 warnings into errors, and rip out the "warn or err"
associated machinery. Future such attempts should go through lints
anyhow.

There is a fair amount of fallout in the compile-fail tests, as WF
checking now occurs earlier in the process.

r? @arielb1
5dd29cc
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 18, 2015

⌛️ Testing commit dbf994b with merge 5dd29cc...
@bors

@bors bors merged commit dbf994b into rust-lang:master Dec 18, 2015
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@bors bors referenced this pull request Dec 18, 2015

Merged

Create a visitor for `TypeFoldable`s and use it to fix cleanup issue #20298 #30317

@bluss bluss added the relnotes label Dec 19, 2015

@dtolnay dtolnay referenced this pull request Feb 29, 2016

Merged

feat(codegen): Inhibit generic bounds if skip_serializing #260

@nikomatsakis nikomatsakis deleted the nikomatsakis:rfc1214-error branch Mar 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.