Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PNaCl target info to the makefile target cfgs and initialize the PNaCl target machine if available. #30401

Merged
merged 1 commit into from Dec 19, 2015

Conversation

Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@DiamondLovesYou @alexcrichton @bors
@DiamondLovesYou
Copy link
Contributor

DiamondLovesYou commented Dec 15, 2015

r? @alexcrichton

@rust-highfive rust-highfive assigned alexcrichton Dec 15, 2015

src/librustc_llvm/lib.rs Outdated
// PNaCl doesn't provide some of the optional target components, so we
// manually initialize it here.
#[cfg(have_component_pnacl)]
fn init() {

This comment has been minimized.

Sign in to view
Copy link
@alexcrichton

alexcrichton Dec 16, 2015

Member

Could this be init_pnacl b/c it's pnacl specific?
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Dec 16, 2015

just one small nit but otherwise r=me

@DiamondLovesYou DiamondLovesYou force-pushed the DiamondLovesYou:pnacl-target branch from f179350 to aa9e66e Dec 17, 2015

@DiamondLovesYou

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

DiamondLovesYou commented Dec 17, 2015

Done.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Dec 17, 2015

@bors: r+ aa9e66e
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 19, 2015

⌛️ Testing commit aa9e66e with merge c5f73c5...

bors added a commit that referenced this pull request Dec 19, 2015

@bors
Auto merge of #30401 - DiamondLovesYou:pnacl-target, r=alexcrichton 
r? @alexcrichton
c5f73c5
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 19, 2015

💔 Test failed - auto-win-msvc-64-opt
@DiamondLovesYou
Add PNaCl target info to the makefile target cfgs and initialize the … 
…PNaCl target

machine if available.
Loading status checks…
0442be8

@DiamondLovesYou DiamondLovesYou force-pushed the DiamondLovesYou:pnacl-target branch from aa9e66e to 0442be8 Dec 19, 2015

@DiamondLovesYou

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

DiamondLovesYou commented Dec 19, 2015

Fixed.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Dec 19, 2015

@bors: r+ 0442be8
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 19, 2015

⌛️ Testing commit 0442be8 with merge cef0d0f...

bors added a commit that referenced this pull request Dec 19, 2015

@bors
Auto merge of #30401 - DiamondLovesYou:pnacl-target, r=alexcrichton 
r? @alexcrichton
cef0d0f
@bors

@bors bors merged commit 0442be8 into rust-lang:master Dec 19, 2015
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.