Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd std::panic::propagate #30557
Conversation
rust-highfive
assigned
alexcrichton
Dec 25, 2015
This comment has been minimized.
This comment has been minimized.
|
Should this be attached to recover's tracking issue or have its own? |
durka
reviewed
Dec 26, 2015
| @@ -172,7 +172,7 @@ pub fn panicking() -> bool { | |||
| #[inline(never)] | |||
| #[no_mangle] | |||
| #[allow(private_no_mangle_fns)] | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
sfackler
Dec 26, 2015
Author
Member
Possibly - not sure how deeply that lint looks. This function is now public within its module, but not public outside of the crate.
This comment has been minimized.
This comment has been minimized.
durka
Dec 26, 2015
Contributor
You're right, still required: http://is.gd/Z4qyRE
On Fri, Dec 25, 2015 at 8:37 PM, Steven Fackler notifications@github.com
wrote:
In src/libstd/sys/common/unwind/mod.rs
#30557 (comment):@@ -172,7 +172,7 @@ pub fn panicking() -> bool {
#[inline(never)]
#[no_mangle]
#[allow(private_no_mangle_fns)]Possibly - not sure how deeply that lint looks. This function is now
public within its module, but not public outside of the crate.—
Reply to this email directly or view it on GitHub
https://github.com/rust-lang/rust/pull/30557/files#r48444144.
brson
added
I-nominated
T-libs
labels
Dec 29, 2015
This comment has been minimized.
This comment has been minimized.
|
cc @rust-lang/libs |
huonw
reviewed
Dec 30, 2015
| /// panic::propagate(err); | ||
| /// } | ||
| /// ``` | ||
| #[unstable(feature = "panic_propagate", reason = "awaiting feedback", issue = "0")] |
This comment has been minimized.
This comment has been minimized.
sfackler
force-pushed the
sfackler:panic-propagate
branch
from
23d5903
to
022c9c7
Jan 7, 2016
This comment has been minimized.
This comment has been minimized.
|
@bors r=aturon We discussed this during libs triage today and are okay with it. |
This comment has been minimized.
This comment has been minimized.
|
|
sfackler commentedDec 25, 2015
See rust-lang/rfcs#1413.
r? @alexcrichton