Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add std::panic::propagate #30557

Merged
merged 1 commit into from Jan 7, 2016

Conversation

Projects
None yet
7 participants
@sfackler
Copy link
Member

sfackler commented Dec 25, 2015

@sfackler

This comment has been minimized.

Copy link
Member Author

sfackler commented Dec 25, 2015

Should this be attached to recover's tracking issue or have its own?

@@ -172,7 +172,7 @@ pub fn panicking() -> bool {
#[inline(never)]
#[no_mangle]
#[allow(private_no_mangle_fns)]

This comment has been minimized.

@durka

durka Dec 26, 2015

Contributor

presumably can remove this allow if the fn is becoming public?

This comment has been minimized.

@sfackler

sfackler Dec 26, 2015

Author Member

Possibly - not sure how deeply that lint looks. This function is now public within its module, but not public outside of the crate.

This comment has been minimized.

@durka

durka Dec 26, 2015

Contributor

You're right, still required: http://is.gd/Z4qyRE

On Fri, Dec 25, 2015 at 8:37 PM, Steven Fackler notifications@github.com
wrote:

In src/libstd/sys/common/unwind/mod.rs
#30557 (comment):

@@ -172,7 +172,7 @@ pub fn panicking() -> bool {
#[inline(never)]
#[no_mangle]
#[allow(private_no_mangle_fns)]

Possibly - not sure how deeply that lint looks. This function is now
public within its module, but not public outside of the crate.


Reply to this email directly or view it on GitHub
https://github.com/rust-lang/rust/pull/30557/files#r48444144.

@brson

This comment has been minimized.

Copy link
Contributor

brson commented Dec 29, 2015

cc @rust-lang/libs

/// panic::propagate(err);
/// }
/// ```
#[unstable(feature = "panic_propagate", reason = "awaiting feedback", issue = "0")]

This comment has been minimized.

@huonw

huonw Dec 30, 2015

Member

This should have an actual issue before it lands.

@sfackler sfackler force-pushed the sfackler:panic-propagate branch from 23d5903 to 022c9c7 Jan 7, 2016

@sfackler

This comment has been minimized.

Copy link
Member Author

sfackler commented Jan 7, 2016

@bors r=aturon

We discussed this during libs triage today and are okay with it.

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 7, 2016

📌 Commit 022c9c7 has been approved by aturon

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 7, 2016

⌛️ Testing commit 022c9c7 with merge 3ed6e9e...

@bors bors merged commit 022c9c7 into rust-lang:master Jan 7, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
homu Test successful
Details

@aturon aturon removed the I-nominated label Jan 8, 2016

@sfackler sfackler deleted the sfackler:panic-propagate branch Nov 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.