Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for "malformed macro lhs" and change back span_bug to span_fatal #30708

Merged
merged 1 commit into from Jan 5, 2016

Conversation

Reviewers
No reviews
Assignees

@brson brson

Labels
beta-accepted
Projects
None yet
Milestone
No milestone
7 participants
@GuillaumeGomez @rust-highfive @sanxiyn @bors @brson @alexcrichton @nikomatsakis
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Jan 4, 2016

Part of #30669

@rust-highfive rust-highfive assigned brson Jan 4, 2016

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Jan 4, 2016

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:malformed_macro branch from f1b469a to 6e68cdf Jan 4, 2016

@sanxiyn

This comment has been minimized.

Sign in to view
Copy link
Member

sanxiyn commented Jan 5, 2016

The intention in #29828 was that macro validity is checked in compile, so invalid macro never gets to generic_extension. This also has an advantage of providing better span. That's why span_bug was used.

Alas, it seems I missed some cases and caused regression. I think this is a good fix in the meantime.
@sanxiyn

This comment has been minimized.

Sign in to view
Copy link
Member

sanxiyn commented Jan 5, 2016

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jan 5, 2016

📌 Commit 6e68cdf has been approved by sanxiyn
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jan 5, 2016

⌛️ Testing commit 6e68cdf with merge dbacacd...

bors added a commit that referenced this pull request Jan 5, 2016

@bors
Auto merge of #30708 - GuillaumeGomez:malformed_macro, r=sanxiyn 
Part of #30669
dbacacd
@bors

@bors bors merged commit 6e68cdf into rust-lang:master Jan 5, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:malformed_macro branch Jan 5, 2016

@brson brson added the beta-nominated label Jan 8, 2016

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Jan 8, 2016

Backport to fix #30669

@nikomatsakis nikomatsakis added the beta-accepted label Jan 12, 2016

@brson brson referenced this pull request Jan 12, 2016

Merged

[beta] Add test for "malformed macro lhs" and change back span_bug to span_f… #30853

@alexcrichton alexcrichton removed the beta-nominated label Jan 12, 2016

@nikomatsakis nikomatsakis referenced this pull request Feb 4, 2016

Closed

Bad syntax in macro_rules! macro definition causes an ICE in beta and nightly, but not stable #30669

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.