Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFix a breaking change in #30523 #30733
Conversation
rust-highfive
assigned
nikomatsakis
Jan 6, 2016
This comment has been minimized.
This comment has been minimized.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
|
Note, this was discovered in #30713. |
solson
referenced this pull request
Jan 6, 2016
Closed
Type inference(?) regression, rand fails to build on nightly 2016-01-04 #30713
This comment has been minimized.
This comment has been minimized.
|
@bors r+ p=1 |
This comment has been minimized.
This comment has been minimized.
|
|
bors
added a commit
that referenced
this pull request
Jan 6, 2016
bors
added a commit
that referenced
this pull request
Jan 6, 2016
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
@bors retry |
This comment has been minimized.
This comment has been minimized.
|
It would be nice to add test which failed with the new version, no? |
nox
referenced this pull request
Jan 6, 2016
Merged
Fix prototypes of interface objects (fixes #2665) #8954
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Jan 6, 2016
This comment has been minimized.
This comment has been minimized.
bors
merged commit 14e1e2a
into
rust-lang:master
Jan 6, 2016
briansmith
referenced this pull request
Jan 6, 2016
Closed
Re-enable build on Rust Nightly on Travis CI. #75
This comment has been minimized.
This comment has been minimized.
|
It would be good to have a test case, I agree. |
mitchmindtree
referenced this pull request
Jan 9, 2016
Merged
Scrolling refactoring and Bug fixes. Add `Axis` enum arg to `Edge::Position` in graph. #662
ubsan
deleted the
ubsan:wrapping_op_assign
branch
Sep 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ubsan commentedJan 6, 2016
Fix a breaking change in #30523
While this does fix a breaking change, it is also, technically, a
[breaking-change] to go back to our original way