Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a breaking change in #30523 #30733

Merged
merged 1 commit into from Jan 6, 2016

Conversation

Projects
None yet
9 participants
@ubsan
Copy link
Contributor

ubsan commented Jan 6, 2016

Fix a breaking change in #30523

While this does fix a breaking change, it is also, technically, a
[breaking-change] to go back to our original way

Fix a breaking change in #30523
While this does fix a breaking change, it is also, technically, a
[breaking-change] to go back to our original way
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 6, 2016

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@solson

This comment has been minimized.

Copy link
Member

solson commented Jan 6, 2016

Note, this was discovered in #30713.

@eddyb

This comment has been minimized.

Copy link
Member

eddyb commented Jan 6, 2016

@bors r+ p=1

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 6, 2016

📌 Commit 14e1e2a has been approved by eddyb

bors added a commit that referenced this pull request Jan 6, 2016

Auto merge of #30733 - ubsan:wrapping_op_assign, r=eddyb
While this does fix a breaking change, it is also, technically, a
[breaking-change] to go back to our original way

bors added a commit that referenced this pull request Jan 6, 2016

Auto merge of #30733 - ubsan:wrapping_op_assign, r=eddyb
While this does fix a breaking change, it is also, technically, a
[breaking-change] to go back to our original way
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 6, 2016

⌛️ Testing commit 14e1e2a with merge e5817d0...

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 6, 2016

💔 Test failed - auto-linux-32-opt

@SimonSapin

This comment has been minimized.

Copy link
Contributor

SimonSapin commented Jan 6, 2016

command timed out: 1200 seconds without output running ['make', 'check'], attempting to kill
@pnkfelix

This comment has been minimized.

Copy link
Member

pnkfelix commented Jan 6, 2016

@bors retry

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jan 6, 2016

It would be nice to add test which failed with the new version, no?

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 6, 2016

⌛️ Testing commit 14e1e2a with merge 21b025f...

bors added a commit that referenced this pull request Jan 6, 2016

Auto merge of #30733 - ubsan:wrapping_op_assign, r=eddyb
Fix a breaking change in #30523

While this does fix a breaking change, it is also, technically, a
[breaking-change] to go back to our original way

@bors bors merged commit 14e1e2a into rust-lang:master Jan 6, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@brson brson referenced this pull request Jan 7, 2016

Closed

Make rand compile with nightly #93

@nikomatsakis

This comment has been minimized.

Copy link
Contributor

nikomatsakis commented Jan 7, 2016

It would be good to have a test case, I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.