Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.7 release notes #31099

Merged
merged 2 commits into from Jan 30, 2016

Conversation

Projects
None yet
8 participants
@brson
Copy link
Contributor

brson commented Jan 22, 2016

No description provided.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 22, 2016

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Jan 22, 2016

Please review @rust-lang/libs @rust-lang/lang @rust-lang/compiler

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Jan 22, 2016

I'm not mentioning new unstable features like #[deprecated] or type ascription.

@steveklabnik

This comment has been minimized.

Copy link
Member

steveklabnik commented Jan 22, 2016

Big +1 to doing this overall.

On Jan 21, 2016, 19:06 -0500, Brian Andersonnotifications@github.com, wrote:

I'm not mentioning new unstable features like#[deprecated]or type ascription.


Reply to this email directly orview it on GitHub(#31099 (comment)).

RELEASES.md Outdated
[`Vec::as_mut_slice`],
[`String::as_str`],
[`String::as_mut_str`],
`<[T]>::`[`clone_from_slice`],

This comment has been minimized.

@bluss

bluss Jan 22, 2016

Contributor

Is this a good place for a note about new behavior in clone_from_slice? It should say that clone_from_slice now requires the two slices to be the same length (and panics otherwise).

@@ -1,3 +1,353 @@
Version 1.7.0 (2016-03-03)

This comment has been minimized.

@ollie27

ollie27 Jan 22, 2016

Contributor

Might be a good idea to make it more obvious this hasn't been released yet and that this is technically a draft?

This comment has been minimized.

@brson

brson Jan 29, 2016

Author Contributor

This is a good idea, but I think I won't do it. It would require patching both the beta and master branches later.

[`u32::overflowing_neg`],
[`u32::overflowing_shl`],
[`u32::overflowing_shr`],
checked, saturated, and overflowing operations for other primitive types,

This comment has been minimized.

@ollie27

ollie27 Jan 22, 2016

Contributor

missing u32::checked_neg and u32::checked_shr

RELEASES.md Outdated
[`CString::into_bytes`],
[`CString::into_bytes_with_nul`],
`From<CString> for Vec<u8>`,
`From<CString> for Vec<u8>`,

This comment has been minimized.

@ollie27

ollie27 Jan 22, 2016

Contributor

this line is a duplicate

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Jan 22, 2016

r=me once you feel this is good to go

RELEASES.md Outdated
[`collections::hash_set::HashSet::drain`],
[`collections::binary_heap::Drain`],
[`collections::binary_heap::BinaryHeap::drain`],
[`Vec::extend_from_slice`] (renamed from `push_all`),

This comment has been minimized.

@upsuper

upsuper Jan 23, 2016

Contributor

Need a [] after the ] here.

@brson brson force-pushed the brson:relnotes branch from 559847b to 6dbff05 Jan 29, 2016

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Jan 29, 2016

@bors r=alexcrichton

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 29, 2016

📌 Commit 6dbff05 has been approved by alexcrichton

[`i32::overflowing_shl`],
[`i32::overflowing_shr`],
[`u32::checked_rem`],
[`u32::checked_neg`],

This comment has been minimized.

@ollie27

ollie27 Jan 29, 2016

Contributor

this is missing a url

[`u32::checked_rem`],
[`u32::checked_neg`],
[`u32::checked_shl`],
[`u32::checked_shl`],

This comment has been minimized.

@ollie27

ollie27 Jan 29, 2016

Contributor

this should be checked_shr

bors added a commit that referenced this pull request Jan 29, 2016

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 29, 2016

⌛️ Testing commit 6dbff05 with merge 24cd6a3...

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 29, 2016

⛄️ The build was interrupted to prioritize another pull request.

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Jan 29, 2016

@bors: rollup

Sorry I interrupted to see if I can get the LLVM upgrade to land or otherwise the bots are just gonna keep oscillating back and forth between various versions of LLVM. It may not work out though...

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 30, 2016

⌛️ Testing commit 6dbff05 with merge 43ee048...

bors added a commit that referenced this pull request Jan 30, 2016

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 30, 2016

💔 Test failed - auto-linux-cross-opt

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Jan 30, 2016

@bors: retry

On Fri, Jan 29, 2016 at 9:23 PM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-linux-cross-opt
http://buildbot.rust-lang.org/builders/auto-linux-cross-opt/builds/1070


Reply to this email directly or view it on GitHub
#31099 (comment).

Manishearth added a commit to Manishearth/rust that referenced this pull request Jan 30, 2016

bors added a commit that referenced this pull request Jan 30, 2016

@bors bors merged commit 6dbff05 into rust-lang:master Jan 30, 2016

1 of 2 checks passed

homu Test failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@brson brson added the beta-accepted label Feb 26, 2016

@brson brson referenced this pull request Feb 26, 2016

Merged

Beta next #31917

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.