Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upimplement RFC amendment 1462 (add `[` to FOLLOW(ty)) #31152
Conversation
rust-highfive
assigned
pnkfelix
Jan 23, 2016
durka
force-pushed the
durka:ty-follow-bracket
branch
2 times, most recently
from
29f27fc
to
84560bb
Jan 23, 2016
durka
added some commits
Jan 23, 2016
durka
force-pushed the
durka:ty-follow-bracket
branch
from
84560bb
to
e1e0de8
Jan 23, 2016
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Jan 23, 2016
This comment has been minimized.
This comment has been minimized.
pnkfelix
added
the
beta-nominated
label
Jan 23, 2016
This comment has been minimized.
This comment has been minimized.
|
@pnkfelix so it is correct to modify FOLLOW(path) as well? I wasn't clear on that from the RFC. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
(man that is embarrassing, given that its pretty explciitly pointed out...) |
This comment has been minimized.
This comment has been minimized.
|
( the RFC as written does says FOLLOW(path) = FOLLOW(ty); I need to double check whether that still makes sense in this context. it probably does, though, to be honest; I just need to double-check about the ramifications...) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Actually thinking on it further, I can't see how it could be wrong to put |
This comment has been minimized.
This comment has been minimized.
|
@bors r+ |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
@bors r+ force |
This comment has been minimized.
This comment has been minimized.
|
|
pnkfelix
closed this
Jan 25, 2016
pnkfelix
reopened this
Jan 25, 2016
This comment has been minimized.
This comment has been minimized.
pnkfelix
referenced this pull request
Jan 25, 2016
Open
Feature Request: When build interrupted to prioritize another PR, provide link to the prioritized PR #128
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jan 26, 2016
bors
added a commit
that referenced
this pull request
Jan 26, 2016
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Jan 26, 2016
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jan 26, 2016
This comment has been minimized.
This comment has been minimized.
|
|
bors
added a commit
that referenced
this pull request
Jan 26, 2016
bors
merged commit e1e0de8
into
rust-lang:master
Jan 26, 2016
This comment has been minimized.
This comment has been minimized.
|
urgh, I forgot to update the Book. |
durka commentedJan 23, 2016
cc #31135 rust-lang/rfcs#1462 #30923 @retep998
r? @pnkfelix