Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement RFC amendment 1462 (add `[` to FOLLOW(ty)) #31152

Merged
merged 2 commits into from Jan 26, 2016

Conversation

Projects
None yet
5 participants
@durka
Copy link
Contributor

durka commented Jan 23, 2016

@durka durka force-pushed the durka:ty-follow-bracket branch 2 times, most recently from 29f27fc to 84560bb Jan 23, 2016

durka added some commits Jan 23, 2016

add `[` to FOLLOW(ty) and FOLLOW(path)
Following RFC 1462 (amending 550). Closes #31135.

@durka durka force-pushed the durka:ty-follow-bracket branch from 84560bb to e1e0de8 Jan 23, 2016

@pnkfelix

This comment has been minimized.

Copy link
Member

pnkfelix commented Jan 23, 2016

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 23, 2016

⌛️ Testing commit e1e0de8 with merge d5fcdcc...

@durka

This comment has been minimized.

Copy link
Contributor Author

durka commented Jan 23, 2016

@pnkfelix so it is correct to modify FOLLOW(path) as well? I wasn't clear on that from the RFC.

@pnkfelix

This comment has been minimized.

Copy link
Member

pnkfelix commented Jan 24, 2016

@durka oh wait, I overlooked that.

@bors r-

@pnkfelix

This comment has been minimized.

Copy link
Member

pnkfelix commented Jan 24, 2016

(man that is embarrassing, given that its pretty explciitly pointed out...)

@pnkfelix

This comment has been minimized.

Copy link
Member

pnkfelix commented Jan 24, 2016

( the RFC as written does says FOLLOW(path) = FOLLOW(ty); I need to double check whether that still makes sense in this context. it probably does, though, to be honest; I just need to double-check about the ramifications...)

@pnkfelix

This comment has been minimized.

Copy link
Member

pnkfelix commented Jan 24, 2016

Actually thinking on it further, I can't see how it could be wrong to put [ into FOLLOW of path. We aren't going to add it to the grammar for path expressions. (Especially since it already has a role in expr grammar)

@pnkfelix

This comment has been minimized.

Copy link
Member

pnkfelix commented Jan 24, 2016

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 24, 2016

📌 Commit e1e0de8 has been approved by pnkfelix

@pnkfelix

This comment has been minimized.

Copy link
Member

pnkfelix commented Jan 25, 2016

@bors r+ force

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 25, 2016

📌 Commit e1e0de8 has been approved by pnkfelix

@pnkfelix pnkfelix closed this Jan 25, 2016

@pnkfelix pnkfelix reopened this Jan 25, 2016

@pnkfelix

This comment has been minimized.

Copy link
Member

pnkfelix commented Jan 25, 2016

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 26, 2016

⌛️ Testing commit e1e0de8 with merge 4086ba0...

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 26, 2016

⛄️ The build was interrupted to prioritize another pull request.

bors added a commit that referenced this pull request Jan 26, 2016

@bors bors merged commit e1e0de8 into rust-lang:master Jan 26, 2016

1 of 2 checks passed

homu :snowman: The build was interrupted to prioritize another pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@durka

This comment has been minimized.

Copy link
Contributor Author

durka commented Jan 27, 2016

urgh, I forgot to update the Book.

bors added a commit that referenced this pull request Jan 28, 2016

Auto merge of #31240 - durka:follow-set-docs, r=pnkfelix
Missed as part of #31152, but the list had other mistakes as well.

r? @pnkfelix

@pnkfelix pnkfelix added the T-compiler label Feb 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.