Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trans: Inform LLVM we want CodeView on MSVC #31319

Merged
merged 1 commit into from Feb 3, 2016

Conversation

Reviewers
No reviews
Assignees

@arielb1 arielb1

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@alexcrichton @rust-highfive @michaelwoerister @bors @arielb1
@alexcrichton
Copy link
Member

alexcrichton commented Jan 31, 2016

This mirrors the behavior of clang-cl.exe by adding a CodeView global
variable when emitting debug information. This should in turn help stack traces
that are generated when code is compiled with debuginfo enabled.

Closes #28133
@alexcrichton
trans: Inform LLVM we want CodeView on MSVC 
This mirrors the behavior of `clang-cl.exe` by adding a `CodeView` global
variable when emitting debug information. This should in turn help stack traces
that are generated when code is compiled with debuginfo enabled.

Closes #28133
Loading status checks…
8b7d0c0

@rust-highfive rust-highfive assigned arielb1 Jan 31, 2016

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Jan 31, 2016

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Jan 31, 2016

cc @michaelwoerister

@alexcrichton alexcrichton referenced this pull request Jan 31, 2016

Closed

std: Move pc-windows-gnu to SEH-based unwinding #31313

@michaelwoerister

This comment has been minimized.

Sign in to view
Copy link
Contributor

michaelwoerister commented Feb 1, 2016

@bors: r+
Thanks, Alex!
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Feb 1, 2016

📌 Commit 8b7d0c0 has been approved by michaelwoerister
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Feb 3, 2016

⌛️ Testing commit 8b7d0c0 with merge 50df6b9...

bors added a commit that referenced this pull request Feb 3, 2016

@bors
Auto merge of #31319 - alexcrichton:msvc-backtraces, r=michaelwoerister 
This mirrors the behavior of `clang-cl.exe` by adding a `CodeView` global
variable when emitting debug information. This should in turn help stack traces
that are generated when code is compiled with debuginfo enabled.

Closes #28133
50df6b9
@bors

@bors bors merged commit 8b7d0c0 into rust-lang:master Feb 3, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@alexcrichton alexcrichton deleted the alexcrichton:msvc-backtraces branch Feb 8, 2016

@alexcrichton alexcrichton referenced this pull request Apr 26, 2016

Closed

x86_64-pc-windows-msvc when building with debug info: error LNK2017: 'ADDR32' relocation to '.debug_str' invalid without /LARGEADDRESSAWARE:NO #29413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.