Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upResolve: stop letting items shadow reexported glob imports #31376
Conversation
rust-highfive
assigned
nrc
Feb 3, 2016
jseyfried
force-pushed the
jseyfried:disallow_shadowing
branch
2 times, most recently
from
ae640ef
to
a118b6a
Feb 3, 2016
nrc
added
the
S-waiting-on-crater
label
Feb 3, 2016
This comment has been minimized.
This comment has been minimized.
nrc
added
I-nominated
T-lang
labels
Feb 3, 2016
jseyfried
force-pushed the
jseyfried:disallow_shadowing
branch
from
a118b6a
to
1c9446f
Feb 3, 2016
This comment has been minimized.
This comment has been minimized.
|
Per my other comment here a crater run wouldn't notice breakages to projects that glob import winapi. |
This comment has been minimized.
This comment has been minimized.
|
Yeah, the breakage looks bad (still would be interested to see crater results). |
This comment has been minimized.
This comment has been minimized.
|
|
jseyfried
force-pushed the
jseyfried:disallow_shadowing
branch
3 times, most recently
from
03d9c78
to
1ae0233
Feb 11, 2016
This comment has been minimized.
This comment has been minimized.
|
rebased |
This comment has been minimized.
This comment has been minimized.
|
Since we decided not to "fix" the current behavior, I believe this PR should be closed. Correct me if I am mistaken. |
nikomatsakis
closed this
Feb 12, 2016
jseyfried
deleted the
jseyfried:disallow_shadowing
branch
Mar 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jseyfried commentedFeb 3, 2016
This PR stops non-import items from shadowing glob-imported re-exports (fixes #31337) and fixes the fallout in the standard libraries and tests.
Previously, it was possible to shadow a glob-imported re-export, so this a [breaking-chage]. For example,
The breakage can be fixed by renaming the non-import item or by using single imports in place of the glob import.
r? @nrc