Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRevert deprecation of IpAddr, stabilizing for 1.7 #31438
Conversation
rust-highfive
assigned
alexcrichton
Feb 6, 2016
aturon
force-pushed the
aturon:stab-ip-addr
branch
from
5efab7b
to
2da8b06
Feb 6, 2016
This was referenced Feb 6, 2016
This comment has been minimized.
This comment has been minimized.
|
r=me, but looks like the build failure on travis is legit (needs a stability attribute for the fields of the enum variants) |
alexcrichton
added
beta-nominated
relnotes
labels
Feb 6, 2016
aturon
force-pushed the
aturon:stab-ip-addr
branch
from
2da8b06
to
2067c57
Feb 9, 2016
This comment has been minimized.
This comment has been minimized.
|
@bors: r=alexcrichton |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Feb 10, 2016
This comment has been minimized.
This comment has been minimized.
bors
merged commit 2067c57
into
rust-lang:master
Feb 10, 2016
alexcrichton
added
the
T-libs
label
Feb 10, 2016
This comment has been minimized.
This comment has been minimized.
|
Accepting for a beta backport (discussed at libs triage today) |
alexcrichton
added
the
beta-accepted
label
Feb 11, 2016
alexcrichton
referenced this pull request
Feb 11, 2016
Merged
Backport one last PR for beta 3 #31552
brson
removed
the
beta-nominated
label
Feb 11, 2016
SimonSapin
referenced this pull request
Feb 11, 2016
Closed
Tracking issue for DNS in std::net #27705
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
aturon commentedFeb 6, 2016
After considerable pushback, it's clear that there is a community consensus around providing
IpAddrin the standard library, together with other APIs using it.This commit reverts from deprecated status directly to stable. The deprecation landed in 1.6, which has already been released, so the stabilization is marked for 1.7 (currently in beta; will require a backport).
r? @alexcrichton