Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFix half of emscripten's failing tests #31532
Conversation
rust-highfive
assigned
brson
Feb 10, 2016
This comment has been minimized.
This comment has been minimized.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
oli-obk
reviewed
Feb 10, 2016
| // For targets like MUSL or Emscripten, however, there is no support for | ||
| // dynamic libraries so we just go back to building a normal library. Note, | ||
| // however, that for MUSL if the library is built with `force_host` then | ||
| // it's ok to be a dylib as the host should always support dylibs. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tomaka
Feb 10, 2016
Author
Contributor
The comment says if the library is built with force_host then it's ok to be a dylib as the host should always support dylibs, but emscripten doesn't support dynamic libraries at all (the "libraries" are just hidden javascript files).
This comment has been minimized.
This comment has been minimized.
oli-obk
Feb 10, 2016
Contributor
yes, but the host can never be emscripten, right? That would mean we'd have a rustc that runs on emscripten.
I think force_host is just for rustc's unit tests when compiling a compiler plugin.
This comment has been minimized.
This comment has been minimized.
tomaka
Feb 10, 2016
Author
Contributor
That would mean we'd have a rustc that runs on emscripten.
Well, why not?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
tomaka commentedFeb 10, 2016
Before this PR:
After:
r? @brson