Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustdoc: Omit src-links for items from extern macros #31614

Merged
merged 1 commit into from Feb 14, 2016

Conversation

Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mitaa @alexcrichton @bors
@mitaa
Copy link
Contributor

mitaa commented Feb 12, 2016

fixes #26606

r? @alexcrichton

@rust-highfive rust-highfive assigned alexcrichton Feb 12, 2016

@mitaa
Omit src-links for items from extern macros 
If the span of a local item points into an external macro
its source-file will be bogus.
Loading status checks…
a31d633
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Feb 12, 2016

looks good to me, thanks! I think tidy has a legit complaint here, though

@mitaa mitaa force-pushed the mitaa:rdoc_locitem_extmac branch from ec42cce to a31d633 Feb 12, 2016

@mitaa

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

mitaa commented Feb 12, 2016

Ah, that's what I get for switching dev-environments around. Should be fine now.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Feb 12, 2016

@bors: r+ a31d633

Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 14, 2016

@Manishearth
Rollup merge of rust-lang#31614 - mitaa:rdoc_locitem_extmac, r=alexcr… 
…ichton

fixes rust-lang#26606

r? @alexcrichton
08a7be2

@Manishearth Manishearth referenced this pull request Feb 14, 2016

Merged

Rollup of 6 pull requests #31646

bors added a commit that referenced this pull request Feb 14, 2016

@bors
Auto merge of #31646 - Manishearth:rollup, r=Manishearth 
- Successful merges: #31551, #31581, #31614, #31626, #31632, #31642
- Failed merges:
77a29e7
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Feb 14, 2016

⌛️ Testing commit a31d633 with merge 083dc5b...

bors added a commit that referenced this pull request Feb 14, 2016

@bors
Auto merge of #31614 - mitaa:rdoc_locitem_extmac, r=alexcrichton 
fixes #26606

r? @alexcrichton
083dc5b
@bors

@bors bors merged commit a31d633 into rust-lang:master Feb 14, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@mitaa mitaa deleted the mitaa:rdoc_locitem_extmac branch Feb 15, 2016

bors added a commit that referenced this pull request Feb 15, 2016

@bors
Auto merge of #31646 - Manishearth:rollup, r=Manishearth 
- Successful merges: #31551, #31581, #31614, #31626, #31632, #31642
- Failed merges:
81c7024

bors added a commit that referenced this pull request Feb 15, 2016

@bors
Auto merge of #31646 - Manishearth:rollup, r=Manishearth 
- Successful merges: #31551, #31581, #31614, #31626, #31632, #31642
- Failed merges:
13675a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.