Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustdoc: Omit src-links for items from extern macros #31614

Merged
merged 1 commit into from Feb 14, 2016

Conversation

@mitaa
Copy link
Contributor

@mitaa mitaa commented Feb 12, 2016

If the span of a local item points into an external macro
its source-file will be bogus.
@alexcrichton
Copy link
Member

@alexcrichton alexcrichton commented Feb 12, 2016

looks good to me, thanks! I think tidy has a legit complaint here, though

@mitaa mitaa force-pushed the mitaa:rdoc_locitem_extmac branch from ec42cce to a31d633 Feb 12, 2016
@mitaa
Copy link
Contributor Author

@mitaa mitaa commented Feb 12, 2016

Ah, that's what I get for switching dev-environments around. Should be fine now.

@alexcrichton
Copy link
Member

@alexcrichton alexcrichton commented Feb 12, 2016

Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 14, 2016
bors added a commit that referenced this pull request Feb 14, 2016
@bors
Copy link
Contributor

@bors bors commented Feb 14, 2016

Testing commit a31d633 with merge 083dc5b...

@bors bors merged commit a31d633 into rust-lang:master Feb 14, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@mitaa mitaa deleted the mitaa:rdoc_locitem_extmac branch Feb 15, 2016
bors added a commit that referenced this pull request Feb 15, 2016
bors added a commit that referenced this pull request Feb 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants