Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new i586 Linux target #31629

Merged
merged 1 commit into from Feb 14, 2016

Conversation

Reviewers
No reviews
Assignees

@arielb1 arielb1

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@MagaTailor @rust-highfive @alexcrichton @arielb1 @bors
@MagaTailor
Copy link

MagaTailor commented Feb 13, 2016

This PR should make it easier to create a baseline x86 compiler as well as make cross-compilation possible through a separate set of rlibs.

Plus, a few Linux distributions (e.g. Debian) have voiced interest in having this target available.

@rust-highfive rust-highfive assigned arielb1 Feb 13, 2016

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Feb 13, 2016

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.
@MagaTailor

This comment has been minimized.

Sign in to view
Copy link
Author

MagaTailor commented Feb 13, 2016

cc @alexcrichton

@ranma42 ranma42 referenced this pull request Feb 13, 2016

Closed

Do not use SIMD instructions on i686 #31110

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Feb 13, 2016

@bors: r+ d3ca33f rollup

Thanks!

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Feb 13, 2016

@steveklabnik
Rollup merge of rust-lang#31629 - petevine:master, r=alexcrichton 
This PR should make it easier to create a baseline x86 compiler  as well as make cross-compilation possible through a separate set of rlibs.

Plus, a few Linux distributions (e.g. Debian) have voiced interest in having this target available.
8895c45

@steveklabnik steveklabnik referenced this pull request Feb 13, 2016

Closed

Rollup of 13 pull requests #31633

bors added a commit that referenced this pull request Feb 13, 2016

@bors
Auto merge of #31633 - steveklabnik:rollup, r=steveklabnik 
- Successful merges: #31535, #31537, #31542, #31559, #31563, #31582, #31584, #31585, #31589, #31607, #31610, #31612, #31629
- Failed merges:
b7d46ee

Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 13, 2016

@Manishearth
Rollup merge of rust-lang#31629 - petevine:master, r=alexcrichton 
This PR should make it easier to create a baseline x86 compiler  as well as make cross-compilation possible through a separate set of rlibs.

Plus, a few Linux distributions (e.g. Debian) have voiced interest in having this target available.
0c5f1a9

@Manishearth Manishearth referenced this pull request Feb 13, 2016

Merged

Rollup of 17 pull requests #31643

bors added a commit that referenced this pull request Feb 13, 2016

@bors
Auto merge of #31643 - Manishearth:rollup, r=Manishearth 
- Successful merges: #31535, #31537, #31542, #31559, #31563, #31582, #31584, #31585, #31589, #31607, #31609, #31610, #31612, #31629, #31635, #31637, #31638
- Failed merges:
284511a

Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 13, 2016

@Manishearth
Rollup merge of rust-lang#31629 - petevine:master, r=alexcrichton 
This PR should make it easier to create a baseline x86 compiler  as well as make cross-compilation possible through a separate set of rlibs.

Plus, a few Linux distributions (e.g. Debian) have voiced interest in having this target available.
6d0d608

bors added a commit that referenced this pull request Feb 13, 2016

@bors
Auto merge of #31643 - Manishearth:rollup, r=Manishearth 
- Successful merges: #31535, #31537, #31542, #31559, #31563, #31582, #31584, #31585, #31589, #31607, #31609, #31610, #31612, #31629, #31635, #31637, #31638
- Failed merges:
fae5162

@bors bors merged commit d3ca33f into rust-lang:master Feb 14, 2016

@llogiq llogiq referenced this pull request Feb 14, 2016

Closed

TWIR 118's COTW + interesting PRs #170

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 4, 2016

@alexcrichton
rustc: Add an i586-pc-windows-msvc target 
Similarly to rust-lang#31629 where an i586-unknown-linux-gnu target was added, there is
sometimes a desire to compile for x86 Windows as well where SSE2 is disabled.
This commit mirrors the i586-unknown-linux-gnu target and simply adds a variant
for Windows as well.

This is motivated by a recent [Gecko bug][ff] where crashes were seen on 32-bit
Windows due to users having CPUs that don't support SSE2 instructions. It was
requested that we could have non-SSE2 builds of the standard library available
so they could continue to use vanilla releases and nightlies.

[ff]: https://bugzilla.mozilla.org/show_bug.cgi?id=1253202
3a2740c

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 4, 2016

@alexcrichton
rustc: Add an i586-pc-windows-msvc target 
Similarly to rust-lang#31629 where an i586-unknown-linux-gnu target was added, there is
sometimes a desire to compile for x86 Windows as well where SSE2 is disabled.
This commit mirrors the i586-unknown-linux-gnu target and simply adds a variant
for Windows as well.

This is motivated by a recent [Gecko bug][ff] where crashes were seen on 32-bit
Windows due to users having CPUs that don't support SSE2 instructions. It was
requested that we could have non-SSE2 builds of the standard library available
so they could continue to use vanilla releases and nightlies.

[ff]: https://bugzilla.mozilla.org/show_bug.cgi?id=1253202
6a2dc50

@alexcrichton alexcrichton referenced this pull request Mar 4, 2016

Merged

rustc: Add an i586-pc-windows-msvc target #32034

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 4, 2016

@alexcrichton
rustc: Add an i586-pc-windows-msvc target 
Similarly to rust-lang#31629 where an i586-unknown-linux-gnu target was added, there is
sometimes a desire to compile for x86 Windows as well where SSE2 is disabled.
This commit mirrors the i586-unknown-linux-gnu target and simply adds a variant
for Windows as well.

This is motivated by a recent [Gecko bug][ff] where crashes were seen on 32-bit
Windows due to users having CPUs that don't support SSE2 instructions. It was
requested that we could have non-SSE2 builds of the standard library available
so they could continue to use vanilla releases and nightlies.

[ff]: https://bugzilla.mozilla.org/show_bug.cgi?id=1253202
4768c47

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 4, 2016

@alexcrichton
rustc: Add an i586-pc-windows-msvc target 
Similarly to rust-lang#31629 where an i586-unknown-linux-gnu target was added, there is
sometimes a desire to compile for x86 Windows as well where SSE2 is disabled.
This commit mirrors the i586-unknown-linux-gnu target and simply adds a variant
for Windows as well.

This is motivated by a recent [Gecko bug][ff] where crashes were seen on 32-bit
Windows due to users having CPUs that don't support SSE2 instructions. It was
requested that we could have non-SSE2 builds of the standard library available
so they could continue to use vanilla releases and nightlies.

[ff]: https://bugzilla.mozilla.org/show_bug.cgi?id=1253202
01a2a7f

bors added a commit that referenced this pull request Mar 11, 2016

@bors
Auto merge of #32034 - alexcrichton:old-x86-msvc, r=aturon 
rustc: Add an i586-pc-windows-msvc target

Similarly to #31629 where an i586-unknown-linux-gnu target was added, there is
sometimes a desire to compile for x86 Windows as well where SSE2 is disabled.
This commit mirrors the i586-unknown-linux-gnu target and simply adds a variant
for Windows as well.

This is motivated by a recent [Gecko bug][ff] where crashes were seen on 32-bit
Windows due to users having CPUs that don't support SSE2 instructions. It was
requested that we could have non-SSE2 builds of the standard library available
so they could continue to use vanilla releases and nightlies.

[ff]: https://bugzilla.mozilla.org/show_bug.cgi?id=1253202
40c85cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.