Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std: Stabilize `into_*` ASCII methods #32020

Merged
merged 1 commit into from Mar 6, 2016

Conversation

Reviewers
No reviews
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@alexcrichton @brson @bors @SimonSapin
@alexcrichton
Copy link
Member

alexcrichton commented Mar 3, 2016

These were intended to land in stable 1.8 but were just waiting for the
implementation PR, so now they're landing. Specifically this PR stabilizes:

  • AsciiExt::into_ascii_uppercase
  • AsciiExt::into_ascii_lowercase
  • AsciiExt for Vec<u8>
  • AsciiExt for String
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Mar 3, 2016

Nominating for beta backport as it's something we intended to do anyway.

@alexcrichton alexcrichton added the beta-nominated label Mar 3, 2016

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Mar 3, 2016

r? @brson

@rust-highfive rust-highfive assigned brson Mar 3, 2016

@alexcrichton
std: Stabilize `into_*` ASCII methods 
These were intended to land in stable 1.8 but were just waiting for the
implementation PR, so now they're landing. Specifically this PR stabilizes:

* `AsciiExt::into_ascii_uppercase`
* `AsciiExt::into_ascii_lowercase`
* `AsciiExt for Vec<u8>`
* `AsciiExt for String`
Loading status checks…
6f9afba
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Mar 4, 2016

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 4, 2016

📌 Commit 48fd993 has been approved by brson

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 4, 2016

@Manishearth
Rollup merge of rust-lang#32020 - alexcrichton:stabilize-into-ascii, … 
…r=brson

These were intended to land in stable 1.8 but were just waiting for the
implementation PR, so now they're landing. Specifically this PR stabilizes:

* `AsciiExt::into_ascii_uppercase`
* `AsciiExt::into_ascii_lowercase`
* `AsciiExt for Vec<u8>`
* `AsciiExt for String`
a8a42c3

@Manishearth Manishearth referenced this pull request Mar 4, 2016

Closed

Rollup of 8 pull requests #32038

bors added a commit that referenced this pull request Mar 4, 2016

@bors
Auto merge of #32038 - Manishearth:rollup, r=Manishearth 
- Successful merges: #32002, #32009, #32017, #32020, #32022, #32027, #32032, #32035
- Failed merges:
c9210d5

bors added a commit that referenced this pull request Mar 4, 2016

@bors
Auto merge of #32038 - Manishearth:rollup, r=Manishearth 
- Successful merges: #32002, #32009, #32017, #32020, #32022, #32027, #32032, #32035
- Failed merges:
db2c76e

bors added a commit that referenced this pull request Mar 4, 2016

@bors
Auto merge of #32020 - alexcrichton:stabilize-into-ascii, r=brson 
These were intended to land in stable 1.8 but were just waiting for the
implementation PR, so now they're landing. Specifically this PR stabilizes:

* `AsciiExt::into_ascii_uppercase`
* `AsciiExt::into_ascii_lowercase`
* `AsciiExt for Vec<u8>`
* `AsciiExt for String`
2a8243e
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 4, 2016

⌛️ Testing commit 48fd993 with merge 2a8243e...
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 4, 2016

💔 Test failed - auto-linux-64-opt

@alexcrichton alexcrichton force-pushed the alexcrichton:stabilize-into-ascii branch from 48fd993 to 6f9afba Mar 4, 2016

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Mar 4, 2016

@bors: r=brson 6f9afba

bors added a commit that referenced this pull request Mar 6, 2016

@bors
Auto merge of #32020 - alexcrichton:stabilize-into-ascii, r=brson 
These were intended to land in stable 1.8 but were just waiting for the
implementation PR, so now they're landing. Specifically this PR stabilizes:

* `AsciiExt::into_ascii_uppercase`
* `AsciiExt::into_ascii_lowercase`
* `AsciiExt for Vec<u8>`
* `AsciiExt for String`
c116ae3
@bors

@bors bors merged commit 6f9afba into rust-lang:master Mar 6, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@bors bors referenced this pull request Mar 6, 2016

Closed

Move into_ascii_{low,upp}ercase (back) to a separate trait. #32076

@SimonSapin

This comment has been minimized.

Sign in to view
Copy link
Contributor

SimonSapin commented Mar 6, 2016

We may need to revert this. See #32074 and #32076.

@alexcrichton alexcrichton deleted the alexcrichton:stabilize-into-ascii branch Mar 11, 2016

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Mar 17, 2016

Removing beta-nominated tag as we're going to revert this.

@alexcrichton alexcrichton removed the beta-nominated label Mar 17, 2016

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 17, 2016

@alexcrichton
std: Revert addition of `into_ascii_*` methods 
The addition of these methods in rust-lang#31335 required adding impls of the trait for
the `String` and `Vec<T>` types. This unfortunately caused a regression (rust-lang#32074)
in type inference for using these methods which the libs team has decided to not
push forward with. These methods were stabilized in rust-lang#32020 which was intended to
get backported to beta, but the backport hasn't happened just yet. This commit
reverts both the addition and stabilization of these methods.

One proposed method of handling this, in rust-lang#32076, was to move the methods to an
extra trait to avoid conflicts with type inference. After some discussion,
however, the libs team concluded that we probably want to reevaluate what we're
doing here, so discussion will continue on the tracking issue, rust-lang#27809.
af65d81

@alexcrichton alexcrichton referenced this pull request Mar 17, 2016

Merged

std: Revert addition of `into_ascii_*` methods #32314

bors added a commit that referenced this pull request Mar 19, 2016

@bors
Auto merge of #32314 - alexcrichton:ascii-fun, r=aturon 
std: Revert addition of `into_ascii_*` methods

The addition of these methods in #31335 required adding impls of the trait for
the `String` and `Vec<T>` types. This unfortunately caused a regression (#32074)
in type inference for using these methods which the libs team has decided to not
push forward with. These methods were stabilized in #32020 which was intended to
get backported to beta, but the backport hasn't happened just yet. This commit
reverts both the addition and stabilization of these methods.

One proposed method of handling this, in #32076, was to move the methods to an
extra trait to avoid conflicts with type inference. After some discussion,
however, the libs team concluded that we probably want to reevaluate what we're
doing here, so discussion will continue on the tracking issue, #27809.

Closes #32074
151be09

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 24, 2016

@alexcrichton
std: Revert addition of `into_ascii_*` methods 
The addition of these methods in rust-lang#31335 required adding impls of the trait for
the `String` and `Vec<T>` types. This unfortunately caused a regression (rust-lang#32074)
in type inference for using these methods which the libs team has decided to not
push forward with. These methods were stabilized in rust-lang#32020 which was intended to
get backported to beta, but the backport hasn't happened just yet. This commit
reverts both the addition and stabilization of these methods.

One proposed method of handling this, in rust-lang#32076, was to move the methods to an
extra trait to avoid conflicts with type inference. After some discussion,
however, the libs team concluded that we probably want to reevaluate what we're
doing here, so discussion will continue on the tracking issue, rust-lang#27809.

Conflicts:
	src/libstd/ascii.rs
4d1140b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.