truncate i8-s to i1-s when loading constants #32032

arielb1 · Mar 3, 2016

eddyb · Mar 3, 2016

eddyb reviewed Mar 3, 2016

View changes

eddyb · Mar 3, 2016

src/librustc_trans/trans/consts.rs

-        llvm::LLVMGetInitializer(v)
+    let d = unsafe { llvm::LLVMGetInitializer(v) };
+    if t.is_bool() {
+        unsafe { llvm::LLVMConstTrunc(d, Type::i1(cx).to_ref()) }


Isn't there something similar in base::load_ty, using LLVMGetInitializer?

This is a variant of load_ty that uses the const llvm functions.

Nevermind, load_ty already handles this correctly via to_arg_ty.

eddyb · Mar 3, 2016

eddyb reviewed Mar 3, 2016

View changes

eddyb · Mar 3, 2016

src/test/run-pass/issue-30891.rs

@@ -0,0 +1,9 @@
+const ERROR_CONST: bool = true;


Does this work without a license header?

Fixing that.

eddyb · Mar 3, 2016

@bors r+

bors · Mar 3, 2016

📌 Commit cf29344 has been approved by eddyb

bors · Mar 4, 2016

⌛️ Testing commit cf29344 with merge c97524b...

bors · Mar 4, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

arielb1 · Mar 4, 2016

nominating for beta since this fixes a regression.

rust-highfive assigned eddyb Mar 3, 2016

truncate i8-s to i1-s when loading constants
Fixes #30891

Loading status checks…

cf29344

arielb1 force-pushed the arielb1:load-const branch from 9ee4b30 to cf29344 Mar 3, 2016

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 4, 2016

Rollup merge of rust-lang#32032 - arielb1:load-const, r=eddyb
Fixes rust-lang#30891 r? @eddyb

714301a

Manishearth referenced this pull request Mar 4, 2016
Closed
Rollup of 8 pull requests #32038

bors added a commit that referenced this pull request Mar 4, 2016

Auto merge of #32038 - Manishearth:rollup, r=Manishearth
- Successful merges: #32002, #32009, #32017, #32020, #32022, #32027, #32032, #32035 - Failed merges:

c9210d5

bors added a commit that referenced this pull request Mar 4, 2016

Auto merge of #32038 - Manishearth:rollup, r=Manishearth
- Successful merges: #32002, #32009, #32017, #32020, #32022, #32027, #32032, #32035 - Failed merges:

db2c76e

bors added a commit that referenced this pull request Mar 4, 2016

Auto merge of #32032 - arielb1:load-const, r=eddyb
Fixes #30891 r? @eddyb

c97524b

bors merged commit cf29344 into rust-lang:master Mar 4, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

arielb1 added beta-nominated T-compiler labels Mar 4, 2016

llogiq referenced this pull request Mar 6, 2016
Closed
TWIR 121's CotW + PRs #176

nikomatsakis added the beta-accepted label Mar 10, 2016

alexcrichton referenced this pull request Mar 16, 2016
Merged
Merge in beta-accepted into beta #32291

brson removed the beta-nominated label Mar 22, 2016

rust-lang/rust

truncate i8-s to i1-s when loading constants #32032

truncate i8-s to i1-s when loading constants #32032

arielb1 commented Mar 3, 2016

rust-highfive assigned eddyb Mar 3, 2016

eddyb reviewed Mar 3, 2016

View changes

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

eddyb reviewed Mar 3, 2016

View changes

This comment has been minimized.

This comment has been minimized.

arielb1 force-pushed the arielb1:load-const branch from `9ee4b30` to `cf29344` Mar 3, 2016

This comment has been minimized.

eddyb commented Mar 3, 2016

This comment has been minimized.

bors commented Mar 3, 2016

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 4, 2016

Manishearth referenced this pull request Mar 4, 2016

Rollup of 8 pull requests #32038

bors added a commit that referenced this pull request Mar 4, 2016

bors added a commit that referenced this pull request Mar 4, 2016

This comment has been minimized.

bors commented Mar 4, 2016

bors added a commit that referenced this pull request Mar 4, 2016

This comment has been minimized.

bors commented Mar 4, 2016

bors merged commit `cf29344` into rust-lang:master Mar 4, 2016
2 checks passed

2 checks passed

arielb1 added beta-nominated T-compiler labels Mar 4, 2016

This comment has been minimized.

arielb1 commented Mar 4, 2016

llogiq referenced this pull request Mar 6, 2016

TWIR 121's CotW + PRs #176

nikomatsakis added the beta-accepted label Mar 10, 2016

alexcrichton referenced this pull request Mar 16, 2016

Merge in beta-accepted into beta #32291

brson removed the beta-nominated label Mar 22, 2016

rust-lang/rust

Join GitHub today

truncate i8-s to i1-s when loading constants #32032

Conversation

arielb1 commented Mar 3, 2016

rust-highfive assigned eddyb Mar 3, 2016

eddyb reviewed Mar 3, 2016 View changes

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

eddyb reviewed Mar 3, 2016 View changes

This comment has been minimized.

This comment has been minimized.

arielb1 force-pushed the arielb1:load-const branch from 9ee4b30 to cf29344 Mar 3, 2016

This comment has been minimized.

eddyb commented Mar 3, 2016

This comment has been minimized.

bors commented Mar 3, 2016

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 4, 2016

Manishearth referenced this pull request Mar 4, 2016

bors added a commit that referenced this pull request Mar 4, 2016

bors added a commit that referenced this pull request Mar 4, 2016

This comment has been minimized.

bors commented Mar 4, 2016

bors added a commit that referenced this pull request Mar 4, 2016

This comment has been minimized.

bors commented Mar 4, 2016

Hide details View details bors merged commit cf29344 into rust-lang:master Mar 4, 2016 2 checks passed

2 checks passed

arielb1 added beta-nominated T-compiler labels Mar 4, 2016

This comment has been minimized.

arielb1 commented Mar 4, 2016

llogiq referenced this pull request Mar 6, 2016

nikomatsakis added the beta-accepted label Mar 10, 2016

alexcrichton referenced this pull request Mar 16, 2016

brson removed the beta-nominated label Mar 22, 2016

eddyb reviewed Mar 3, 2016

View changes

eddyb reviewed Mar 3, 2016

View changes

arielb1 force-pushed the arielb1:load-const branch from `9ee4b30` to `cf29344` Mar 3, 2016

bors merged commit `cf29344` into rust-lang:master Mar 4, 2016
2 checks passed