Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove the check_pat_enum logic #32039
Conversation
rust-highfive
assigned
eddyb
Mar 4, 2016
nagisa
reviewed
Mar 4, 2016
src/test/compile-fail/issue-32004.rs
Outdated
| fn main() { | ||
| match Foo::Baz { | ||
| Foo::Bar => {} | ||
| //~^ ERROR this pattern has 0 fields, but the corresponding |
This comment has been minimized.
This comment has been minimized.
nagisa
Mar 4, 2016
Contributor
Could you expand the expected message to also include “variant” here?
nagisa
reviewed
Mar 4, 2016
src/test/compile-fail/issue-32004.rs
Outdated
|
|
||
| match S { | ||
| S(()) => {} | ||
| //~^ ERROR this pattern has 1 field, but the corresponding |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
arielb1
force-pushed the
arielb1:pat-enum
branch
from
c73bbfe
to
f40d12f
Mar 4, 2016
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I nominate this for beta since this fixes a regression from stable to nightly (now beta) and we recently had a release. |
nagisa
added
the
beta-nominated
label
Mar 4, 2016
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Mar 4, 2016
This comment has been minimized.
This comment has been minimized.
bors
merged commit f40d12f
into
rust-lang:master
Mar 4, 2016
nikomatsakis
added
the
beta-accepted
label
Mar 10, 2016
alexcrichton
referenced this pull request
Mar 16, 2016
Merged
Merge in beta-accepted into beta #32291
brson
removed
the
beta-nominated
label
Mar 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
arielb1 commentedMar 4, 2016
Fixes #32004
r? @eddyb