Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std: Fix tracking issues and clean deprecated APIs #32112

Merged
merged 7 commits into from Mar 13, 2016

Conversation

Reviewers
No reviews
Assignees

@aturon aturon

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@alexcrichton @bors @aturon @sfackler @Manishearth
@alexcrichton
Copy link
Member

alexcrichton commented Mar 8, 2016

This PR fixes up a number of discrepancies found with tracking issues (some closed, some needed new ones, etc), and also cleans out all pre-1.8 deprecated APIs. The big beast here was dealing with std::dynamic_lib, and via many applications of a large hammer it's now out of the standard library.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Mar 8, 2016

r? @aturon

@alexcrichton alexcrichton assigned aturon Mar 8, 2016

@alexcrichton alexcrichton force-pushed the alexcrichton:fix-issues branch 2 times, most recently from 138fbf4 to d481d39 Mar 8, 2016

@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 11, 2016

☔️ The latest upstream changes (presumably #32133) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton alexcrichton force-pushed the alexcrichton:fix-issues branch 2 times, most recently from c802813 to d80fb96 Mar 11, 2016

@aturon

This comment has been minimized.

Sign in to view
Copy link
Member

aturon commented Mar 11, 2016

r=me, very nice.

@alexcrichton alexcrichton force-pushed the alexcrichton:fix-issues branch from d80fb96 to 2c54926 Mar 12, 2016

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Mar 12, 2016

@bors: r=aturon 2c54926
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 12, 2016

☔️ The latest upstream changes (presumably #32200) made this pull request unmergeable. Please resolve the merge conflicts.

alexcrichton added some commits Mar 7, 2016

@alexcrichton
alloc: Add unstable issue for FnBox APIs
3dd8b3e
@alexcrichton
test: Move some test outputs into $(TMPDIR) 
Don't want to pollute the source tree!
9a623f3
@alexcrichton
std: Remove unstable from ReentrantMutex 
This isn't exported so it doesn't need a tag.
1c440bd
@alexcrichton
core: Mark Wrapping impls as stable 
These are all insta-stable anyway, so just properly tag them.
a38bf6e
@alexcrichton
core: Make a new tracking issue for prelude traits 
The referenced issues here were both closed, so hook up a new issue which tracks
specifically the prelude traits being unstable.
aed7dda
@alexcrichton
std: Add a tracking issue for Peekable::is_empty 
The listed tracking issue was hooked up to the wrong location by accident.
083db64

@alexcrichton alexcrichton force-pushed the alexcrichton:fix-issues branch from 2c54926 to 95812ac Mar 12, 2016

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Mar 12, 2016

@bors: r=aturon 95812ac

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 12, 2016

@Manishearth
Rollup merge of rust-lang#32112 - alexcrichton:fix-issues, r=aturon 
std: Fix tracking issues and clean deprecated APIs

This PR fixes up a number of discrepancies found with tracking issues (some closed, some needed new ones, etc), and also cleans out all pre-1.8 deprecated APIs. The big beast here was dealing with `std::dynamic_lib`, and via many applications of a large hammer it's now out of the standard library.
da27332

@Manishearth Manishearth referenced this pull request Mar 12, 2016

Closed

Rollup of 8 pull requests #32209

@sfackler

This comment has been minimized.

Sign in to view
Copy link
Member

sfackler commented Mar 12, 2016

Travis is unhappy: https://travis-ci.org/rust-lang/rust/builds/115483851#L1725

bors added a commit that referenced this pull request Mar 12, 2016

@bors
Auto merge of #32209 - Manishearth:rollup, r=Manishearth 
Rollup of 8 pull requests

- Successful merges: #32112, #32139, #32140, #32141, #32142, #32164, #32179, #32193
- Failed merges: #32182
9dd580b
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 12, 2016

⌛️ Testing commit 95812ac with merge 08d32fa...

bors added a commit that referenced this pull request Mar 12, 2016

@bors
Auto merge of #32112 - alexcrichton:fix-issues, r=aturon 
std: Fix tracking issues and clean deprecated APIs

This PR fixes up a number of discrepancies found with tracking issues (some closed, some needed new ones, etc), and also cleans out all pre-1.8 deprecated APIs. The big beast here was dealing with `std::dynamic_lib`, and via many applications of a large hammer it's now out of the standard library.
08d32fa
@Manishearth

This comment has been minimized.

Sign in to view
Copy link
Member

Manishearth commented Mar 12, 2016 

../src/libstd\sys/unix\net.rs:24:1: 24:31 warning: `pub extern crate` does not work as expected and should not be used. Likely to become an error. Prefer `extern crate` and `pub use`.
../src/libstd\sys/unix\net.rs:24 pub extern crate libc as netc;
                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/libstd\sys/windows\handle.rs:138:48: 138:56 error: unresolved name `c::FALSE` [E0425]
../src/libstd\sys/windows\handle.rs:138             let wait = if wait {c::TRUE} else {c::FALSE};
                                                                                       ^~~~~~~~
../src/libstd\sys/windows\handle.rs:138:48: 138:56 help: run `rustc --explain E0425` to see a detailed explanation
../src/libstd\sys/windows\pipe.rs:143:57: 143:65 error: unresolved name `c::FALSE` [E0425]
../src/libstd\sys/windows\pipe.rs:143             c::WaitForMultipleObjects(2, objs.as_ptr(), c::FALSE, c::INFINITE)
                                                                                              ^~~~~~~~
../src/libstd\sys/windows\pipe.rs:143:57: 143:65 help: run `rustc --explain E0425` to see a detailed explanation
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 12, 2016

⛄️ The build was interrupted to prioritize another pull request.

bors added a commit that referenced this pull request Mar 12, 2016

@bors
Auto merge of #32209 - Manishearth:rollup, r=Manishearth 
Rollup of 8 pull requests

- Successful merges: #32112, #32139, #32140, #32141, #32142, #32164, #32179, #32193
- Failed merges: #32182
c81f9d9
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 12, 2016

⌛️ Testing commit 95812ac with merge 51644a9...

bors added a commit that referenced this pull request Mar 12, 2016

@bors
Auto merge of #32112 - alexcrichton:fix-issues, r=aturon 
std: Fix tracking issues and clean deprecated APIs

This PR fixes up a number of discrepancies found with tracking issues (some closed, some needed new ones, etc), and also cleans out all pre-1.8 deprecated APIs. The big beast here was dealing with `std::dynamic_lib`, and via many applications of a large hammer it's now out of the standard library.
51644a9
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 12, 2016

💔 Test failed - auto-win-msvc-32-opt

bors added a commit that referenced this pull request Mar 12, 2016

@bors
Auto merge of #32209 - Manishearth:rollup, r=Manishearth 
Rollup of 8 pull requests

- Successful merges: #32112, #32139, #32140, #32141, #32142, #32164, #32179, #32193
- Failed merges: #32182
c61d348

bors added a commit that referenced this pull request Mar 12, 2016

@bors
Auto merge of #32209 - Manishearth:rollup, r=Manishearth 
Rollup of 8 pull requests

- Successful merges: #32112, #32139, #32140, #32141, #32142, #32164, #32179, #32193
- Failed merges: #32182
5c59b51

@alexcrichton alexcrichton force-pushed the alexcrichton:fix-issues branch from 95812ac to c2c5092 Mar 12, 2016

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Mar 12, 2016

@bors: r=aturon c2c5092
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 12, 2016

⌛️ Testing commit c2c5092 with merge b5241a8...

bors added a commit that referenced this pull request Mar 12, 2016

@bors
Auto merge of #32112 - alexcrichton:fix-issues, r=aturon 
std: Fix tracking issues and clean deprecated APIs

This PR fixes up a number of discrepancies found with tracking issues (some closed, some needed new ones, etc), and also cleans out all pre-1.8 deprecated APIs. The big beast here was dealing with `std::dynamic_lib`, and via many applications of a large hammer it's now out of the standard library.
b5241a8
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 12, 2016

💔 Test failed - auto-linux-64-x-android-t
@alexcrichton
std: Clean out deprecated APIs 
Removes all unstable and deprecated APIs prior to the 1.8 release. All APIs that
are deprecated in the 1.8 release are sticking around for the rest of this
cycle.

Some notable changes are:

* The `dynamic_lib` module was moved into `rustc_back` as the compiler still
  relies on a few bits and pieces.
* The `DebugTuple` formatter now special-cases an empty struct name with only
  one field to append a trailing comma.
Loading status checks…
b53764c

@alexcrichton alexcrichton force-pushed the alexcrichton:fix-issues branch from c2c5092 to b53764c Mar 12, 2016

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Mar 12, 2016

@bors: r=aturon b53764c
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 12, 2016

⌛️ Testing commit b53764c with merge a2c56de...

bors added a commit that referenced this pull request Mar 12, 2016

@bors
Auto merge of #32112 - alexcrichton:fix-issues, r=aturon 
std: Fix tracking issues and clean deprecated APIs

This PR fixes up a number of discrepancies found with tracking issues (some closed, some needed new ones, etc), and also cleans out all pre-1.8 deprecated APIs. The big beast here was dealing with `std::dynamic_lib`, and via many applications of a large hammer it's now out of the standard library.
a2c56de
@bors

@bors bors merged commit b53764c into rust-lang:master Mar 13, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

This was referenced Mar 13, 2016

Closed
Merged
Closed
Closed

@jfager jfager referenced this pull request Mar 25, 2016

Closed

Tracking issue for DNS in std::net #27705

@alexcrichton alexcrichton deleted the alexcrichton:fix-issues branch Mar 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.