Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not report errors from regionck if other errors were already reported #32164

Merged
merged 2 commits into from Mar 13, 2016

Conversation

Reviewers
No reviews
Assignees

@arielb1 arielb1

Labels
T-compiler beta-accepted
Projects
None yet
Milestone
No milestone
6 participants
@nikomatsakis @eddyb @bors @arielb1 @alexcrichton @brson
@nikomatsakis
Copy link
Contributor

nikomatsakis commented Mar 9, 2016

Do not report errors from regionck if other errors were already reported during the lifetime of this inferencer. Fixes #30580.

r? @arielb1
@nikomatsakis
Do not report errors from regionck if other errors were already 
reported during the lifetime of this inferencer. Fixes #30580.
Loading status checks…
59279b5

@nikomatsakis nikomatsakis assigned arielb1 Mar 9, 2016

@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

nikomatsakis commented Mar 10, 2016

cc @eddyb
@eddyb

This comment has been minimized.

Sign in to view
Copy link
Member

eddyb commented Mar 10, 2016

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 10, 2016

📌 Commit 0ddc17d has been approved by eddyb

@nikomatsakis nikomatsakis added the beta-nominated label Mar 10, 2016

@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

nikomatsakis commented Mar 10, 2016

Nominating for beta. Tiny diff, but these errors seem to have become much more common lately.

@nikomatsakis nikomatsakis added T-compiler beta-accepted labels Mar 10, 2016

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 12, 2016

@Manishearth
Rollup merge of rust-lang#32164 - nikomatsakis:fewer-errors, r=eddyb 
Do not report errors from regionck if other errors were already reported

Do not report errors from regionck if other errors were already reported during the lifetime of this inferencer. Fixes rust-lang#30580.

r? @arielb1
e89fb15

@Manishearth Manishearth referenced this pull request Mar 12, 2016

Closed

Rollup of 8 pull requests #32209

bors added a commit that referenced this pull request Mar 12, 2016

@bors
Auto merge of #32209 - Manishearth:rollup, r=Manishearth 
Rollup of 8 pull requests

- Successful merges: #32112, #32139, #32140, #32141, #32142, #32164, #32179, #32193
- Failed merges: #32182
9dd580b

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 12, 2016

@Manishearth
Rollup merge of rust-lang#32164 - nikomatsakis:fewer-errors, r=eddyb 
Do not report errors from regionck if other errors were already reported

Do not report errors from regionck if other errors were already reported during the lifetime of this inferencer. Fixes rust-lang#30580.

r? @arielb1
51fe4c3

bors added a commit that referenced this pull request Mar 12, 2016

@bors
Auto merge of #32209 - Manishearth:rollup, r=Manishearth 
Rollup of 8 pull requests

- Successful merges: #32112, #32139, #32140, #32141, #32142, #32164, #32179, #32193
- Failed merges: #32182
c81f9d9

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 12, 2016

@Manishearth
Rollup merge of rust-lang#32164 - nikomatsakis:fewer-errors, r=eddyb 
Do not report errors from regionck if other errors were already reported

Do not report errors from regionck if other errors were already reported during the lifetime of this inferencer. Fixes rust-lang#30580.

r? @arielb1
23f042c

bors added a commit that referenced this pull request Mar 12, 2016

@bors
Auto merge of #32209 - Manishearth:rollup, r=Manishearth 
Rollup of 8 pull requests

- Successful merges: #32112, #32139, #32140, #32141, #32142, #32164, #32179, #32193
- Failed merges: #32182
c61d348

bors added a commit that referenced this pull request Mar 12, 2016

@bors
Auto merge of #32209 - Manishearth:rollup, r=Manishearth 
Rollup of 8 pull requests

- Successful merges: #32112, #32139, #32140, #32141, #32142, #32164, #32179, #32193
- Failed merges: #32182
5c59b51
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 13, 2016

⌛️ Testing commit 0ddc17d with merge 4bedc11...

bors added a commit that referenced this pull request Mar 13, 2016

@bors
Auto merge of #32164 - nikomatsakis:fewer-errors, r=eddyb 
Do not report errors from regionck if other errors were already reported

Do not report errors from regionck if other errors were already reported during the lifetime of this inferencer. Fixes #30580.

r? @arielb1
4bedc11
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 13, 2016

💔 Test failed - auto-win-msvc-32-opt
@arielb1

This comment has been minimized.

Sign in to view
Copy link
Contributor

arielb1 commented Mar 13, 2016

@bors retry

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 13, 2016

@Manishearth
Rollup merge of rust-lang#32164 - nikomatsakis:fewer-errors, r=eddyb 
Do not report errors from regionck if other errors were already reported

Do not report errors from regionck if other errors were already reported during the lifetime of this inferencer. Fixes rust-lang#30580.

r? @arielb1
511cb30

@Manishearth Manishearth referenced this pull request Mar 13, 2016

Merged

Rollup of 4 pull requests #32229

bors added a commit that referenced this pull request Mar 13, 2016

@bors
Auto merge of #32229 - Manishearth:rollup, r=Manishearth 
Rollup of 4 pull requests

- Successful merges: #32164, #32179, #32212, #32218
- Failed merges:
1c8b245

@bors bors merged commit 0ddc17d into rust-lang:master Mar 13, 2016
1 of 2 checks passed

1 of 2 checks passed

homu Test failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eddyb

This comment has been minimized.

Sign in to view
Copy link
Member

eddyb commented Mar 13, 2016

@rust-lang/tools We need a snapshot after this to make compiler development bearable, but at the same time, we'll want a snapshot after #32080 to set up the test bot, not sure how long review will take.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Mar 13, 2016

I'll plan on making a new snapshot once #32080 lands and if that takes too long can just go ahead and do it sooner.

@alexcrichton alexcrichton referenced this pull request Mar 16, 2016

Merged

Merge in beta-accepted into beta #32291

@eddyb eddyb referenced this pull request Mar 19, 2016

Merged

Update snapshots to 2016-03-18 (235d774). #32345

bors added a commit that referenced this pull request Mar 20, 2016

@bors
Auto merge of #32345 - eddyb:snap-to-orbit, r=alexcrichton 
Update snapshots to 2016-03-18 (235d774).

The new snapshots notably include @nikomatsakis' #32164 fix for the regionck error spew.
Also, `./configure --enable-orbit` *and/or* `make RUSTFLAGS="-Z orbit"` should work now (#32080).
399b522

@brson brson removed the beta-nominated label Mar 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.