Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make warnings of renamed and removed lints themselves lints #32219

Merged
merged 1 commit into from Mar 24, 2016
+68 −30

Conversation

Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
T-compiler
Projects
None yet
Milestone
No milestone
6 participants
@brson @alexcrichton @nikomatsakis @bors @pnkfelix @nrc
@brson
Copy link
Contributor

brson commented Mar 12, 2016

This adds the renamed_and_removed_lints warning, defaulting
to the warning level.

Fixes #31141

@brson brson force-pushed the brson:lints branch from b219e72 to b9a1e6a Mar 12, 2016

@brson brson added the beta-nominated label Mar 12, 2016

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

brson commented Mar 12, 2016

Nominating for beta because this fixes the unsightly raw_pointer_derive warnings that show up in a lot of cargo build output.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Mar 13, 2016

r=me, but the travis failure looks legit:

---- [run-pass] run-pass/ifmt.rs stdout ----

error: compilation failed!
status: exit code: 101
command: x86_64-unknown-linux-gnu/stage2/bin/rustc /home/travis/build/rust-lang/rust/src/test/run-pass/ifmt.rs -L x86_64-unknown-linux-gnu/test/run-pass/ --target=x86_64-unknown-linux-gnu -L x86_64-unknown-linux-gnu/test/run-pass/ifmt.stage2-x86_64-unknown-linux-gnu.run-pass.libaux -C prefer-dynamic -o x86_64-unknown-linux-gnu/test/run-pass/ifmt.stage2-x86_64-unknown-linux-gnu --cfg rtopt -C rpath -O -L x86_64-unknown-linux-gnu/rt
stdout:
------------------------------------------

------------------------------------------
stderr:
------------------------------------------
/home/travis/build/rust-lang/rust/src/test/run-pass/ifmt.rs:15:10: 15:26 error: lint unknown_features has been renamed to unused_features
/home/travis/build/rust-lang/rust/src/test/run-pass/ifmt.rs:15 #![allow(unknown_features)]
                                                                        ^~~~~~~~~~~~~~~~
/home/travis/build/rust-lang/rust/src/test/run-pass/ifmt.rs:13:9: 13:17 note: lint level defined here
/home/travis/build/rust-lang/rust/src/test/run-pass/ifmt.rs:13 #![deny(warnings)]
                                                                       ^~~~~~~~
error: aborting due to previous error

------------------------------------------

thread '[run-pass] run-pass/ifmt.rs' panicked at 'explicit panic', /home/travis/build/rust-lang/rust/src/compiletest/runtest.rs:1651
note: Run with `RUST_BACKTRACE=1` for a backtrace.


failures:
    [run-pass] run-pass/ifmt.rs

@alexcrichton alexcrichton self-assigned this Mar 14, 2016

@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor

nikomatsakis commented Mar 17, 2016

Discussed in @rust-lang/compiler meeting. We are not sure if this is a good candidate for beta uplift or not. It's not fixing a regression per se -- but I guess it will depend on how many such warnings show up. Also, the code is mildly non-trivial (as evidenced by travis failures).
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Mar 18, 2016

FWIW I still see this warning a few times per day due to crates bringing in older versions of winapi or older versions of libc
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

brson commented Mar 18, 2016

Looking into the failure.

@brson brson force-pushed the brson:lints branch from b9a1e6a to bcc291f Mar 18, 2016

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

brson commented Mar 18, 2016

@bors r=alexcrichton
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 18, 2016

📌 Commit bcc291f has been approved by alexcrichton
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 18, 2016

☔️ The latest upstream changes (presumably #32309) made this pull request unmergeable. Please resolve the merge conflicts.
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 20, 2016

🔒 Merge conflict
@brson
Make warnings of renamed and removed lints themselves lints 
This adds the `renamed_and_removed_lints` warning, defaulting
to the warning level.

Fixes #31141
Loading status checks…
addde1f

@brson brson force-pushed the brson:lints branch from bcc291f to addde1f Mar 23, 2016

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

brson commented Mar 23, 2016

@bors r=alexcrichton
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 23, 2016

📌 Commit addde1f has been approved by alexcrichton
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 24, 2016

⌛️ Testing commit addde1f with merge dc1f683...

bors added a commit that referenced this pull request Mar 24, 2016

@bors
Auto merge of #32219 - brson:lints, r=alexcrichton 
Make warnings of renamed and removed lints themselves lints

This adds the `renamed_and_removed_lints` warning, defaulting
to the warning level.

Fixes #31141
dc1f683
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Mar 24, 2016

This passed on all but android but apparently that bot disappeared so merging manually.

@alexcrichton alexcrichton merged commit addde1f into rust-lang:master Mar 24, 2016
1 of 2 checks passed

1 of 2 checks passed

homu Testing commit addde1f with merge dc1f683...
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nrc nrc added the T-compiler label Mar 31, 2016

@pnkfelix

This comment has been minimized.

Sign in to view
Copy link
Member

pnkfelix commented Mar 31, 2016

compiler team discussion concludes that since actively developed (and warning-free) crates should not themselves cause problems downstream, and thus the only problem here is with older version or abandoned crates, combined with fact that such crates will eventually be painless to pull in (once this PR hits stable in <=12 weeks), means that its not crucial to backport this to beta.

@pnkfelix pnkfelix removed the beta-nominated label Mar 31, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.