Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old snapshot CFG_LIBDIR_RELATIVE-ignoring hack. #32262

Closed
wants to merge 1 commit into from

Conversation

Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@eddyb @alexcrichton
@eddyb
Copy link
Member

eddyb commented Mar 15, 2016

Unbreaks the build for distributions which use --libdir=/usr/lib64, resulting in CFG_LIBDIR_RELATIVE=lib64 (fixes #32261).

r? @alexcrichton

@eddyb eddyb added the beta-nominated label Mar 15, 2016

@rust-highfive rust-highfive assigned alexcrichton Mar 15, 2016

mk/main.mk

else

ifeq ($(1),0)
HLIB_RELATIVE$(1)_H_$(3) = lib
else

This comment has been minimized.

Sign in to view
Copy link
@alexcrichton

alexcrichton Mar 15, 2016

Member

I seem to recall these are still required because the stage0 compiler is always configured with --libdir=lib.

This comment has been minimized.

Sign in to view
Copy link
@eddyb

eddyb Mar 15, 2016

Author Member

It seemed to work for @shlomif, though, with the snapshot used by the 1.7.0 release.

This comment has been minimized.

Sign in to view
Copy link
@alexcrichton

alexcrichton Mar 15, 2016

Member

Hm I was unable to reproduce the errors, so I want to dig a little more into what's going on here.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Mar 19, 2016

Closing due to this comment

@alexcrichton alexcrichton closed this Mar 19, 2016

@alexcrichton alexcrichton removed the beta-nominated label Mar 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.