Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustbuild: Migrate tidy checks to Rust #32590

Merged
merged 2 commits into from Apr 13, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@alexcrichton @bors @brson @rkruppe @petrochenkov
@alexcrichton
Copy link
Member

alexcrichton commented Mar 29, 2016

This commit rewrites all of the tidy checks we have, namely:

  • featureck
  • errorck
  • tidy
  • binaries

into Rust under a new tidy tool inside of the src/tools directory. This at
the same time deletes all the corresponding Python tidy checks so we can be sure
to only have one source of truth for all the tidy checks.

cc #31590

@alexcrichton alexcrichton referenced this pull request Mar 29, 2016

Closed

Tracking issue for rustbuild, the alternate build system for rustc #31590

42 of 48 tasks complete
mk/tests.mk Outdated
@$(call E, check: feature sanity)
$(Q) $(CFG_PYTHON) $(S)src/etc/featureck.py $(S)src/

echo "make tidy" is now only available in rustbuild

This comment has been minimized.

Sign in to view
Copy link
@petrochenkov

petrochenkov Mar 29, 2016

Contributor

So, if I use the old build system because testing is not implement in rustbuild yet, I won't be able to run make tidy anymore?

This comment has been minimized.

Sign in to view
Copy link
@alexcrichton

alexcrichton Mar 29, 2016

Author Member

For now, yeah, but if it's an important enough use case the tidy check is a small enough program to be easily compile-able

This comment has been minimized.

Sign in to view
Copy link
@rkruppe

rkruppe Mar 29, 2016

Member

Forget about users, what about the buildbots? This disables tidy checking on Travis, which is unfortunate to say the least. Do we even gate on rustbuild bots yet, or will this allow "untidy" code to merge?

I see that this new tidy has no dependencies other than std so maybe it could still be compiled and run from the Makefiles with very little effort?

If that doesn't work, I would suggest at least making make tidy spit out an error, because this line is easily overlooked in the build log, and I know I will forget that it doesn't work anymore and run make tidy.

This comment has been minimized.

Sign in to view
Copy link
@alexcrichton

alexcrichton Mar 29, 2016

Author Member

Yes we gate on rustbuild, no we won't check in "untidy" code because we're gating.

Yeah it's possible to just delete this rule altogether (to emit an error), but I figured we'd at least leave it here during a small transition period.

This comment has been minimized.

Sign in to view
Copy link
@rkruppe

rkruppe Mar 29, 2016

Member

It's still sad to lose the quick feedback from Travis on trivial tidy issues. Please consider adding something to the effect of rustc src/tools/tidy/main.rs -o whereever/tidy && whereever/tidy.

Yeah just deleting the rule is bad because unexplained breakage, but echo bla bla && false would give both a message and an error. Though this does require adjusting .travis.yml and buildbots right now instead of soon-ish so I understand if you don't want to do that.

This comment has been minimized.

Sign in to view
Copy link
@petrochenkov

petrochenkov Mar 29, 2016

Contributor

So, tidy errors slip through make check by default, Travis doesn't catch them as well because it uses the old build system too, so without extra effort from PR authors tidy errors will be detected only after PR approval by rustbuild buildbots and will need to go through re-approval(s). Seems bad.

This comment has been minimized.

Sign in to view
Copy link
@petrochenkov

petrochenkov Mar 29, 2016

Contributor

It's still sad to lose the quick feedback from Travis on trivial tidy issues. Please consider adding something to the effect of rustc src/tools/tidy/main.rs -o whereever/tidy && whereever/tidy.

And it would be much better if this line is added to the old build system instead of Travis.

This comment has been minimized.

Sign in to view
Copy link
@alexcrichton

alexcrichton Mar 30, 2016

Author Member

Right so I figured no one actually runs make tidy and we don't really care much about it so long as it runs somewhere, and it's trivial to add a builder on Travis if we really want. If it's really wanted that much though then a rule can just be added

This comment has been minimized.

Sign in to view
Copy link
@petrochenkov

petrochenkov Mar 30, 2016

Contributor

Thanks!

@alexcrichton alexcrichton force-pushed the alexcrichton:rustbuild-tidy-checks branch from 54d689f to e873e97 Mar 30, 2016

@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 2, 2016

☔️ The latest upstream changes (presumably #32544) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton alexcrichton force-pushed the alexcrichton:rustbuild-tidy-checks branch 4 times, most recently from db7c693 to e5a2b63 Apr 3, 2016

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Apr 5, 2016

Added a new tidy check which ensure that the dependencies listed in Cargo.toml are in sync with [dependencies]

@alexcrichton alexcrichton force-pushed the alexcrichton:rustbuild-tidy-checks branch 2 times, most recently from 9d32f2e to 71ec190 Apr 7, 2016

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Apr 9, 2016

r=me but please squash the last commit

@alexcrichton alexcrichton force-pushed the alexcrichton:rustbuild-tidy-checks branch from 71ec190 to ae70c39 Apr 9, 2016

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Apr 9, 2016

@bors: r=brson ae70c39
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 9, 2016

⌛️ Testing commit ae70c39 with merge d9a3447...

bors added a commit that referenced this pull request Apr 9, 2016

@bors
Auto merge of #32590 - alexcrichton:rustbuild-tidy-checks, r=brson 
rustbuild: Migrate tidy checks to Rust

This commit rewrites all of the tidy checks we have, namely:

* featureck
* errorck
* tidy
* binaries

into Rust under a new `tidy` tool inside of the `src/tools` directory. This at
the same time deletes all the corresponding Python tidy checks so we can be sure
to only have one source of truth for all the tidy checks.

cc #31590
d9a3447
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 9, 2016

💔 Test failed - auto-linux-64-x-freebsd
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 9, 2016

☔️ The latest upstream changes (presumably #32786) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton alexcrichton force-pushed the alexcrichton:rustbuild-tidy-checks branch from ae70c39 to a183085 Apr 11, 2016

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Apr 11, 2016

@bors: r=brson a183085
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 11, 2016

⌛️ Testing commit a183085 with merge 403cf4c...

bors added a commit that referenced this pull request Apr 11, 2016

@bors
Auto merge of #32590 - alexcrichton:rustbuild-tidy-checks, r=brson 
rustbuild: Migrate tidy checks to Rust

This commit rewrites all of the tidy checks we have, namely:

* featureck
* errorck
* tidy
* binaries

into Rust under a new `tidy` tool inside of the `src/tools` directory. This at
the same time deletes all the corresponding Python tidy checks so we can be sure
to only have one source of truth for all the tidy checks.

cc #31590
403cf4c
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 11, 2016

💔 Test failed - auto-linux-64-x-freebsd

@alexcrichton alexcrichton force-pushed the alexcrichton:rustbuild-tidy-checks branch from a183085 to dfb28be Apr 11, 2016

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Apr 11, 2016

@bors: r=brson dfb28be
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 12, 2016

⌛️ Testing commit dfb28be with merge 1ca6835...

bors added a commit that referenced this pull request Apr 12, 2016

@bors
Auto merge of #32590 - alexcrichton:rustbuild-tidy-checks, r=brson 
rustbuild: Migrate tidy checks to Rust

This commit rewrites all of the tidy checks we have, namely:

* featureck
* errorck
* tidy
* binaries

into Rust under a new `tidy` tool inside of the `src/tools` directory. This at
the same time deletes all the corresponding Python tidy checks so we can be sure
to only have one source of truth for all the tidy checks.

cc #31590
1ca6835
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 12, 2016

💔 Test failed - auto-linux-32-nopt-t

@alexcrichton alexcrichton force-pushed the alexcrichton:rustbuild-tidy-checks branch from dfb28be to 7ef35a8 Apr 12, 2016

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Apr 12, 2016

@bors: r=brson 7ef35a8

@alexcrichton alexcrichton referenced this pull request Apr 12, 2016

Closed

rustbuild: Add a tidy check to ensure Cargo.lock updates are checked in #32901

@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 12, 2016

⌛️ Testing commit 7ef35a8 with merge c765783...

bors added a commit that referenced this pull request Apr 12, 2016

@bors
Auto merge of #32590 - alexcrichton:rustbuild-tidy-checks, r=brson 
rustbuild: Migrate tidy checks to Rust

This commit rewrites all of the tidy checks we have, namely:

* featureck
* errorck
* tidy
* binaries

into Rust under a new `tidy` tool inside of the `src/tools` directory. This at
the same time deletes all the corresponding Python tidy checks so we can be sure
to only have one source of truth for all the tidy checks.

cc #31590
c765783
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 12, 2016

💔 Test failed - auto-win-msvc-64-opt
@alexcrichton
rustbuild: Migrate tidy checks to Rust 
This commit rewrites all of the tidy checks we have, namely:

* featureck
* errorck
* tidy
* binaries

into Rust under a new `tidy` tool inside of the `src/tools` directory. This at
the same time deletes all the corresponding Python tidy checks so we can be sure
to only have one source of truth for all the tidy checks.

cc #31590
9dd3c54

@alexcrichton alexcrichton force-pushed the alexcrichton:rustbuild-tidy-checks branch from 7ef35a8 to 386ca6a Apr 12, 2016

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Apr 12, 2016

@bors: r=brson 386ca6a
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 12, 2016

⌛️ Testing commit 386ca6a with merge 07ee429...

bors added a commit that referenced this pull request Apr 12, 2016

@bors
Auto merge of #32590 - alexcrichton:rustbuild-tidy-checks, r=brson 
rustbuild: Migrate tidy checks to Rust

This commit rewrites all of the tidy checks we have, namely:

* featureck
* errorck
* tidy
* binaries

into Rust under a new `tidy` tool inside of the `src/tools` directory. This at
the same time deletes all the corresponding Python tidy checks so we can be sure
to only have one source of truth for all the tidy checks.

cc #31590
07ee429
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 12, 2016

💔 Test failed - auto-win-msvc-64-opt
@alexcrichton
tidy: Add a check to ensure Cargo.toml is in sync 
This verifies that the crates listed in the `[dependencies]` section of
`Cargo.toml` are a subset of the crates listed in `lib.rs` for our in-tree
crates. This should help ensure that when we refactor crates over time we keep
these dependency lists in sync.
Loading status checks…
7bfaeaa

@alexcrichton alexcrichton force-pushed the alexcrichton:rustbuild-tidy-checks branch from 386ca6a to 7bfaeaa Apr 12, 2016

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Apr 12, 2016

@bors: r=brson 7bfaeaa
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 12, 2016

⌛️ Testing commit 7bfaeaa with merge a43eb4e...

bors added a commit that referenced this pull request Apr 12, 2016

@bors
Auto merge of #32590 - alexcrichton:rustbuild-tidy-checks, r=brson 
rustbuild: Migrate tidy checks to Rust

This commit rewrites all of the tidy checks we have, namely:

* featureck
* errorck
* tidy
* binaries

into Rust under a new `tidy` tool inside of the `src/tools` directory. This at
the same time deletes all the corresponding Python tidy checks so we can be sure
to only have one source of truth for all the tidy checks.

cc #31590
a43eb4e
@bors

@bors bors merged commit 7bfaeaa into rust-lang:master Apr 13, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@bors bors referenced this pull request Apr 13, 2016

Merged

rustbuild: Add support for compiletest test suites #32755

@alexcrichton alexcrichton deleted the alexcrichton:rustbuild-tidy-checks branch Apr 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.