Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upmk: A few build fixes for i586-pc-windows-msvc #32593
Conversation
rust-highfive
assigned
brson
Mar 29, 2016
This comment has been minimized.
This comment has been minimized.
|
@bors r+ |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
|
bors
added a commit
that referenced
this pull request
Mar 30, 2016
This comment has been minimized.
This comment has been minimized.
bors
merged commit 7668b4b
into
rust-lang:master
Mar 30, 2016
alexcrichton
deleted the
alexcrichton:fix-i586-msvc
branch
May 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
alexcrichton commentedMar 29, 2016
Detect the triple in the configure script for probing MSVC shenanigans and also
be sure to use
llvm-configfrom the build host and not the target whenconfiguring compiler-rt.