Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upcollections: Add slice::binary_search_by_key #32693
Conversation
rust-highfive
assigned
brson
Apr 3, 2016
This comment has been minimized.
This comment has been minimized.
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
kamalmarhubi
force-pushed the
kamalmarhubi:binary_search_by_key
branch
from
723f9d3
to
a13540b
Apr 3, 2016
alexcrichton
added
the
T-libs
label
Apr 3, 2016
This comment has been minimized.
This comment has been minimized.
|
|
kamalmarhubi
force-pushed the
kamalmarhubi:binary_search_by_key
branch
from
a13540b
to
62945b6
Apr 12, 2016
This comment has been minimized.
This comment has been minimized.
|
Rebased. |
This comment has been minimized.
This comment has been minimized.
|
The libs team discussed this during triage yesterday and the conclusion was to merge, thanks again for the PR @kamalmarhubi! |
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Apr 15, 2016
This comment has been minimized.
This comment has been minimized.
|
@alexcrichton Does it need a tracking issue to be filled in? |
This comment has been minimized.
This comment has been minimized.
|
Guh right, yes! If this lands, wanna file a follow-up PR filling that in? Also feel free to open the issue, I'll fill out the tags |
This comment has been minimized.
This comment has been minimized.
bors
merged commit 62945b6
into
rust-lang:master
Apr 15, 2016
kamalmarhubi
referenced this pull request
Apr 15, 2016
Closed
Tracking issue for slice::binary_search_by_key #33018
kamalmarhubi
deleted the
kamalmarhubi:binary_search_by_key
branch
Apr 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kamalmarhubi commentedApr 3, 2016
This method adds to the family of
_by_keymethods, and is thecounterpart of
slice::sort_by_key. It was mentioned on #30423 butwas not implemented at that time.
Refs #30423