Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate fast_reject for overlap checking #32748

Merged
merged 1 commit into from Apr 7, 2016

Conversation

Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
beta-accepted
Projects
None yet
Milestone
No milestone
4 participants
@aturon @nikomatsakis @bors @alexcrichton
@aturon
Copy link
Member

aturon commented Apr 5, 2016

The initial implementation of specialization did not use the
fast_reject mechanism when checking for overlap, which caused a
serious performance regression in some cases.

This commit modifies the specialization graph to use simplified types
for fast rejection when possible, and along the way refactors the logic
for building the specialization graph.

Closes #32499

r? @nikomatsakis
@aturon
Reinstate fast_reject for overlap checking 
The initial implementation of specialization did not use the
`fast_reject` mechanism when checking for overlap, which caused a
serious performance regression in some cases.

This commit modifies the specialization graph to use simplified types
for fast rejection when possible, and along the way refactors the logic
for building the specialization graph.

Closes #32499
9ba3d5e

@rust-highfive rust-highfive assigned nikomatsakis Apr 5, 2016

@aturon aturon referenced this pull request Apr 5, 2016

Closed

Bad regression in coherence checking in winapi #32499

@aturon

This comment has been minimized.

Sign in to view
Copy link
Member Author

aturon commented Apr 5, 2016

Note: I've confirmed locally that this resolves the coherence slowdown for winapi.
@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor

nikomatsakis commented Apr 5, 2016

It'd be nice to have a regression test added to https://github.com/nrc/rustc-perf
@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor

nikomatsakis commented Apr 5, 2016

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 5, 2016

📌 Commit 9ba3d5e has been approved by nikomatsakis

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 6, 2016

@Manishearth
Rollup merge of rust-lang#32748 - aturon:simplified-spec, r=nikomatsakis 
Reinstate fast_reject for overlap checking

The initial implementation of specialization did not use the
`fast_reject` mechanism when checking for overlap, which caused a
serious performance regression in some cases.

This commit modifies the specialization graph to use simplified types
for fast rejection when possible, and along the way refactors the logic
for building the specialization graph.

Closes rust-lang#32499

r? @nikomatsakis
c351e6b

@Manishearth Manishearth referenced this pull request Apr 6, 2016

Closed

Rollup of 13 pull requests #32759

bors added a commit that referenced this pull request Apr 6, 2016

@bors
Auto merge of #32759 - Manishearth:rollup, r=Manishearth 
Rollup of 13 pull requests

- Successful merges: #31762, #32538, #32634, #32649, #32668, #32679, #32699, #32731, #32732, #32741, #32745, #32748, #32757
- Failed merges:
36622ee

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 6, 2016

@Manishearth
Rollup merge of rust-lang#32748 - aturon:simplified-spec, r=nikomatsakis 
Reinstate fast_reject for overlap checking

The initial implementation of specialization did not use the
`fast_reject` mechanism when checking for overlap, which caused a
serious performance regression in some cases.

This commit modifies the specialization graph to use simplified types
for fast rejection when possible, and along the way refactors the logic
for building the specialization graph.

Closes rust-lang#32499

r? @nikomatsakis
9513b81

bors added a commit that referenced this pull request Apr 6, 2016

@bors
Auto merge of #32759 - Manishearth:rollup, r=Manishearth 
Rollup of 13 pull requests

- Successful merges: #31762, #32538, #32634, #32649, #32668, #32679, #32699, #32731, #32732, #32741, #32745, #32748, #32757
- Failed merges:
21d127b

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 6, 2016

@Manishearth
Rollup merge of rust-lang#32748 - aturon:simplified-spec, r=nikomatsakis 
Reinstate fast_reject for overlap checking

The initial implementation of specialization did not use the
`fast_reject` mechanism when checking for overlap, which caused a
serious performance regression in some cases.

This commit modifies the specialization graph to use simplified types
for fast rejection when possible, and along the way refactors the logic
for building the specialization graph.

Closes rust-lang#32499

r? @nikomatsakis
fd6b40c

bors added a commit that referenced this pull request Apr 6, 2016

@bors
Auto merge of #32759 - Manishearth:rollup, r=Manishearth 
Rollup of 13 pull requests

- Successful merges: #31762, #32538, #32634, #32649, #32668, #32679, #32699, #32731, #32732, #32741, #32745, #32748, #32757
- Failed merges:
6409dfe

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 7, 2016

@Manishearth
Rollup merge of rust-lang#32748 - aturon:simplified-spec, r=nikomatsakis 
Reinstate fast_reject for overlap checking

The initial implementation of specialization did not use the
`fast_reject` mechanism when checking for overlap, which caused a
serious performance regression in some cases.

This commit modifies the specialization graph to use simplified types
for fast rejection when possible, and along the way refactors the logic
for building the specialization graph.

Closes rust-lang#32499

r? @nikomatsakis
a7a9147

@Manishearth Manishearth referenced this pull request Apr 7, 2016

Closed

Rollup of 11 pull requests #32787

bors added a commit that referenced this pull request Apr 7, 2016

@bors
Auto merge of #32787 - Manishearth:rollup, r=Manishearth 
Rollup of 11 pull requests

- Successful merges: #32016, #32583, #32699, #32729, #32731, #32738, #32741, #32745, #32748, #32757, #32786
- Failed merges: #32773
0c65bd6

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 7, 2016

@Manishearth
Rollup merge of rust-lang#32748 - aturon:simplified-spec, r=nikomatsakis 
Reinstate fast_reject for overlap checking

The initial implementation of specialization did not use the
`fast_reject` mechanism when checking for overlap, which caused a
serious performance regression in some cases.

This commit modifies the specialization graph to use simplified types
for fast rejection when possible, and along the way refactors the logic
for building the specialization graph.

Closes rust-lang#32499

r? @nikomatsakis
a05fa94

bors added a commit that referenced this pull request Apr 7, 2016

@bors
Auto merge of #32787 - Manishearth:rollup, r=Manishearth 
Rollup of 11 pull requests

- Successful merges: #32016, #32583, #32699, #32729, #32731, #32738, #32741, #32745, #32748, #32757, #32786
- Failed merges: #32773
6a55f4f

@Manishearth Manishearth referenced this pull request Apr 7, 2016

Merged

Rollup of 7 pull requests #32794

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 7, 2016

@Manishearth
Rollup merge of rust-lang#32748 - aturon:simplified-spec, r=nikomatsakis 
Reinstate fast_reject for overlap checking

The initial implementation of specialization did not use the
`fast_reject` mechanism when checking for overlap, which caused a
serious performance regression in some cases.

This commit modifies the specialization graph to use simplified types
for fast rejection when possible, and along the way refactors the logic
for building the specialization graph.

Closes rust-lang#32499

r? @nikomatsakis
d421acd

bors added a commit that referenced this pull request Apr 7, 2016

@bors
Auto merge of #32794 - Manishearth:rollup, r=Manishearth 
Rollup of 7 pull requests

- Successful merges: #32674, #32699, #32711, #32745, #32748, #32757, #32789
- Failed merges:
4c20e53

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 7, 2016

@Manishearth
Rollup merge of rust-lang#32748 - aturon:simplified-spec, r=nikomatsakis 
Reinstate fast_reject for overlap checking

The initial implementation of specialization did not use the
`fast_reject` mechanism when checking for overlap, which caused a
serious performance regression in some cases.

This commit modifies the specialization graph to use simplified types
for fast rejection when possible, and along the way refactors the logic
for building the specialization graph.

Closes rust-lang#32499

r? @nikomatsakis
c0ea2ad

bors added a commit that referenced this pull request Apr 7, 2016

@bors
Auto merge of #32794 - Manishearth:rollup, r=Manishearth 
Rollup of 7 pull requests

- Successful merges: #32674, #32699, #32711, #32745, #32748, #32757, #32789
- Failed merges:
470ca1c

@bors bors merged commit 9ba3d5e into rust-lang:master Apr 7, 2016

@nikomatsakis nikomatsakis added the beta-nominated label Apr 21, 2016

@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor

nikomatsakis commented Apr 21, 2016

Nominating for regression because:

  • it can be a MAJOR problem
  • it affects winapi

@nikomatsakis nikomatsakis added the beta-accepted label Apr 21, 2016

@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor

nikomatsakis commented Apr 21, 2016

Accepting for beta based on prior criteria.

@pnkfelix pnkfelix referenced this pull request Apr 22, 2016

Closed

Regression of the `typenum` crate on nightly #32637

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented May 4, 2016

I'm not sure if this backport was intended for 1.8, but it's missed that train unfortunately. Beta was branched off of b622c3e, however, which includes this commit, so I'm going to remove the beta-nominated tag as our way of indicating "backport done" is "beta-accepted" only, and the "backport" is done as this just made its way naturally into 1.9

@alexcrichton alexcrichton removed the beta-nominated label May 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.