std: Stabilize APIs for the 1.9 release #32804

alexcrichton · Apr 7, 2016

This commit applies all stabilizations, renamings, and deprecations that the
library team has decided on for the upcoming 1.9 release. All tracking issues
have gone through a cycle-long "final comment period" and the specific APIs
stabilized/deprecated are:

Stable

std::panic
std::panic::catch_unwind (renamed from recover)
std::panic::resume_unwind (renamed from propagate)
std::panic::AssertUnwindSafe (renamed from AssertRecoverSafe)
std::panic::UnwindSafe (renamed from RecoverSafe)
str::is_char_boundary
<*const T>::as_ref
<*mut T>::as_ref
<*mut T>::as_mut
AsciiExt::make_ascii_uppercase
AsciiExt::make_ascii_lowercase
char::decode_utf16
char::DecodeUtf16
char::DecodeUtf16Error
char::DecodeUtf16Error::unpaired_surrogate
BTreeSet::take
BTreeSet::replace
BTreeSet::get
HashSet::take
HashSet::replace
HashSet::get
OsString::with_capacity
OsString::clear
OsString::capacity
OsString::reserve
OsString::reserve_exact
OsStr::is_empty
OsStr::len
std::os::unix::thread
RawPthread
JoinHandleExt
JoinHandleExt::as_pthread_t
JoinHandleExt::into_pthread_t
HashSet::hasher
HashMap::hasher
CommandExt::exec
File::try_clone
SocketAddr::set_ip
SocketAddr::set_port
SocketAddrV4::set_ip
SocketAddrV4::set_port
SocketAddrV6::set_ip
SocketAddrV6::set_port
SocketAddrV6::set_flowinfo
SocketAddrV6::set_scope_id
<[T]>::copy_from_slice
ptr::read_volatile
ptr::write_volatile
The #[deprecated] attribute
OpenOptions::create_new

Deprecated

std::raw::Slice - use raw parts of slice module instead
std::raw::Repr - use raw parts of slice module instead
str::char_range_at - use slicing plus chars() plus len_utf8
str::char_range_at_reverse - use slicing plus chars().rev() plus len_utf8
str::char_at - use slicing plus chars()
str::char_at_reverse - use slicing plus chars().rev()
str::slice_shift_char - use chars() plus Chars::as_str
CommandExt::session_leader - use before_exec instead.

Closes #27719
cc #27751 (deprecating the Slice bits)
Closes #27754
Closes #27780
Closes #27809
Closes #27811
Closes #27830
Closes #28050
Closes #29453
Closes #29791
Closes #29935
Closes #30014
Closes #30752
Closes #31262
cc #31398 (still need to deal with before_exec)
Closes #31405
Closes #31572
Closes #31755
Closes #31756

rust-highfive · Apr 7, 2016

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

alexcrichton · Apr 7, 2016

r? @brson

brson · Apr 7, 2016

brson reviewed Apr 7, 2016

View changes

brson · Apr 7, 2016

src/libcore/ptr.rs

+/// Rust does not currently have a rigorously and formally defined memory model,
+/// so the precise semantics of what "volatile" means here is subject to change
+/// over time. That being said, the semantics will almost always end up pretty
+/// close to what [C11's definition of volatile is][c11].


-> "close to C11's definition of volatile". Extra "what" and "is".

or "end up similar to C11's..."

brson · Apr 7, 2016

brson reviewed Apr 7, 2016

View changes

brson · Apr 7, 2016

src/libstd/ffi/os_str.rs

+    /// Creates a new `OsString` with the given capacity.
+    ///
+    /// The string will be able to hold exactly `capacity` lenth units of other
+    /// OS stringswithout reallocating. If `capacity` is 0, the string will not


"stringswithout"

brson · Apr 7, 2016

brson reviewed Apr 7, 2016

View changes

brson · Apr 7, 2016

src/libstd/panic.rs

+pub trait UnwindSafe {}
+
+/// Deprecated, renamed to UnwindSafe
+#[unstable(feature = "recover", reason = "awaiting feedback", issue = "27719")]
 pub trait RecoverSafe {}


Add rustc_deprecated?

brson · Apr 7, 2016

brson reviewed Apr 7, 2016

View changes

brson · Apr 7, 2016

src/libsyntax/feature_gate.rs

@@ -237,7 +237,7 @@ const KNOWN_FEATURES: &'static [(&'static str, &'static str, Option<u32>, Status
    ("stmt_expr_attributes", "1.6.0", Some(15701), Active),

    // Allows `#[deprecated]` attribute
-    ("deprecated", "1.6.0", Some(29935), Active),
+    ("deprecated", "1.6.0", Some(29935), Accepted),


This should be bumped to 1.9.0. "The version numbers here correspond to the version in which the current status
// was set".

brson · Apr 7, 2016

r=me w/ feedback

alexcrichton · Apr 7, 2016

@bors: r=brson ba2589c

tamird · Apr 8, 2016

tamird reviewed Apr 8, 2016

View changes

tamird · Apr 8, 2016

src/compiletest/compiletest.rs

+                if pos + 2 >= full_version_line.len() {
+                    continue
+                }
+                if full_version_line[pos + 1..].chars().next().unwrap() != '.' {


not sure it matters, but you could probably use just one iterator here rather than 3.

ditto on L464

Perhaps yeah, but this is pretty brittle and has no tests, so I'd rather not tamper with it too much.

tamird · Apr 8, 2016

tamird reviewed Apr 8, 2016

View changes

tamird · Apr 8, 2016

src/librustc/session/mod.rs

@@ -351,11 +351,11 @@ fn split_msg_into_multilines(msg: &str) -> Option<String> {
            return None
    }
    let first = msg.match_indices("expected").filter(|s| {
-        s.0 > 0 && (msg.char_at_reverse(s.0) == ' ' ||
-                    msg.char_at_reverse(s.0) == '(')
+        s.0 > 0 && (msg[..s.0].chars().rev().next() == Some(' ') ||


seems easy to extract a local binding

Manishearth · Apr 8, 2016

src/libstd/panic.rs:125:21: 125:32 error: use of deprecated item: renamed to `UnwindSafe`

src/libstd/panic.rs:125 impl<T: UnwindSafe> RecoverSafe for T {}
                                            ^~~~~~~~~~~
src/libstd/lib.rs:283:31: 283:39 note: lint level defined here
src/libstd/lib.rs:283 #![cfg_attr(not(stage0), deny(warnings))]

alexcrichton · Apr 8, 2016

@bors: r=brson 0d18015

bors · Apr 9, 2016

⌛️ Testing commit 0d18015 with merge df79da8...

bors · Apr 9, 2016

💔 Test failed - auto-win-msvc-64-opt

bluss · Apr 10, 2016

rustc: x86_64-pc-windows-msvc/stage0/lib/rustlib/x86_64-pc-windows-msvc/lib/libstd
../src/libstd\sys/windows\ext\thread.rs:19:1: 23:2 error: This node does not have a stability attribute
../src/libstd\sys/windows\ext\thread.rs:19 impl<T> AsRawHandle for thread::JoinHandle<T> {
../src/libstd\sys/windows\ext\thread.rs:20     fn as_raw_handle(&self) -> RawHandle {
../src/libstd\sys/windows\ext\thread.rs:21         self.as_inner().handle().raw() as *mut _
../src/libstd\sys/windows\ext\thread.rs:22     }
../src/libstd\sys/windows\ext\thread.rs:23 }
../src/libstd\sys/windows\ext\thread.rs:25:1: 29:2 error: This node does not have a stability attribute
../src/libstd\sys/windows\ext\thread.rs:25 impl<T> IntoRawHandle for thread::JoinHandle<T>  {
../src/libstd\sys/windows\ext\thread.rs:26     fn into_raw_handle(self) -> RawHandle {
../src/libstd\sys/windows\ext\thread.rs:27         self.into_inner().into_handle().into_raw() as *mut _
../src/libstd\sys/windows\ext\thread.rs:28     }
../src/libstd\sys/windows\ext\thread.rs:29 }
error: aborting due to 2 previous errors

alexcrichton · Apr 11, 2016

@bors: r=brson 552eda7

brson · Apr 11, 2016

These will need to be backported.

bors · Apr 12, 2016

⌛️ Testing commit 552eda7 with merge bed32d8...

bors · Apr 12, 2016

rust-highfive assigned aturon Apr 7, 2016

rust-highfive assigned brson and unassigned aturon Apr 7, 2016

brson added the relnotes label Apr 7, 2016

alexcrichton force-pushed the alexcrichton:stabilize-1.9 branch from 26b2482 to ba2589c Apr 7, 2016

alexcrichton referenced this pull request Apr 7, 2016
Open
Tracking issue for `raw` stabilization (`raw::TraitObject`) #27751

alexcrichton force-pushed the alexcrichton:stabilize-1.9 branch from ba2589c to 0d18015 Apr 8, 2016

Amanieu referenced this pull request Apr 10, 2016
Merged
Fix undefined behavior in regex_macros #201

alexcrichton force-pushed the alexcrichton:stabilize-1.9 branch from 0d18015 to 552eda7 Apr 11, 2016

brson added the beta-nominated label Apr 11, 2016

bors merged commit 552eda7 into rust-lang:master Apr 12, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

This was referenced Apr 12, 2016

Closed

Implement Vec::splice and String::splice #32355

Merged

rustc: Implement custom panic runtimes #32900

Merged

collections: Add slice::binary_search_by_key #32693

Merged

rustbuild: Add support for compiletest test suites #32755

alexcrichton added the beta-accepted label Apr 12, 2016

alexcrichton referenced this pull request Apr 12, 2016
Merged
[beta] Backport API stabilizations #32910

brson removed the beta-nominated label Apr 12, 2016

alexcrichton deleted the alexcrichton:stabilize-1.9 branch Apr 13, 2016

dtolnay referenced this pull request Apr 22, 2016
Merged
Remove feature(hashmap_public_hasher) #52

alexcrichton referenced this pull request Jun 21, 2016
Merged
std: Fix up stabilization discrepancies #34399

Stebalien referenced this pull request Aug 20, 2016
Closed
Stabilize raw::Slice #945

rust-lang/rust

Join GitHub today

std: Stabilize APIs for the 1.9 release #32804

Conversation

alexcrichton commented Apr 7, 2016

rust-highfive assigned aturon Apr 7, 2016

This comment has been minimized.

rust-highfive commented Apr 7, 2016

This comment has been minimized.

alexcrichton commented Apr 7, 2016

rust-highfive assigned brson and unassigned aturon Apr 7, 2016

brson added the relnotes label Apr 7, 2016

brson reviewed Apr 7, 2016 View changes

This comment has been minimized.

This comment has been minimized.

brson reviewed Apr 7, 2016 View changes

This comment has been minimized.

brson reviewed Apr 7, 2016 View changes

This comment has been minimized.

brson reviewed Apr 7, 2016 View changes

This comment has been minimized.

This comment has been minimized.

brson commented Apr 7, 2016

alexcrichton force-pushed the alexcrichton:stabilize-1.9 branch from 26b2482 to ba2589c Apr 7, 2016

This comment has been minimized.

alexcrichton commented Apr 7, 2016

alexcrichton referenced this pull request Apr 7, 2016

tamird reviewed Apr 8, 2016 View changes

This comment has been minimized.

This comment has been minimized.

tamird reviewed Apr 8, 2016 View changes

This comment has been minimized.

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 8, 2016

This comment has been minimized.

Manishearth commented Apr 8, 2016

alexcrichton force-pushed the alexcrichton:stabilize-1.9 branch from ba2589c to 0d18015 Apr 8, 2016

This comment has been minimized.

alexcrichton commented Apr 8, 2016

This comment has been minimized.

bors commented Apr 9, 2016

bors added a commit that referenced this pull request Apr 9, 2016

This comment has been minimized.

bors commented Apr 9, 2016

This comment has been minimized.

bluss commented Apr 10, 2016

Amanieu referenced this pull request Apr 10, 2016

alexcrichton force-pushed the alexcrichton:stabilize-1.9 branch from 0d18015 to 552eda7 Apr 11, 2016

This comment has been minimized.

alexcrichton commented Apr 11, 2016

brson added the beta-nominated label Apr 11, 2016

This comment has been minimized.

brson commented Apr 11, 2016

This comment has been minimized.

bors commented Apr 12, 2016

bors added a commit that referenced this pull request Apr 12, 2016

This comment has been minimized.

bors commented Apr 12, 2016

Hide details View details bors merged commit 552eda7 into rust-lang:master Apr 12, 2016 2 checks passed

2 checks passed

This was referenced Apr 12, 2016

alexcrichton added the beta-accepted label Apr 12, 2016

alexcrichton referenced this pull request Apr 12, 2016

brson removed the beta-nominated label Apr 12, 2016

alexcrichton deleted the alexcrichton:stabilize-1.9 branch Apr 13, 2016

dtolnay referenced this pull request Apr 22, 2016

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jun 21, 2016

alexcrichton referenced this pull request Jun 21, 2016

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jun 22, 2016

bors added a commit that referenced this pull request Jun 23, 2016

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jun 23, 2016

bors added a commit that referenced this pull request Jun 23, 2016

bors added a commit that referenced this pull request Jun 24, 2016

Stebalien referenced this pull request Aug 20, 2016

brson reviewed Apr 7, 2016

View changes

brson reviewed Apr 7, 2016

View changes

brson reviewed Apr 7, 2016

View changes

brson reviewed Apr 7, 2016

View changes

alexcrichton force-pushed the alexcrichton:stabilize-1.9 branch from `26b2482` to `ba2589c` Apr 7, 2016

tamird reviewed Apr 8, 2016

View changes

tamird reviewed Apr 8, 2016

View changes

alexcrichton force-pushed the alexcrichton:stabilize-1.9 branch from `ba2589c` to `0d18015` Apr 8, 2016

alexcrichton force-pushed the alexcrichton:stabilize-1.9 branch from `0d18015` to `552eda7` Apr 11, 2016

bors merged commit `552eda7` into rust-lang:master Apr 12, 2016
2 checks passed