Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trans: always register an item's symbol, even if duplicated. #32946

Merged
merged 1 commit into from Apr 16, 2016

Conversation

Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
beta-accepted
Projects
None yet
Milestone
No milestone
7 participants
@eddyb @rust-highfive @dotdash @bors @brson @nikomatsakis @pnkfelix
@eddyb
Copy link
Member

eddyb commented Apr 14, 2016

Fixes #32783 which was introduced by not always registering item symbols in #32742.

@rust-highfive rust-highfive assigned pnkfelix Apr 14, 2016

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Apr 14, 2016

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@eddyb eddyb force-pushed the eddyb:issue-32783 branch from 222e823 to cd85120 Apr 14, 2016

@eddyb eddyb added the beta-nominated label Apr 14, 2016

@dotdash

This comment has been minimized.

Sign in to view
Copy link
Contributor

dotdash commented Apr 14, 2016

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 14, 2016

📌 Commit cd85120 has been approved by dotdash
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 14, 2016

⌛️ Testing commit cd85120 with merge 0730d4a...

bors added a commit that referenced this pull request Apr 14, 2016

@bors
Auto merge of #32946 - eddyb:issue-32783, r=dotdash 
trans: always register an item's symbol, even if duplicated.

Fixes #32783 which was introduced by not always registering item symbols in #32742.
0730d4a
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 14, 2016

💔 Test failed - auto-win-msvc-64-cargotest
@eddyb

This comment has been minimized.

Sign in to view
Copy link
Member Author

eddyb commented Apr 14, 2016

@bors retry

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 15, 2016

@Manishearth
Rollup merge of rust-lang#32946 - eddyb:issue-32783, r=dotdash 
trans: always register an item's symbol, even if duplicated.

Fixes rust-lang#32783 which was introduced by not always registering item symbols in rust-lang#32742.
de98038

@Manishearth Manishearth referenced this pull request Apr 15, 2016

Merged

Rollup of 11 pull requests #33005

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 15, 2016

@Manishearth
Rollup merge of rust-lang#32946 - eddyb:issue-32783, r=dotdash 
trans: always register an item's symbol, even if duplicated.

Fixes rust-lang#32783 which was introduced by not always registering item symbols in rust-lang#32742.
Verified
This commit was signed with a verified signature.
@Manishearth Manishearth Manish Goregaokar
GPG key ID: 3BBF4D3E2EF79F98 Learn about signing commits
5bdbf8e

bors added a commit that referenced this pull request Apr 15, 2016

@bors
Auto merge of #33005 - Manishearth:rollup, r=Manishearth 
Rollup of 11 pull requests

- Successful merges: #32923, #32926, #32929, #32931, #32935, #32945, #32946, #32964, #32970, #32973, #32997
- Failed merges:
576229f

@bors bors merged commit cd85120 into rust-lang:master Apr 16, 2016
1 of 2 checks passed

1 of 2 checks passed

homu Test failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eddyb eddyb deleted the eddyb:issue-32783 branch Apr 16, 2016

@nikomatsakis nikomatsakis added the beta-accepted label Apr 21, 2016

@alexcrichton alexcrichton referenced this pull request May 4, 2016

Merged

Merge beta-accepted into beta #33407

@brson brson removed the beta-nominated label May 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.