Warn unused trait imports, rebased #33091

sanxiyn · Apr 19, 2016

Rebase of #30021.

rust-highfive · Apr 19, 2016

(rust_highfive has picked a reviewer for you, use r? to override)

bors · Apr 19, 2016

☔️ The latest upstream changes (presumably #33002) made this pull request unmergeable. Please resolve the merge conflicts.

nrc · Apr 20, 2016

r+ with a rebase

sanxiyn · Apr 20, 2016

Travis failure is legit.

f64::sqrt is defined in std. Since librand is no_std, librand defines its own version in FloatMath trait and imports it. But randtest is not no_std, so FloatMath import is necessary for librand and unused for randtest.

sanxiyn · Apr 20, 2016

Rebased and fixed tests.

nrc · Apr 20, 2016

@bors: r+

bors · Apr 20, 2016

📌 Commit baf2fff has been approved by nrc

bors · Apr 21, 2016

⌛️ Testing commit baf2fff with merge 2209876...

bors · Apr 21, 2016

💔 Test failed - auto-win-msvc-64-opt

alexcrichton · Apr 21, 2016

@bors: retry

On Thu, Apr 21, 2016 at 11:01 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-win-msvc-64-opt
http://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt/builds/3888

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#33091 (comment)

bors · Apr 22, 2016

⌛️ Testing commit baf2fff with merge c148426...

bors · Apr 22, 2016

💔 Test failed - auto-win-msvc-64-opt

alexcrichton · Apr 22, 2016

@bors: retry

On Fri, Apr 22, 2016 at 8:23 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-win-msvc-64-opt
http://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt/builds/3899

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#33091 (comment)

mitaa · Apr 23, 2016

cc #33154

I assume this has something to do with this PR?

C:\bot\slave\auto-win-gnu-32-opt-rustbuild\build\src\libstd\sys/windows\fs.rs:12:5: 12:20 error: unused import
C:\bot\slave\auto-win-gnu-32-opt-rustbuild\build\src\libstd\sys/windows\fs.rs:12 use io::prelude::*;
                                                                                     ^~~~~~~~~~~~~~~
C:\bot\slave\auto-win-gnu-32-opt-rustbuild\build\src\libstd\lib.rs:283:31: 283:39 note: lint level defined here
C:\bot\slave\auto-win-gnu-32-opt-rustbuild\build\src\libstd\lib.rs:283 #![cfg_attr(not(stage0), deny(warnings))]
                                                                                                     ^~~~~~~~

sanxiyn · Apr 23, 2016

Yes, it does. Thanks for noticing.

sanxiyn · Apr 23, 2016

@bors r-

sanxiyn · Apr 25, 2016

@bors r=nrc

bors · Apr 25, 2016

📌 Commit 71f19ba has been approved by nrc

bors · Apr 25, 2016

⌛️ Testing commit 71f19ba with merge 2bb7770...

bors · Apr 25, 2016

💔 Test failed - auto-linux-64-cargotest

bluss · Apr 25, 2016

Cargo should not be using deny since that makes it explicitly not forward compatible with lint changes.

@brson can we change cargotest to cap the lint level?

sanxiyn · Apr 25, 2016

We could use RUSTFLAGS. Two problems: first, cargo used by rustbuild at the moment is too old and does not support RUSTFLAGS. Second, setting RUSTFLAGS interferes with running cargo test suite.

bors · May 6, 2016

⌛️ Testing commit 282afda with merge 4bb89bd...

bors · May 6, 2016

💔 Test failed - auto-linux-64-opt-rustbuild

alexcrichton · May 6, 2016

@bors: retry

#33435

On Fri, May 6, 2016 at 6:07 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-linux-64-opt-rustbuild
http://buildbot.rust-lang.org/builders/auto-linux-64-opt-rustbuild/builds/997

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#33091 (comment)

bors · May 6, 2016

⌛️ Testing commit 282afda with merge 2843f13...

bors · May 6, 2016

💔 Test failed - auto-linux-64-opt-rustbuild

sanxiyn · May 7, 2016

@bors retry

bors · May 7, 2016

⌛️ Testing commit 282afda with merge 464f387...

bors · May 7, 2016

💔 Test failed - auto-linux-64-opt-rustbuild

alexcrichton · May 7, 2016

@bors: retry

#33435

On Sat, May 7, 2016 at 7:59 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-linux-64-opt-rustbuild
http://buildbot.rust-lang.org/builders/auto-linux-64-opt-rustbuild/builds/1015

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#33091 (comment)

bors · May 7, 2016

⌛️ Testing commit 282afda with merge a98ad9f...

bors · May 7, 2016

⛄️ The build was interrupted to prioritize another pull request.

bors · May 8, 2016

⌛️ Testing commit 282afda with merge b4a9f6b...

bors · May 8, 2016

💔 Test failed - auto-linux-64-opt-rustbuild

sanxiyn · May 8, 2016

@bors retry

bors · May 8, 2016

⌛️ Testing commit 282afda with merge 8e414e0...

bors · May 8, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-32cross-opt, auto-linux-64-cargotest, auto-linux-64-cross-armhf, auto-linux-64-cross-armsf, auto-linux-64-cross-freebsd, auto-linux-64-cross-netbsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-cross-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild

rust-highfive assigned nrc Apr 19, 2016

sanxiyn force-pushed the sanxiyn:unused-trait-import-3 branch from 0d38418 to 6ede0f8 Apr 20, 2016

bors added a commit that referenced this pull request Apr 21, 2016

Auto merge of #33091 - sanxiyn:unused-trait-import-3, r=nrc
Warn unused trait imports, rebased Rebase of #30021. Fix #25730.

2209876

bors added a commit that referenced this pull request Apr 22, 2016

Auto merge of #33091 - sanxiyn:unused-trait-import-3, r=nrc
Warn unused trait imports, rebased Rebase of #30021. Fix #25730.

c148426

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 22, 2016

Rollup merge of rust-lang#33091 - sanxiyn:unused-trait-import-3, r=nrc
Warn unused trait imports, rebased Rebase of rust-lang#30021. Fix rust-lang#25730.

9cdfc10

Manishearth referenced this pull request Apr 22, 2016
Closed
Rollup of 6 pull requests #33154

bors added a commit that referenced this pull request Apr 22, 2016

Auto merge of #33154 - Manishearth:rollup, r=Manishearth
Rollup of 6 pull requests - Successful merges: #31169, #32258, #33020, #33084, #33091, #33092 - Failed merges: #33093

c908cf0

bors added a commit that referenced this pull request Apr 25, 2016

Auto merge of #33091 - sanxiyn:unused-trait-import-3, r=nrc
Warn unused trait imports, rebased Rebase of #30021. Fix #25730.

2bb7770

bors added a commit that referenced this pull request May 6, 2016

Auto merge of #33091 - sanxiyn:unused-trait-import-3, r=nrc
Warn unused trait imports, rebased Rebase of #30021. Fix #25730.

4bb89bd

bors added a commit that referenced this pull request May 6, 2016

Auto merge of #33091 - sanxiyn:unused-trait-import-3, r=nrc
Warn unused trait imports, rebased Rebase of #30021. Fix #25730.

2843f13

bors added a commit that referenced this pull request May 7, 2016

Auto merge of #33091 - sanxiyn:unused-trait-import-3, r=nrc
Warn unused trait imports, rebased Rebase of #30021. Fix #25730.

464f387

bors added a commit that referenced this pull request May 7, 2016

Auto merge of #33091 - sanxiyn:unused-trait-import-3, r=nrc
Warn unused trait imports, rebased Rebase of #30021. Fix #25730.

a98ad9f

bors added a commit that referenced this pull request May 8, 2016

Auto merge of #33091 - sanxiyn:unused-trait-import-3, r=nrc
Warn unused trait imports, rebased Rebase of #30021. Fix #25730.

b4a9f6b

bors added a commit that referenced this pull request May 8, 2016

Auto merge of #33091 - sanxiyn:unused-trait-import-3, r=nrc
Warn unused trait imports, rebased Rebase of #30021. Fix #25730.

8e414e0

bors merged commit 282afda into rust-lang:master May 8, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

sanxiyn deleted the sanxiyn:unused-trait-import-3 branch May 8, 2016

jonas-schievink referenced this pull request Jul 3, 2016
Closed
Unused imports lint should detect redundant prelude imports #28296

rust-lang/rust

Join GitHub today

Warn unused trait imports, rebased #33091

Conversation

sanxiyn commented Apr 19, 2016

rust-highfive assigned nrc Apr 19, 2016

This comment has been minimized.

rust-highfive commented Apr 19, 2016

This comment has been minimized.

bors commented Apr 19, 2016

This comment has been minimized.

nrc commented Apr 20, 2016

This comment has been minimized.

sanxiyn commented Apr 20, 2016

sanxiyn force-pushed the sanxiyn:unused-trait-import-3 branch from 0d38418 to 6ede0f8 Apr 20, 2016

This comment has been minimized.

sanxiyn commented Apr 20, 2016

This comment has been minimized.

nrc commented Apr 20, 2016

This comment has been minimized.

bors commented Apr 20, 2016

This comment has been minimized.

bors commented Apr 21, 2016

bors added a commit that referenced this pull request Apr 21, 2016

This comment has been minimized.

bors commented Apr 21, 2016

This comment has been minimized.

alexcrichton commented Apr 21, 2016

This comment has been minimized.

bors commented Apr 22, 2016

bors added a commit that referenced this pull request Apr 22, 2016

This comment has been minimized.

bors commented Apr 22, 2016

This comment has been minimized.

alexcrichton commented Apr 22, 2016

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 22, 2016

Manishearth referenced this pull request Apr 22, 2016

Rollup of 6 pull requests #33154

bors added a commit that referenced this pull request Apr 22, 2016

This comment has been minimized.

mitaa commented Apr 23, 2016

This comment has been minimized.

sanxiyn commented Apr 23, 2016

This comment has been minimized.

sanxiyn commented Apr 23, 2016

This comment has been minimized.

sanxiyn commented Apr 25, 2016

This comment has been minimized.

bors commented Apr 25, 2016

This comment has been minimized.

bors commented Apr 25, 2016

bors added a commit that referenced this pull request Apr 25, 2016

This comment has been minimized.

bors commented Apr 25, 2016

This comment has been minimized.

bluss commented Apr 25, 2016

This comment has been minimized.

sanxiyn commented Apr 25, 2016

This comment has been minimized.

bors commented May 6, 2016

bors added a commit that referenced this pull request May 6, 2016

This comment has been minimized.

bors commented May 6, 2016

This comment has been minimized.

alexcrichton commented May 6, 2016

This comment has been minimized.

bors commented May 6, 2016

bors added a commit that referenced this pull request May 6, 2016

This comment has been minimized.

bors commented May 6, 2016

This comment has been minimized.

sanxiyn commented May 7, 2016

This comment has been minimized.

bors commented May 7, 2016

bors added a commit that referenced this pull request May 7, 2016

This comment has been minimized.

bors commented May 7, 2016

This comment has been minimized.

alexcrichton commented May 7, 2016

This comment has been minimized.

sanxiyn force-pushed the sanxiyn:unused-trait-import-3 branch from `0d38418` to `6ede0f8` Apr 20, 2016

bors merged commit `282afda` into rust-lang:master May 8, 2016
2 checks passed