Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IPV6_V6ONLY functionality #33124

Merged
merged 1 commit into from Apr 24, 2016

Conversation

Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
T-libs beta-accepted
Projects
None yet
Milestone
No milestone
5 participants
@sfackler @alexcrichton @BurntSushi @aturon @bors
@sfackler
Copy link
Member

sfackler commented Apr 21, 2016

These settings can only be adjusted before bind time, which doesn't make
sense in the current set of functionality. These methods are stable, but
haven't hit a stable release yet.

Closes #33052

[breaking-change]

r? @alexcrichton

Will also need a backport to the beta.
@sfackler
Remove IPV6_V6ONLY functionality 
These settings can only be adjusted before bind time, which doesn't make
sense in the current set of functionality. These methods are stable, but
haven't hit a stable release yet.

Closes #33052

[breaking-change]
Loading status checks…
c6480e8

@rust-highfive rust-highfive assigned alexcrichton Apr 21, 2016

@sfackler sfackler added beta-nominated T-libs labels Apr 21, 2016

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Apr 21, 2016

cc @rust-lang/libs, thinking of merging this soon!
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Apr 21, 2016

I'll also note that these methods aren't completely useless. It's possible to create a socket manually, wrap it up in TcpStream, and then later manually connect it. In that sense it can theoretically be possible for these to be useful, but I think that case would be so vanishingly rare it's not worth it.
@BurntSushi

This comment has been minimized.

Sign in to view
Copy link
Member

BurntSushi commented Apr 21, 2016 •
edited

@alexcrichton Are there any cases where one would want or need to do that? (Otherwise, this sounds fine to me!)
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Apr 21, 2016

Probably not, just pointing out it's not literally useless, just morally so :)
@aturon

This comment has been minimized.

Sign in to view
Copy link
Member

aturon commented Apr 21, 2016

This is fine by me in principle.

If we're at all concern about the breakage, we could consider landing a deprecation warning (so that people get a heads up on nightly) and then landing the removal a couple weeks later.
@sfackler

This comment has been minimized.

Sign in to view
Copy link
Member Author

sfackler commented Apr 21, 2016

I'd normally go that route, but since in all reasonable uses these methods will never work, I'm not expecting anyone to be using them.
@aturon

This comment has been minimized.

Sign in to view
Copy link
Member

aturon commented Apr 21, 2016

I'd normally go that route, but since in all reasonable uses these methods will never work, I'm not expecting anyone to be using them.

Yep. I’m fine either way.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Apr 22, 2016

@bors: r+ c6480e8
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 23, 2016

⌛️ Testing commit c6480e8 with merge 23ccadd...

bors added a commit that referenced this pull request Apr 23, 2016

@bors
Auto merge of #33124 - sfackler:kill-ipv6-only, r=alexcrichton 
Remove IPV6_V6ONLY functionality

These settings can only be adjusted before bind time, which doesn't make
sense in the current set of functionality. These methods are stable, but
haven't hit a stable release yet.

Closes #33052

[breaking-change]

r? @alexcrichton

Will also need a backport to the beta.
23ccadd
@bors

@bors bors merged commit c6480e8 into rust-lang:master Apr 24, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@sfackler sfackler deleted the sfackler:kill-ipv6-only branch Apr 24, 2016

@alexcrichton alexcrichton referenced this pull request Apr 29, 2016

Merged

Remove IPV6_V6ONLY functionality #33263

@alexcrichton alexcrichton added beta-accepted and removed beta-nominated labels Apr 29, 2016

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Apr 29, 2016

Accepted for backport in #33263 (comment)

sfackler added a commit to sfackler/rust that referenced this pull request Dec 11, 2016

@sfackler
Deprecate TcpListener::set_only_v6 
This was supposed to have been removed in rust-lang#33124 but snuck through :(
897c796

@sfackler sfackler referenced this pull request Dec 11, 2016

Merged

Deprecate TcpListener::set_only_v6 #38304

sfackler added a commit to sfackler/rust that referenced this pull request Jan 6, 2017

@sfackler
Deprecate TcpListener::set_only_v6 
This was supposed to have been removed in rust-lang#33124 but snuck through :(
eb5e9ab

bors added a commit that referenced this pull request Jan 6, 2017

@bors
Auto merge of #38304 - sfackler:no-ipv6only, r=alexcrichton 
Deprecate TcpListener::set_only_v6

This was supposed to have been removed in #33124 but snuck through :(

Should the docs be removed?

I left the accessor undeprecated since it should actually work, though that method doesn't exist on other networking types.

r? @alexcrichton
cc @rust-lang/libs
Loading status checks…
a28701a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.