Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upadt: Allow repr attribute on single variant enum. #33355
Conversation
rust-highfive
assigned
nrc
May 2, 2016
This comment has been minimized.
This comment has been minimized.
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
|
Why can't we let |
aturon
added
I-nominated
T-lang
labels
May 6, 2016
This comment has been minimized.
This comment has been minimized.
|
Nominating for discussion at the next meeting, if we don't reach consensus before then. |
This comment has been minimized.
This comment has been minimized.
|
|
luqmana
force-pushed the
luqmana:33202-repr-ice
branch
2 times, most recently
from
9c47062
to
a08c398
May 11, 2016
This comment has been minimized.
This comment has been minimized.
|
Discussed in @rust-lang/lang meeting. I think we all agree it seems like permitting this annotation might be nice, but if it's awkward to implement, than an error is fine too. @luqmana what say you? |
nikomatsakis
removed
the
I-nominated
label
May 12, 2016
This comment has been minimized.
This comment has been minimized.
|
@nikomatsakis Ok, I made it an error because there was an asset in trans to that effect. I can change it to allow this. |
luqmana
force-pushed the
luqmana:33202-repr-ice
branch
from
a08c398
to
b556daa
May 13, 2016
luqmana
changed the title
typeck: Don't allow invalid reprs for univariant enums.
adt: Allow repr attribute on single variant enum.
May 13, 2016
luqmana
force-pushed the
luqmana:33202-repr-ice
branch
from
b556daa
to
f3e1d57
May 13, 2016
This comment has been minimized.
This comment has been minimized.
|
Ok, updated |
This comment has been minimized.
This comment has been minimized.
|
@bors: r+ |
This comment has been minimized.
This comment has been minimized.
|
|
luqmana commentedMay 2, 2016
•
edited
Fixes #33202.