Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: Change target_env for ARM targets to `gnu` #33403

Merged
merged 1 commit into from May 8, 2016

Conversation

@alexcrichton
Copy link
Member

alexcrichton commented May 4, 2016

Right now they're gnueabihf and gnueabi, but when adding new platforms like
musl on ARM it's unfortunate to have to test for all three (musl, musleabi,
and musleabihf). This PR switches everything currently to gnu, and the new
musl targets can also use musl when they land.

Closes #33244

Right now they're `gnueabihf` and `gnueabi`, but when adding new platforms like
musl on ARM it's unfortunate to have to test for all three (`musl`, `musleabi`,
and `musleabihf`). This PR switches everything currently to `gnu`, and the new
musl targets can also use `musl` when they land.

Closes #33244
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented May 4, 2016

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

This comment has been minimized.

Copy link
Member Author

alexcrichton commented May 4, 2016

r? @brson

@rust-highfive rust-highfive assigned brson and unassigned arielb1 May 4, 2016
@brson

This comment has been minimized.

Copy link
Contributor

brson commented May 4, 2016

Is there anywhere our cfgs are documented that can be updated to explain the scheme here?

@alexcrichton

This comment has been minimized.

Copy link
Member Author

alexcrichton commented May 4, 2016

Unfortunately not that I know of, no

@brson

This comment has been minimized.

Copy link
Contributor

brson commented May 4, 2016

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented May 4, 2016

📌 Commit 29875c2 has been approved by brson

@TimNN

This comment has been minimized.

Copy link
Contributor

TimNN commented May 5, 2016

I think theres some documentation in the reference?

@brson

This comment has been minimized.

Copy link
Contributor

brson commented May 5, 2016

@TimNN Thanks for the pointer. I'll send a followup patch.

brson added a commit to brson/rust that referenced this pull request May 5, 2016
The definition of this value recently changed slightly. It no
longer corresponds directly to the target triple.

Also shuffled things around to make the order of cfg descriptions more
logical and added text related them to the target triple.

cc rust-lang#33403
steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 5, 2016
doc: Update reference with better description of target_env

The definition of this value recently changed slightly. It no
longer corresponds directly to the target triple.

Also shuffled things around to make the order of cfg descriptions more
logical and added text related them to the target triple.

cc rust-lang#33403
steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 5, 2016
doc: Update reference with better description of target_env

The definition of this value recently changed slightly. It no
longer corresponds directly to the target triple.

Also shuffled things around to make the order of cfg descriptions more
logical and added text related them to the target triple.

cc rust-lang#33403
steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 5, 2016
doc: Update reference with better description of target_env

The definition of this value recently changed slightly. It no
longer corresponds directly to the target triple.

Also shuffled things around to make the order of cfg descriptions more
logical and added text related them to the target triple.

cc rust-lang#33403
steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 5, 2016
doc: Update reference with better description of target_env

The definition of this value recently changed slightly. It no
longer corresponds directly to the target triple.

Also shuffled things around to make the order of cfg descriptions more
logical and added text related them to the target triple.

cc rust-lang#33403
steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 6, 2016
doc: Update reference with better description of target_env

The definition of this value recently changed slightly. It no
longer corresponds directly to the target triple.

Also shuffled things around to make the order of cfg descriptions more
logical and added text related them to the target triple.

cc rust-lang#33403
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 7, 2016
doc: Update reference with better description of target_env

The definition of this value recently changed slightly. It no
longer corresponds directly to the target triple.

Also shuffled things around to make the order of cfg descriptions more
logical and added text related them to the target triple.

cc rust-lang#33403
steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 7, 2016
doc: Update reference with better description of target_env

The definition of this value recently changed slightly. It no
longer corresponds directly to the target triple.

Also shuffled things around to make the order of cfg descriptions more
logical and added text related them to the target triple.

cc rust-lang#33403
steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 7, 2016
doc: Update reference with better description of target_env

The definition of this value recently changed slightly. It no
longer corresponds directly to the target triple.

Also shuffled things around to make the order of cfg descriptions more
logical and added text related them to the target triple.

cc rust-lang#33403
@bors

This comment has been minimized.

Copy link
Contributor

bors commented May 8, 2016

⌛️ Testing commit 29875c2 with merge 4896832...

bors added a commit that referenced this pull request May 8, 2016
rustc: Change target_env for ARM targets to `gnu`

Right now they're `gnueabihf` and `gnueabi`, but when adding new platforms like
musl on ARM it's unfortunate to have to test for all three (`musl`, `musleabi`,
and `musleabihf`). This PR switches everything currently to `gnu`, and the new
musl targets can also use `musl` when they land.

Closes #33244
@bors bors merged commit 29875c2 into rust-lang:master May 8, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@alexcrichton alexcrichton deleted the alexcrichton:consistent-env branch May 12, 2016
dlrobertson pushed a commit to dlrobertson/rust that referenced this pull request Nov 29, 2018
The definition of this value recently changed slightly. It no
longer corresponds directly to the target triple.

Also shuffled things around to make the order of cfg descriptions more
logical and added text related them to the target triple.

cc rust-lang#33403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.