Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upfix DFS for region error reporting #33539
Conversation
rust-highfive
assigned
eddyb
May 10, 2016
This comment has been minimized.
This comment has been minimized.
|
well, maybe r? @pnkfelix |
rust-highfive
assigned
pnkfelix
and unassigned
eddyb
May 10, 2016
This comment has been minimized.
This comment has been minimized.
|
since I don't think @eddyb knows this code in particular |
This comment has been minimized.
This comment has been minimized.
|
@bors r+ rollup |
This comment has been minimized.
This comment has been minimized.
|
|
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
May 10, 2016
bors
added a commit
that referenced
this pull request
May 10, 2016
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
May 10, 2016
bors
added a commit
that referenced
this pull request
May 11, 2016
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
May 11, 2016
bors
added a commit
that referenced
this pull request
May 11, 2016
bors
merged commit de0906f
into
rust-lang:master
May 11, 2016
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
nikomatsakis
deleted the
nikomatsakis:static-error
branch
Oct 3, 2016
arielb1
referenced this pull request
Feb 24, 2017
Closed
Very unhelpful error message cannot infer an appropriate lifetime for autoref #22537
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
nikomatsakis commentedMay 10, 2016
This was causing terrible error reports, because the algorithm was incorrectly identifying the constraints.
r? @eddyb