Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: Add a new crate type, cdylib #33553

Merged
merged 2 commits into from May 20, 2016

Conversation

Reviewers
No reviews
Assignees

@brson brson

Labels
relnotes
Projects
None yet
Milestone
No milestone
10 participants
@alexcrichton @rust-highfive @brson @bors @eddyb @Manishearth @bluss @torkleyy @retep998 @jroesch
@alexcrichton
Copy link
Member

alexcrichton commented May 11, 2016

This commit is an implementation of RFC 1510 which adds a new crate type,
cdylib, to the compiler. This new crate type differs from the existing dylib
crate type in a few key ways:

  • No metadata is present in the final artifact
  • Symbol visibility rules are the same as executables, that is only reachable
    extern functions are visible symbols
  • LTO is allowed
  • All libraries are always linked statically

This commit is relatively simple by just plubming the compiler with another
crate type which takes different branches here and there. The only major change
is an implementation of the Linker::export_symbols function on Unix which now
actually does something. This helps restrict the public symbols from a cdylib on
Unix.

With this PR a "hello world" cdylib is 7.2K while the same dylib is 2.4MB,
which is some nice size savings!

Closes #33132

@rust-highfive rust-highfive assigned jroesch May 11, 2016

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented May 11, 2016

r? @jroesch

(rust_highfive has picked a reviewer for you, use r? to override)
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented May 11, 2016

r? @brson

@rust-highfive rust-highfive assigned brson and unassigned jroesch May 11, 2016

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented May 13, 2016

@bors r+

@brson brson closed this May 13, 2016

@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 13, 2016

📌 Commit a3f5d08 has been approved by brson

@brson brson reopened this May 13, 2016

eddyb added a commit to eddyb/rust that referenced this pull request May 13, 2016

@eddyb
Rollup merge of rust-lang#33553 - alexcrichton:cdylibs, r=brson 
rustc: Add a new crate type, cdylib

This commit is an implementation of [RFC 1510] which adds a new crate type,
`cdylib`, to the compiler. This new crate type differs from the existing `dylib`
crate type in a few key ways:

* No metadata is present in the final artifact
* Symbol visibility rules are the same as executables, that is only reachable
  `extern` functions are visible symbols
* LTO is allowed
* All libraries are always linked statically

This commit is relatively simple by just plubming the compiler with another
crate type which takes different branches here and there. The only major change
is an implementation of the `Linker::export_symbols` function on Unix which now
actually does something. This helps restrict the public symbols from a cdylib on
Unix.

With this PR a "hello world" `cdylib` is 7.2K while the same `dylib` is 2.4MB,
which is some nice size savings!

[RFC 1510]: rust-lang/rfcs#1510

Closes rust-lang#33132
63fdbd7

@eddyb eddyb referenced this pull request May 13, 2016

Closed

Rollup of 29 pull requests #33610

bors added a commit that referenced this pull request May 13, 2016

@bors
Auto merge of #33610 - eddyb:rollup, r=eddyb 
Rollup of 29 pull requests

- Successful merges: #33342, #33393, #33450, #33491, #33508, #33513, #33517, #33531, #33532, #33533, #33534, #33538, #33541, #33544, #33552, #33553, #33555, #33560, #33563, #33565, #33566, #33572, #33576, #33580, #33590, #33593, #33596, #33598, #33600
- Failed merges: #33578, #33602
1db8651
src/librustc_trans/back/linker.rs Outdated
let res = (|| -> io::Result<()> {
let mut f = BufWriter::new(File::create(&path)?);
for sym in exported_symbols(sess, trans, crate_type) {
writeln!(f, " {}", sym)?;

This comment has been minimized.

Sign in to view
Copy link
@eddyb

eddyb May 13, 2016

Member

This doesn't seem to be enough for iOS, see failure.
@eddyb

This comment has been minimized.

Sign in to view
Copy link
Member

eddyb commented May 13, 2016

@bors r- Likely responsible for this failure.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented May 13, 2016

Indeed! looks quite suspicious

@alexcrichton alexcrichton force-pushed the alexcrichton:cdylibs branch from a3f5d08 to bfe7a80 May 13, 2016

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented May 13, 2016

@bors: r=brson bfe7a80

bors added a commit that referenced this pull request May 13, 2016

@bors
Auto merge of #33610 - eddyb:rollup, r=eddyb 
Rollup of 29 pull requests

- Successful merges: #33342, #33393, #33450, #33491, #33508, #33513, #33517, #33531, #33532, #33533, #33534, #33538, #33541, #33544, #33552, #33553, #33555, #33560, #33563, #33565, #33566, #33572, #33576, #33580, #33590, #33593, #33596, #33598, #33600
- Failed merges: #33578, #33602
a2831f7

bors added a commit that referenced this pull request May 13, 2016

@bors
Auto merge of #33610 - eddyb:rollup, r=eddyb 
Rollup of 29 pull requests

- Successful merges: #33342, #33393, #33450, #33491, #33508, #33513, #33517, #33531, #33532, #33533, #33534, #33538, #33541, #33544, #33552, #33553, #33555, #33560, #33563, #33565, #33566, #33572, #33576, #33580, #33590, #33593, #33596, #33598, #33600
- Failed merges: #33578, #33602
244b73d
@Manishearth

This comment has been minimized.

Sign in to view
Copy link
Member

Manishearth commented May 14, 2016

Travis fails
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 14, 2016

⌛️ Testing commit bfe7a80 with merge 2d45326...

bors added a commit that referenced this pull request May 14, 2016

@bors
Auto merge of #33553 - alexcrichton:cdylibs, r=brson 
rustc: Add a new crate type, cdylib

This commit is an implementation of [RFC 1510] which adds a new crate type,
`cdylib`, to the compiler. This new crate type differs from the existing `dylib`
crate type in a few key ways:

* No metadata is present in the final artifact
* Symbol visibility rules are the same as executables, that is only reachable
  `extern` functions are visible symbols
* LTO is allowed
* All libraries are always linked statically

This commit is relatively simple by just plubming the compiler with another
crate type which takes different branches here and there. The only major change
is an implementation of the `Linker::export_symbols` function on Unix which now
actually does something. This helps restrict the public symbols from a cdylib on
Unix.

With this PR a "hello world" `cdylib` is 7.2K while the same `dylib` is 2.4MB,
which is some nice size savings!

[RFC 1510]: rust-lang/rfcs#1510

Closes #33132
2d45326
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 14, 2016

💔 Test failed - auto-mac-64-opt-rustbuild
@eddyb

This comment has been minimized.

Sign in to view
Copy link
Member

eddyb commented May 14, 2016

I'm working on rebasing this over #33602 because otherwise I'd need windows to investigate my metadata problem.
Could be delayed for a few days by my flight, so if you don't hear anything from me, feel free to merge this.

@alexcrichton alexcrichton force-pushed the alexcrichton:cdylibs branch from bfe7a80 to 557aae0 May 17, 2016

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented May 17, 2016

@bors: r=brson 557aae0

@eddyb I've applied your patch to retain the metadata symbol for dylibs, let's see how far it gets...
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 17, 2016

⌛️ Testing commit 557aae0 with merge 3ad8865...

bors added a commit that referenced this pull request May 17, 2016

@bors
Auto merge of #33553 - alexcrichton:cdylibs, r=brson 
rustc: Add a new crate type, cdylib

This commit is an implementation of [RFC 1510] which adds a new crate type,
`cdylib`, to the compiler. This new crate type differs from the existing `dylib`
crate type in a few key ways:

* No metadata is present in the final artifact
* Symbol visibility rules are the same as executables, that is only reachable
  `extern` functions are visible symbols
* LTO is allowed
* All libraries are always linked statically

This commit is relatively simple by just plubming the compiler with another
crate type which takes different branches here and there. The only major change
is an implementation of the `Linker::export_symbols` function on Unix which now
actually does something. This helps restrict the public symbols from a cdylib on
Unix.

With this PR a "hello world" `cdylib` is 7.2K while the same `dylib` is 2.4MB,
which is some nice size savings!

[RFC 1510]: rust-lang/rfcs#1510

Closes #33132
3ad8865
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 17, 2016

💔 Test failed - auto-linux-64-opt-rustbuild

@alexcrichton alexcrichton force-pushed the alexcrichton:cdylibs branch from 557aae0 to e3517db May 17, 2016

bors added a commit that referenced this pull request May 19, 2016

@bors
Auto merge of #33553 - alexcrichton:cdylibs, r=brson 
rustc: Add a new crate type, cdylib

This commit is an implementation of [RFC 1510] which adds a new crate type,
`cdylib`, to the compiler. This new crate type differs from the existing `dylib`
crate type in a few key ways:

* No metadata is present in the final artifact
* Symbol visibility rules are the same as executables, that is only reachable
  `extern` functions are visible symbols
* LTO is allowed
* All libraries are always linked statically

This commit is relatively simple by just plubming the compiler with another
crate type which takes different branches here and there. The only major change
is an implementation of the `Linker::export_symbols` function on Unix which now
actually does something. This helps restrict the public symbols from a cdylib on
Unix.

With this PR a "hello world" `cdylib` is 7.2K while the same `dylib` is 2.4MB,
which is some nice size savings!

[RFC 1510]: rust-lang/rfcs#1510

Closes #33132
2e0b0d3
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 19, 2016

💔 Test failed - auto-linux-musl-64-opt

@alexcrichton alexcrichton force-pushed the alexcrichton:cdylibs branch from 698ba68 to 0192796 May 19, 2016

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented May 19, 2016

@bors: r=brson 0192796
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 19, 2016

⌛️ Testing commit 0192796 with merge 89347bf...

bors added a commit that referenced this pull request May 19, 2016

@bors
Auto merge of #33553 - alexcrichton:cdylibs, r=brson 
rustc: Add a new crate type, cdylib

This commit is an implementation of [RFC 1510] which adds a new crate type,
`cdylib`, to the compiler. This new crate type differs from the existing `dylib`
crate type in a few key ways:

* No metadata is present in the final artifact
* Symbol visibility rules are the same as executables, that is only reachable
  `extern` functions are visible symbols
* LTO is allowed
* All libraries are always linked statically

This commit is relatively simple by just plubming the compiler with another
crate type which takes different branches here and there. The only major change
is an implementation of the `Linker::export_symbols` function on Unix which now
actually does something. This helps restrict the public symbols from a cdylib on
Unix.

With this PR a "hello world" `cdylib` is 7.2K while the same `dylib` is 2.4MB,
which is some nice size savings!

[RFC 1510]: rust-lang/rfcs#1510

Closes #33132
89347bf
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 19, 2016

💔 Test failed - auto-mac-64-nopt-t

alexcrichton and others added some commits May 10, 2016

@alexcrichton
rustc: Add a new crate type, cdylib 
This commit is an implementation of [RFC 1510] which adds a new crate type,
`cdylib`, to the compiler. This new crate type differs from the existing `dylib`
crate type in a few key ways:

* No metadata is present in the final artifact
* Symbol visibility rules are the same as executables, that is only reachable
  `extern` functions are visible symbols
* LTO is allowed
* All libraries are always linked statically

This commit is relatively simple by just plubming the compiler with another
crate type which takes different branches here and there. The only major change
is an implementation of the `Linker::export_symbols` function on Unix which now
actually does something. This helps restrict the public symbols from a cdylib on
Unix.

With this PR a "hello world" `cdylib` is 7.2K while the same `dylib` is 2.4MB,
which is some nice size savings!

[RFC 1510]: rust-lang/rfcs#1510

Closes #33132
07d373f
@eddyb @alexcrichton
Mark the metadata symbol as reachable to fix OSX not finding dylibs.
Loading status checks…
0d2c26c

@alexcrichton alexcrichton force-pushed the alexcrichton:cdylibs branch from 0192796 to 0d2c26c May 19, 2016

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented May 19, 2016

@bors: r=brson 0d2c26c
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 20, 2016

⌛️ Testing commit 0d2c26c with merge d27bdaf...

bors added a commit that referenced this pull request May 20, 2016

@bors
Auto merge of #33553 - alexcrichton:cdylibs, r=brson 
rustc: Add a new crate type, cdylib

This commit is an implementation of [RFC 1510] which adds a new crate type,
`cdylib`, to the compiler. This new crate type differs from the existing `dylib`
crate type in a few key ways:

* No metadata is present in the final artifact
* Symbol visibility rules are the same as executables, that is only reachable
  `extern` functions are visible symbols
* LTO is allowed
* All libraries are always linked statically

This commit is relatively simple by just plubming the compiler with another
crate type which takes different branches here and there. The only major change
is an implementation of the `Linker::export_symbols` function on Unix which now
actually does something. This helps restrict the public symbols from a cdylib on
Unix.

With this PR a "hello world" `cdylib` is 7.2K while the same `dylib` is 2.4MB,
which is some nice size savings!

[RFC 1510]: rust-lang/rfcs#1510

Closes #33132
d27bdaf
@bors

@bors bors merged commit 0d2c26c into rust-lang:master May 20, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@bors bors referenced this pull request May 20, 2016

Closed

rustc_trans: implement lld compatibility #33327

@bluss bluss added the relnotes label May 21, 2016

@bluss

This comment has been minimized.

Sign in to view
Copy link
Contributor

bluss commented May 21, 2016

This is kind of immediately a new feature on the stable release where this is included, isn't it? If I'm wrong, then the relnote tag can be removed again.

@briansmith briansmith referenced this pull request May 23, 2016

Open

Switch to cdylib crate type #4

@tomaka tomaka referenced this pull request May 24, 2016

Open

Consider switching to cdylibs #100

@pravic pravic referenced this pull request May 24, 2016

Closed

Consider switching to cdylib #8

@sdroege sdroege referenced this pull request May 24, 2016

Closed

Use cdylib crate type once available in stable Rust #5

@alexcrichton alexcrichton deleted the alexcrichton:cdylibs branch May 25, 2016

@SSheldon SSheldon referenced this pull request Jun 25, 2016

Open

Linker error for cdylib with panic=abort (Undefined symbol "_rust_eh_personality_catch") #34472

@baby-bell baby-bell referenced this pull request Sep 1, 2016

Closed

Change crate type to cdylib #40

@torkleyy

This comment has been minimized.

Sign in to view
Copy link

torkleyy commented Apr 9, 2017

@alexcrichton How can I compile a crate as cdylib without modifying Cargo.toml? I thought it would be cargo rustc -- --crate-type cdylib, but the crate-type option is just ignored.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Apr 10, 2017

@torkleyy unfortunately that's not possible right now (short of generating a new Cargo.toml. Would you like to open a new issue at rust-lang/cargo?
@torkleyy

This comment has been minimized.

Sign in to view
Copy link

torkleyy commented Apr 10, 2017

@alexcrichton Thanks for your reply!

Would you like to open a new issue at rust-lang/cargo?

Sure, I'll do that.

@rcatolino rcatolino referenced this pull request Jun 15, 2018

Closed

Cannot get example to run #2

@Walther Walther referenced this pull request Oct 10, 2018

Closed

`cargo run --example` false positive "is a library and cannot be executed" #6159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.