Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std: Use memalign, not posix_memalign, on Android #33832

Merged
merged 1 commit into from May 28, 2016

Conversation

Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
beta-accepted
Projects
None yet
Milestone
No milestone
8 participants
@alexcrichton @rust-highfive @luqmana @bors @GuillaumeGomez @nagisa @nikomatsakis @brson
@alexcrichton
Copy link
Member

alexcrichton commented May 24, 2016

We've gotten requests to move our Android support as far back as API level 9
where unfortunately the posix_memalign API wasn't implemented yet. Thankfully,
however, the memalign API was and it appears to be usable with free on the
Android platform (see comments included in commit).

This should help fix some of the last few test failures when compiling against
API level 9.

@rust-highfive rust-highfive assigned nikomatsakis May 24, 2016

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented May 24, 2016

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)
@luqmana

This comment has been minimized.

Sign in to view
Copy link
Member

luqmana commented May 24, 2016

@bors r+ rollup
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 24, 2016

📌 Commit 6584fb4 has been approved by luqmana

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 24, 2016

@GuillaumeGomez
Rollup merge of rust-lang#33832 - alexcrichton:android-memalign, r=lu… 
…qmana

std: Use memalign, not posix_memalign, on Android

We've gotten requests to move our Android support as far back as API level 9
where unfortunately the `posix_memalign` API wasn't implemented yet. Thankfully,
however, the `memalign` API was and it appears to be usable with `free` on the
Android platform (see comments included in commit).

This should help fix some of the last few test failures when compiling against
API level 9.
a0fc9cc

@GuillaumeGomez GuillaumeGomez referenced this pull request May 24, 2016

Merged

Rollup of 7 pull requests #33833

bors added a commit that referenced this pull request May 24, 2016

@bors
Auto merge of #33833 - GuillaumeGomez:rollup, r=GuillaumeGomez 
Rollup of 7 pull requests

- Successful merges: #33692, #33759, #33779, #33781, #33797, #33810, #33832
- Failed merges:
338ddd7
@GuillaumeGomez

This comment has been minimized.

Sign in to view
Copy link
Member

GuillaumeGomez commented May 24, 2016

@bors: r-

Some tests failed.

bors added a commit that referenced this pull request May 24, 2016

@bors
Auto merge of #33833 - GuillaumeGomez:rollup, r=GuillaumeGomez 
Rollup of 7 pull requests

- Successful merges: #33692, #33759, #33779, #33781, #33797, #33810, #33832
- Failed merges:
49719a6
@nagisa

This comment has been minimized.

Sign in to view
Copy link
Contributor

nagisa commented May 24, 2016

This is certainly a dangerous commit to put into rollup.

@bors rollup-
@nagisa

This comment has been minimized.

Sign in to view
Copy link
Contributor

nagisa commented May 24, 2016

@bors r+ rollup-

Test failure in the rollup seems to have nothing to do with this change.
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 24, 2016

📌 Commit 6584fb4 has been approved by nagisa
@nagisa

This comment has been minimized.

Sign in to view
Copy link
Contributor

nagisa commented May 24, 2016

@bors r=luqmana

Err.
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 24, 2016

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #33798
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 24, 2016

📌 Commit 6584fb4 has been approved by luqmana

bors added a commit that referenced this pull request May 24, 2016

@bors
Auto merge of #33833 - GuillaumeGomez:rollup, r=GuillaumeGomez 
Rollup of 7 pull requests

- Successful merges: #33692, #33759, #33779, #33781, #33797, #33810, #33832
- Failed merges:
8393d99

@alexcrichton alexcrichton referenced this pull request May 24, 2016

Merged

test: Use `set sysroot` for more NDK compatibility #33848

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented May 24, 2016

Nominating for beta based on this comment: #33848 (comment)

@alexcrichton alexcrichton added the beta-nominated label May 24, 2016

@alexcrichton
std: Use memalign, not posix_memalign, on Android 
We've gotten requests to move our Android support as far back as API level 9
where unfortunately the `posix_memalign` API wasn't implemented yet. Thankfully,
however, the `memalign` API was and it appears to be usable with `free` on the
Android platform (see comments included in commit).

This should help fix some of the last few test failures when compiling against
API level 9.
Loading status checks…
33dfd0f

@alexcrichton alexcrichton force-pushed the alexcrichton:android-memalign branch from 6584fb4 to 33dfd0f May 24, 2016

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented May 24, 2016

@bors: r=luqmana 33dfd0f

@nikomatsakis nikomatsakis added the beta-accepted label May 26, 2016

@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor

nikomatsakis commented May 26, 2016

Unclear that we are the right team to make this call, but the compiler team approves backporting to beta. :) Ordinarily we wouldn't backport this change, but since it helps with the bot infrastructure, seems fine.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented May 26, 2016

Oh right, yes sorry I intended to discuss this with the tools team this coming triage meeting.

@alexcrichton alexcrichton added the T-tools label May 26, 2016

Manishearth added a commit to Manishearth/rust that referenced this pull request May 28, 2016

@Manishearth
Rollup merge of rust-lang#33832 - alexcrichton:android-memalign, r=lu… 
…qmana

std: Use memalign, not posix_memalign, on Android

We've gotten requests to move our Android support as far back as API level 9
where unfortunately the `posix_memalign` API wasn't implemented yet. Thankfully,
however, the `memalign` API was and it appears to be usable with `free` on the
Android platform (see comments included in commit).

This should help fix some of the last few test failures when compiling against
API level 9.
f514326

@Manishearth Manishearth referenced this pull request May 28, 2016

Merged

Rollup of 15 pull requests #33927

bors added a commit that referenced this pull request May 28, 2016

@bors
Auto merge of #33927 - Manishearth:rollup, r=Manishearth 
Rollup of 15 pull requests

- Successful merges: #33820, #33821, #33822, #33824, #33825, #33831, #33832, #33848, #33849, #33852, #33854, #33856, #33859, #33860, #33861
- Failed merges:
cd608da

Manishearth added a commit to Manishearth/rust that referenced this pull request May 28, 2016

@Manishearth
Rollup merge of rust-lang#33832 - alexcrichton:android-memalign, r=lu… 
…qmana

std: Use memalign, not posix_memalign, on Android

We've gotten requests to move our Android support as far back as API level 9
where unfortunately the `posix_memalign` API wasn't implemented yet. Thankfully,
however, the `memalign` API was and it appears to be usable with `free` on the
Android platform (see comments included in commit).

This should help fix some of the last few test failures when compiling against
API level 9.
320dd04

bors added a commit that referenced this pull request May 28, 2016

@bors
Auto merge of #33927 - Manishearth:rollup, r=Manishearth 
Rollup of 15 pull requests

- Successful merges: #33820, #33821, #33822, #33824, #33825, #33831, #33832, #33848, #33849, #33852, #33854, #33856, #33859, #33860, #33861
- Failed merges:
f1776fe

@bors bors merged commit 33dfd0f into rust-lang:master May 28, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@alexcrichton alexcrichton deleted the alexcrichton:android-memalign branch May 31, 2016

@alexcrichton alexcrichton referenced this pull request May 31, 2016

Merged

Backport two small Android patches #33996

@brson brson removed the beta-nominated label May 31, 2016

@sanxiyn sanxiyn referenced this pull request Oct 7, 2016

Merged

Implement `read_offset` and `write_offset` #35704

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.