Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign uptest: Use `set sysroot` for more NDK compatibility #33848
Conversation
rust-highfive
assigned
brson
May 24, 2016
This comment has been minimized.
This comment has been minimized.
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
|
This, in combination with #33832 should enable us to move to the r11c NDK and API level 9 for our Android builders |
rust-highfive
assigned
michaelwoerister
and unassigned
brson
May 24, 2016
This comment has been minimized.
This comment has been minimized.
|
@bors: r+ |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
Ok, I've now verified that this plus #33832 gets a green build on Android, bringing improvements like:
I haven't deployed the buildbot changes just yet, and I'm hesitant to do so. These two changes are required and not present on the beta branch, so if we upgrade buildbot we'll be unable to build a new beta compiler (unless we use a different image to build a beta compiler than the nightly compiler. To me, there's a few courses of action to take here:
My preferred course of action is (2) as it's the easiest and probably doesn't have any impact anyway. This change isn't related to the build at all and #33832 should in theory be pretty minor as well. As a result I'm going to beta-nominate this and that, and we can discuss. |
alexcrichton
added
the
beta-nominated
label
May 24, 2016
alexcrichton
referenced this pull request
May 24, 2016
Merged
std: Use memalign, not posix_memalign, on Android #33832
This comment has been minimized.
This comment has been minimized.
|
(for those cc'd, see my previous comment) cc @froydnj - going back to API level 9 |
This comment has been minimized.
This comment has been minimized.
This seems like a reasonable course of action for propagating Android changes sooner. |
This comment has been minimized.
This comment has been minimized.
|
Given the minor impact of the changes, backporting seems fine to me. |
This comment has been minimized.
This comment has been minimized.
|
In this case, we should also get libc tests going on Android's AArch64. |
alexcrichton commentedMay 24, 2016
Recent versions of the Android NDK no longer ship debuggers like
arm-linux-androideabi-gdb, but instead one prebuilt binarygdb. We cansymlink this into place at least to get our detection still working, but it now
needs to be told what the sysroot is so it can correctly do... something. Long
story short, tests didn't pass with this change and after this change they pass.