Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRevert a change in the scope of macros imported from crates to fix a regression #34239
Conversation
rust-highfive
assigned
nrc
Jun 12, 2016
jseyfried
added some commits
Jun 11, 2016
jseyfried
force-pushed the
jseyfried:fix_macro_use_scope_regression
branch
from
d58f165
to
9d6adbf
Jun 12, 2016
jseyfried
force-pushed the
jseyfried:fix_macro_use_scope_regression
branch
from
9d6adbf
to
236b67a
Jun 12, 2016
jseyfried
referenced this pull request
Jun 12, 2016
Closed
Order of extern crate/pub mod matters suddenly #34212
This comment has been minimized.
This comment has been minimized.
|
@bors: r+ |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Jun 16, 2016
This comment has been minimized.
This comment has been minimized.
bors
merged commit 236b67a
into
rust-lang:master
Jun 16, 2016
This was referenced Jun 16, 2016
jseyfried
referenced this pull request
Jun 17, 2016
Merged
Support `#[macro_use]` on macro-expanded crates #34032
jseyfried
deleted the
jseyfried:fix_macro_use_scope_regression
branch
Oct 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jseyfried commentedJun 12, 2016
Fixes #34212.
The regression was caused by #34032, which changed the scope of macros imported from extern crates to match the scope of macros imported from modules.
r? @nrc