Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upconfigure: Remove clang version checks #34383
Conversation
rust-highfive
assigned
brson
Jun 20, 2016
This comment has been minimized.
This comment has been minimized.
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
|
@bors r+ |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
@alexcrichton we build C++ as part of our |
This comment has been minimized.
This comment has been minimized.
|
I’m not disagreeing with the change, though, but I think we should at least feature-check that c++11 mode is supported by the $CC. |
This comment has been minimized.
This comment has been minimized.
|
@nagisa true yeah, but if we finish compiling LLVM then using that same compiler to compiler the C++ that we have is almost always guaranteed to succeed. |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jun 22, 2016
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jun 22, 2016
bors
added a commit
that referenced
this pull request
Jun 22, 2016
bors
merged commit 3c77895
into
rust-lang:master
Jun 22, 2016
1 check passed
alexcrichton
deleted the
alexcrichton:less-compiler-checks
branch
Jun 28, 2016
This comment has been minimized.
This comment has been minimized.
|
Nominating for beta due to #34549 where the current beta branch (soon to become stable) will not compile on the most recent release of OSX. This should also have a very minimal impact on the actual behavior as well. |
alexcrichton commentedJun 20, 2016
We no C++ and an incredibly small amount of C code as part of the build, so
there's not really much need for us to strictly check the version of compilers
as we're not really stressing anything. LLVM is a pretty huge chunk of C++ but
it should be the responsibility of LLVM to ensure that it can build with a
particular clang/gcc version, not ours (as this logic changes over time).
These version checks seem to basically just by us a regular stream of PRs every
six weeks or so when a new version is releases, so they're not really buying us
much. As a result, remove them and we can add then back piecemeal perhaps as a
blacklist if we really need to.