Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: Remove clang version checks #34383

Merged
merged 1 commit into from Jun 22, 2016

Conversation

Projects
None yet
5 participants
@alexcrichton
Copy link
Member

alexcrichton commented Jun 20, 2016

We no C++ and an incredibly small amount of C code as part of the build, so
there's not really much need for us to strictly check the version of compilers
as we're not really stressing anything. LLVM is a pretty huge chunk of C++ but
it should be the responsibility of LLVM to ensure that it can build with a
particular clang/gcc version, not ours (as this logic changes over time).

These version checks seem to basically just by us a regular stream of PRs every
six weeks or so when a new version is releases, so they're not really buying us
much. As a result, remove them and we can add then back piecemeal perhaps as a
blacklist if we really need to.

configure: Remove clang version checks
We no C++ and an incredibly small amount of C code as part of the build, so
there's not really much need for us to strictly check the version of compilers
as we're not really stressing anything. LLVM is a pretty huge chunk of C++ but
it should be the responsibility of LLVM to ensure that it can build with a
particular clang/gcc version, not ours (as this logic changes over time).

These version checks seem to basically just by us a regular stream of PRs every
six weeks or so when a new version is releases, so they're not really buying us
much. As a result, remove them and we can add then back piecemeal perhaps as a
blacklist if we really need to.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jun 20, 2016

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@brson

This comment has been minimized.

Copy link
Contributor

brson commented Jun 21, 2016

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jun 21, 2016

📌 Commit 3c77895 has been approved by brson

@nagisa

This comment has been minimized.

Copy link
Contributor

nagisa commented Jun 21, 2016

@alexcrichton we build C++ as part of our src/rustllvm and those pull in basically whole of the LLVM headers into them. In the odd-case where a prebuilt LLVM is used no compiler compatibility version checks will be done and we might encounter compatibility issues.

@nagisa

This comment has been minimized.

Copy link
Contributor

nagisa commented Jun 21, 2016

I’m not disagreeing with the change, though, but I think we should at least feature-check that c++11 mode is supported by the $CC.

@alexcrichton

This comment has been minimized.

Copy link
Member Author

alexcrichton commented Jun 21, 2016

@nagisa true yeah, but if we finish compiling LLVM then using that same compiler to compiler the C++ that we have is almost always guaranteed to succeed.

Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 22, 2016

Rollup merge of rust-lang#34383 - alexcrichton:less-compiler-checks, …
…r=brson

configure: Remove clang version checks

We no C++ and an incredibly small amount of C code as part of the build, so
there's not really much need for us to strictly check the version of compilers
as we're not really stressing anything. LLVM is a pretty huge chunk of C++ but
it should be the responsibility of LLVM to ensure that it can build with a
particular clang/gcc version, not ours (as this logic changes over time).

These version checks seem to basically just by us a regular stream of PRs every
six weeks or so when a new version is releases, so they're not really buying us
much. As a result, remove them and we can add then back piecemeal perhaps as a
blacklist if we really need to.

Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 22, 2016

Rollup merge of rust-lang#34383 - alexcrichton:less-compiler-checks, …
…r=brson

configure: Remove clang version checks

We no C++ and an incredibly small amount of C code as part of the build, so
there's not really much need for us to strictly check the version of compilers
as we're not really stressing anything. LLVM is a pretty huge chunk of C++ but
it should be the responsibility of LLVM to ensure that it can build with a
particular clang/gcc version, not ours (as this logic changes over time).

These version checks seem to basically just by us a regular stream of PRs every
six weeks or so when a new version is releases, so they're not really buying us
much. As a result, remove them and we can add then back piecemeal perhaps as a
blacklist if we really need to.

bors added a commit that referenced this pull request Jun 22, 2016

Auto merge of #34408 - Manishearth:rollup, r=Manishearth
Rollup of 7 pull requests

- Successful merges: #34190, #34363, #34367, #34383, #34387, #34394, #34404
- Failed merges:

@bors bors merged commit 3c77895 into rust-lang:master Jun 22, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@alexcrichton alexcrichton deleted the alexcrichton:less-compiler-checks branch Jun 28, 2016

@alexcrichton

This comment has been minimized.

Copy link
Member Author

alexcrichton commented Jun 29, 2016

Nominating for beta due to #34549 where the current beta branch (soon to become stable) will not compile on the most recent release of OSX. This should also have a very minimal impact on the actual behavior as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.