Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upDon't crash in item_path when an item lacks a name #34561
Conversation
rust-highfive
assigned
brson
Jun 29, 2016
This comment has been minimized.
This comment has been minimized.
arielb1
added
beta-nominated
T-compiler
labels
Jun 29, 2016
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This already landed in master as part of a larger PR, with the motivation of unbreaking logging so I could debug some issue, so I can't really open a new one. This is indeed an unmodified cherry-pick of f6068ea. |
This comment has been minimized.
This comment has been minimized.
|
Ok cool, sounds good to me! |
This comment has been minimized.
This comment has been minimized.
|
cc @rust-lang/compiler about backporting |
This comment has been minimized.
This comment has been minimized.
|
sgtm |
This comment has been minimized.
This comment has been minimized.
|
With a lack of r+, the fact that this is already on stable, and the fact that the stable 1.10 release is to be built tomorrow, this is relatively unlikely to be backported at this point. If it's critical to include, however, we can make it work. |
This comment has been minimized.
This comment has been minimized.
|
We want to include this - the regression is very annoying when it hits. Could @eddyb r+ this? |
This comment has been minimized.
This comment has been minimized.
|
This is indeed a regression to 1.9 (current stable). In that case, I don't think we should backport. |
arielb1
closed this
Jul 3, 2016
This comment has been minimized.
This comment has been minimized.
|
Ok, removing the beta-nominated tag from this as well. |
arielb1 commentedJun 29, 2016
Fixes #34027
We may want to use a better name than
<unnamed>, but I just cherry-picked my old commit.r? @brson