Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jemalloc to include a fix for startup issues on OSX 10.12 #34719

Merged
merged 1 commit into from Jul 9, 2016

Conversation

Projects
None yet
7 participants
@glandium
Copy link
Contributor

glandium commented Jul 8, 2016

This fixes jemalloc/jemalloc#140 in the version used by the rust compiler.

Fixes #34674

Update jemalloc to include a fix for startup issues on OSX 10.12
This fixes jemalloc/jemalloc#140 in the version used by the rust compiler.

Fixes #34674
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jul 8, 2016

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@glandium

This comment has been minimized.

Copy link
Contributor Author

glandium commented Jul 8, 2016

Cloning into 'src/jemalloc'...
fatal: reference is not a tree: e058ca661692a8d01f8cf9d35939dfe3105ce968

Obviously it's not merged yet... this will need a rebuild after it's merged.

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Jul 8, 2016

@bors: r+ 3fd0387

Thanks @glandium! I can only imagine how fun this must have been to find and fix...

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Jul 8, 2016

Also, nominating for beta as this seems like it's better to get out there sooner rather than later (e.g. 1.11 instead of 1.12)

@Manishearth

This comment has been minimized.

Copy link
Member

Manishearth commented Jul 8, 2016

fails travis

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jul 9, 2016

⌛️ Testing commit 3fd0387 with merge 24d51f9...

bors added a commit that referenced this pull request Jul 9, 2016

Auto merge of #34719 - glandium:issue34674, r=alexcrichton
Update jemalloc to include a fix for startup issues on OSX 10.12

This fixes jemalloc/jemalloc#140 in the version used by the rust compiler.

Fixes #34674

@bors bors merged commit 3fd0387 into rust-lang:master Jul 9, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Jul 19, 2016

Discussed at libs triage today we decided to accept this for a backport to beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.