Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate jemalloc to include a fix for startup issues on OSX 10.12 #34719
Conversation
rust-highfive
assigned
nikomatsakis
Jul 8, 2016
This comment has been minimized.
This comment has been minimized.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
This comment has been minimized.
This comment has been minimized.
Obviously it's not merged yet... this will need a rebuild after it's merged. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Also, nominating for beta as this seems like it's better to get out there sooner rather than later (e.g. 1.11 instead of 1.12) |
alexcrichton
added
beta-nominated
T-libs
labels
Jul 8, 2016
This comment has been minimized.
This comment has been minimized.
|
fails travis |
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Jul 9, 2016
This comment has been minimized.
This comment has been minimized.
bors
merged commit 3fd0387
into
rust-lang:master
Jul 9, 2016
TimNN
referenced this pull request
Jul 9, 2016
Closed
rustc hangs forever, using 100% CPU, when building rust from source and when running cargo #34741
This comment has been minimized.
This comment has been minimized.
|
Discussed at libs triage today we decided to accept this for a backport to beta |
glandium commentedJul 8, 2016
This fixes jemalloc/jemalloc#140 in the version used by the rust compiler.
Fixes #34674