Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no_stack_check (#34915) #35027

Closed
wants to merge 1 commit into from
Closed

Remove no_stack_check (#34915) #35027

wants to merge 1 commit into from

Conversation

abhijeetbhagat
Copy link
Contributor

Part of fixes for #34915

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

Thanks for the PR! Unfortunately I don't think we can remove this command line option as it's a stable compiler flag right now, so this runs the risk of breaking others' compilations. It may be worth issuing a warning indicating that this doesn't do anything any more, but perhaps for now just the help description could be updated to indicate this?

@brson
Copy link
Contributor

brson commented Jul 25, 2016

Agree with @alexcrichton, sadly.

@nagisa
Copy link
Member

nagisa commented Jul 26, 2016

compiler team concluded… kill any compiler flag that exposing a similar thingie.

from #34915 (comment), for a reference.

I guess it could go through a deprecation of some sort, though.

@brson
Copy link
Contributor

brson commented Jul 27, 2016

Thanks for pointing that out @nagisa. @rust-lang/compiler This PR removes -C no-stack-check but that is a stable flag. Our policy is to not remove them so it's been proposed to make it a no-op. What say you?

@nrc
Copy link
Member

nrc commented Jul 27, 2016

Could we at least warn that it is a no-op - silently changing behaviour is bad

@eddyb
Copy link
Member

eddyb commented Jul 27, 2016

@nrc Nothing actually checks no_stack_check though, there's no behavior to change.

@nrc
Copy link
Member

nrc commented Jul 28, 2016

That seems like even more reason to warn the user that they are doing something that is not going to have the effect which they expect.

@brson
Copy link
Contributor

brson commented Jul 30, 2016

@abhijeetbhagat Can we go ahead and change this patch to instead print out a warning "the --no-stack-check flag is deprecated and does nothing"? Thanks for your patience.

@abhijeetbhagat
Copy link
Contributor Author

r? @brson

@brson
Copy link
Contributor

brson commented Aug 1, 2016

@abhijeetbhagat Oh, I see you opened another issue for this. I'll comment on that one.

@brson brson closed this Aug 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants